From a581d20f8e7600fd3f4b8063677864a6a3962692 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Thu, 2 Mar 2017 15:33:23 -0800 Subject: [PATCH] Desktop update: Wait before clicking update apply button We used to do this only for KDE, but I've seen the new update tests sometimes fail at this point for no apparent reason, and I'm thinking a wait may help (in case they're clicking the button before it's really 'ready'). --- tests/desktop_update_graphical.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/desktop_update_graphical.pm b/tests/desktop_update_graphical.pm index 9a9a4dba..4592aafa 100644 --- a/tests/desktop_update_graphical.pm +++ b/tests/desktop_update_graphical.pm @@ -48,10 +48,10 @@ sub run { mouse_hide; } # KDE annoyingly pops the notification up right over the install - # button, which doesn't help...wait for it to go away - if ($desktop eq 'kde') { - wait_still_screen 5; - } + # button, which doesn't help...wait for it to go away. Let's also + # wait on GNOME, as we've had tests fail at this point for no + # obvious reason, a wait may help. + wait_still_screen 5; assert_and_click 'desktop_package_tool_update_apply'; # on GNOME, wait for reboots. if ($desktop eq 'gnome') {