Workaround #1805553 (single disk not selected as install target)

Rawhide seems to have developed a bug where a single disk is no
longer automatically selected as the install target when you
enter the INSTALLATION DESTINATION spoke. We need to work around
this (but register it as a soft failure).

Signed-off-by: Adam Williamson <awilliam@redhat.com>

lib/anaconda.pm

@@ -40,15 +40,26 @@ sub select_disks {
         }
     }
     else {
-        # Single disk case.
+        # Single disk cases.
         if ($args{disks} == 0) {
-            # Clicking will *de*-select.
+            # Clicking will *de*-select...unless we're running into
-            assert_and_click "anaconda_install_destination_select_disk_1";
+            # FIXME #1805553, in which case we should do nothing
+            if (check_screen "anaconda_install_destination_disk_selected") {
+                assert_and_click "anaconda_install_destination_select_disk_1";
+            }
+            else {
+                record_soft_failure "Single disk not selected as install target - #1805553";
+            }
         }
         elsif ($args{disks} > 1) {
             die "Only one disk is connected! Cannot select $args{disks} disks.";
         }
-        # For exactly 1 disk, we don't need to do anything.
+        # For exactly 1 disk, we don't need to do anything, unless
+        # we run into FIXME #1805553...
+        unless (check_screen "anaconda_install_destination_disk_selected") {
+            record_soft_failure "Single disk not selected as install target - #1805553";
+            assert_and_click "anaconda_install_destination_select_disk_1";
+        }
     }
 
     # Handle network disks.

needles/anaconda/install_destination/disk_selected-20200220.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 89,
+      "ypos": 242,
+      "width": 25,
+      "height": 25,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "anaconda_install_destination_disk_selected"
+  ]
+}