From e5dc67126dac8e1ee101678f427cbfb7a1a54ce2 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Thu, 26 Jan 2017 14:32:42 +0100 Subject: [PATCH] Fix check_release, menu_launch_type, start_cockpit I accidentally left the `my $self = shift` lines in these when changing them from methods into functions, so they don't work right at all. Whoops. Sorry. --- lib/utils.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/utils.pm b/lib/utils.pm index bbacc0a8..3da25b33 100644 --- a/lib/utils.pm +++ b/lib/utils.pm @@ -245,7 +245,6 @@ sub check_release { # Fedora 23. The value can be 'Rawhide' or a Fedora release # number; often you will want to use `get_var('VERSION')`. Expects # a console prompt to be active when it is called. - my $self = shift; my $release = shift; my $check_command = "grep SUPPORT_PRODUCT_VERSION /usr/lib/os.release.d/os-release-fedora"; validate_script_output $check_command, sub { $_ =~ m/REDHAT_SUPPORT_PRODUCT_VERSION=$release/ }; @@ -255,7 +254,6 @@ sub menu_launch_type { # Launch an application in a graphical environment, by opening a # launcher, typing the specified string and hitting enter. Pass # the string to be typed to launch whatever it is you want. - my $self = shift; my $app = shift; # super does not work on KDE, because fml send_key 'alt-f1'; @@ -269,7 +267,6 @@ sub start_cockpit { # Starting from a console, get to a browser with Cockpit (running # on localhost) shown. If $login is truth-y, also log in. Assumes # X and Firefox are installed. - my $self = shift; my $login = shift || 0; # run firefox directly in X as root. never do this, kids! type_string "startx /usr/bin/firefox -width 1024 -height 768 http://localhost:9090\n";