From e68e113f76dacd3bd14f94ab84687bc3784c255e Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Mon, 10 Apr 2017 15:00:10 -0700 Subject: [PATCH] Remove test_flags comments, add ignore_failure flag It's not really a good idea to have the comments that explain the test_flags in *every* test, because they can go stale and then we either have to live with them being old or update them all. Like, now. So let's just take 'em all out. There's always a reference in the openQA and os-autoinst docs, and those get updated faster. More importantly, add the new `ignore_failure` flag to relevant tests - all the tests that don't have the 'important' or 'fatal' flag at present. Upstream killed the 'important' flag (making all tests 'important' by default), I got it replaced with the 'ignore_failure' flag, we now need to explicitly mark all modules we want the 'ignore_failure' behaviour for. --- tests/_advisory_post.pm | 4 ---- tests/_advisory_update.pm | 4 ---- tests/_anaconda_network_static.pm | 4 ---- tests/_boot_to_anaconda.pm | 4 ---- tests/_check_install_source.pm | 4 ---- tests/_collect_data.pm | 6 +----- tests/_console_avc_crash.pm | 6 +----- tests/_console_login.pm | 4 ---- tests/_console_shutdown.pm | 7 +------ tests/_console_wait_login.pm | 4 ---- tests/_do_install_and_reboot.pm | 4 ---- tests/_graphical_input.pm | 4 ---- tests/_graphical_wait_login.pm | 4 ---- tests/_memcheck.pm | 4 ---- tests/_post_network_static.pm | 4 ---- tests/_software_selection.pm | 4 ---- tests/_support_server.pm | 4 ---- tests/base_selinux.pm | 4 ---- tests/base_service_manipulation.pm | 4 ---- tests/base_services_start.pm | 4 ---- tests/base_update_cli.pm | 4 ---- tests/database_client.pm | 4 ---- tests/desktop_browser.pm | 4 ---- tests/desktop_notifications.pm | 4 ---- tests/desktop_terminal.pm | 4 ---- tests/desktop_update_graphical.pm | 4 ---- tests/disk_custom_btrfs.pm | 4 ---- tests/disk_custom_ext3.pm | 4 ---- tests/disk_custom_iscsi.pm | 4 ---- tests/disk_custom_iscsi_postinstall.pm | 4 ---- tests/disk_custom_lvmthin.pm | 4 ---- tests/disk_custom_no_swap.pm | 4 ---- tests/disk_custom_software_raid.pm | 4 ---- tests/disk_custom_software_raid_postinstall.pm | 4 ---- tests/disk_custom_xfs.pm | 4 ---- tests/disk_guided_delete_all.pm | 4 ---- tests/disk_guided_delete_partial.pm | 4 ---- tests/disk_guided_delete_partial_postinstall.pm | 4 ---- tests/disk_guided_empty.pm | 4 ---- tests/disk_guided_encrypted.pm | 4 ---- tests/disk_guided_encrypted_postinstall.pm | 4 ---- tests/disk_guided_free_space_postinstall.pm | 4 ---- tests/disk_guided_multi.pm | 4 ---- tests/disk_guided_multi_empty_all.pm | 4 ---- tests/disk_guided_multi_empty_all_postinstall.pm | 4 ---- tests/disk_guided_multi_postinstall.pm | 4 ---- tests/disk_guided_shrink.pm | 4 ---- tests/disk_guided_shrink_postinstall.pm | 4 ---- tests/firewall_configured.pm | 4 ---- tests/firewall_disabled.pm | 4 ---- tests/freeipa_client.pm | 4 ---- tests/freeipa_password_change.pm | 6 +----- tests/freeipa_webui.pm | 6 +----- tests/install_arm_image_deployment.pm | 4 ---- tests/install_source_graphical.pm | 4 ---- tests/install_text.pm | 4 ---- tests/realmd_join_cockpit.pm | 4 ---- tests/realmd_join_sssd.pm | 4 ---- tests/rescue_mode_encrypted.pm | 4 ---- tests/role_deploy_database_server.pm | 4 ---- tests/role_deploy_domain_controller.pm | 4 ---- tests/server_cockpit_basic.pm | 4 ---- tests/server_cockpit_default.pm | 4 ---- tests/server_firewall_default.pm | 4 ---- tests/uefi_postinstall.pm | 4 ---- tests/upgrade_postinstall.pm | 4 ---- tests/upgrade_preinstall.pm | 4 ---- tests/upgrade_run.pm | 4 ---- 68 files changed, 5 insertions(+), 278 deletions(-) diff --git a/tests/_advisory_post.pm b/tests/_advisory_post.pm index e6e8e29f..4aacebd5 100644 --- a/tests/_advisory_post.pm +++ b/tests/_advisory_post.pm @@ -16,10 +16,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_advisory_update.pm b/tests/_advisory_update.pm index cb5bf1b9..3c65d42c 100644 --- a/tests/_advisory_update.pm +++ b/tests/_advisory_update.pm @@ -18,10 +18,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_anaconda_network_static.pm b/tests/_anaconda_network_static.pm index 7a39a8eb..c15e595b 100644 --- a/tests/_anaconda_network_static.pm +++ b/tests/_anaconda_network_static.pm @@ -29,10 +29,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_boot_to_anaconda.pm b/tests/_boot_to_anaconda.pm index 61f82f93..d0a9ec4c 100644 --- a/tests/_boot_to_anaconda.pm +++ b/tests/_boot_to_anaconda.pm @@ -73,10 +73,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_check_install_source.pm b/tests/_check_install_source.pm index 021c06d8..6fa73379 100644 --- a/tests/_check_install_source.pm +++ b/tests/_check_install_source.pm @@ -32,10 +32,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_collect_data.pm b/tests/_collect_data.pm index f9155447..83556db6 100644 --- a/tests/_collect_data.pm +++ b/tests/_collect_data.pm @@ -18,11 +18,7 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' - return {}; + return { 'ignore_failure' => 1 }; } 1; diff --git a/tests/_console_avc_crash.pm b/tests/_console_avc_crash.pm index ed8ec9d2..62cb1f4f 100644 --- a/tests/_console_avc_crash.pm +++ b/tests/_console_avc_crash.pm @@ -20,11 +20,7 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' - return {}; + return { 'ignore_failure' => 1 }; } 1; diff --git a/tests/_console_login.pm b/tests/_console_login.pm index fb7c17f1..86e1f238 100644 --- a/tests/_console_login.pm +++ b/tests/_console_login.pm @@ -17,10 +17,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1, milestone => 1 }; } diff --git a/tests/_console_shutdown.pm b/tests/_console_shutdown.pm index 392ba3cb..7646bf94 100644 --- a/tests/_console_shutdown.pm +++ b/tests/_console_shutdown.pm @@ -19,12 +19,7 @@ sub run { # even if shutdown fails. we should have a separate test for shutdown/ # logout/reboot stuff, might need some refactoring. sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'norollback' - don't rollback if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' - return {'norollback' => 1}; + return { 'norollback' => 1, 'ignore_failure' => 1 }; } 1; diff --git a/tests/_console_wait_login.pm b/tests/_console_wait_login.pm index c19b9885..d13313e4 100644 --- a/tests/_console_wait_login.pm +++ b/tests/_console_wait_login.pm @@ -28,10 +28,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1, milestone => 1 }; } diff --git a/tests/_do_install_and_reboot.pm b/tests/_do_install_and_reboot.pm index 6e19ce01..59a45f07 100644 --- a/tests/_do_install_and_reboot.pm +++ b/tests/_do_install_and_reboot.pm @@ -77,10 +77,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_graphical_input.pm b/tests/_graphical_input.pm index 02602e9c..31f9b9be 100644 --- a/tests/_graphical_input.pm +++ b/tests/_graphical_input.pm @@ -31,10 +31,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_graphical_wait_login.pm b/tests/_graphical_wait_login.pm index cb567f37..916c9cee 100644 --- a/tests/_graphical_wait_login.pm +++ b/tests/_graphical_wait_login.pm @@ -76,10 +76,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1, milestone => 1 }; } diff --git a/tests/_memcheck.pm b/tests/_memcheck.pm index 91b68fa4..58e219d6 100644 --- a/tests/_memcheck.pm +++ b/tests/_memcheck.pm @@ -9,10 +9,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_post_network_static.pm b/tests/_post_network_static.pm index 8e09b9ed..8213e227 100644 --- a/tests/_post_network_static.pm +++ b/tests/_post_network_static.pm @@ -13,10 +13,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_software_selection.pm b/tests/_software_selection.pm index bff423d3..64aa2aa0 100644 --- a/tests/_software_selection.pm +++ b/tests/_software_selection.pm @@ -39,10 +39,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/_support_server.pm b/tests/_support_server.pm index 18212da4..2cd6fd19 100644 --- a/tests/_support_server.pm +++ b/tests/_support_server.pm @@ -60,10 +60,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/base_selinux.pm b/tests/base_selinux.pm index ef5938cb..5337ee48 100644 --- a/tests/base_selinux.pm +++ b/tests/base_selinux.pm @@ -11,10 +11,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/base_service_manipulation.pm b/tests/base_service_manipulation.pm index 259ea88f..4341949c 100644 --- a/tests/base_service_manipulation.pm +++ b/tests/base_service_manipulation.pm @@ -48,10 +48,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/base_services_start.pm b/tests/base_services_start.pm index 30daeb5c..5a776546 100644 --- a/tests/base_services_start.pm +++ b/tests/base_services_start.pm @@ -25,10 +25,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/base_update_cli.pm b/tests/base_update_cli.pm index 5782f8ba..66221d08 100644 --- a/tests/base_update_cli.pm +++ b/tests/base_update_cli.pm @@ -24,10 +24,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/database_client.pm b/tests/database_client.pm index bd9313dc..0fb2b829 100644 --- a/tests/database_client.pm +++ b/tests/database_client.pm @@ -19,10 +19,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/desktop_browser.pm b/tests/desktop_browser.pm index 672a5002..6bad0945 100644 --- a/tests/desktop_browser.pm +++ b/tests/desktop_browser.pm @@ -59,10 +59,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/desktop_notifications.pm b/tests/desktop_notifications.pm index 75a65dcf..70d60bd3 100644 --- a/tests/desktop_notifications.pm +++ b/tests/desktop_notifications.pm @@ -98,10 +98,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/desktop_terminal.pm b/tests/desktop_terminal.pm index dd5b7c8d..262a934c 100644 --- a/tests/desktop_terminal.pm +++ b/tests/desktop_terminal.pm @@ -24,10 +24,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/desktop_update_graphical.pm b/tests/desktop_update_graphical.pm index 4592aafa..80fe5d79 100644 --- a/tests/desktop_update_graphical.pm +++ b/tests/desktop_update_graphical.pm @@ -84,10 +84,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_btrfs.pm b/tests/disk_custom_btrfs.pm index 96d2495a..2740eb6f 100644 --- a/tests/disk_custom_btrfs.pm +++ b/tests/disk_custom_btrfs.pm @@ -23,10 +23,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_ext3.pm b/tests/disk_custom_ext3.pm index b9f5f29f..16e28421 100644 --- a/tests/disk_custom_ext3.pm +++ b/tests/disk_custom_ext3.pm @@ -26,10 +26,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_iscsi.pm b/tests/disk_custom_iscsi.pm index bcc5d924..6481a89c 100644 --- a/tests/disk_custom_iscsi.pm +++ b/tests/disk_custom_iscsi.pm @@ -25,10 +25,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_iscsi_postinstall.pm b/tests/disk_custom_iscsi_postinstall.pm index a37b0649..28a5386a 100644 --- a/tests/disk_custom_iscsi_postinstall.pm +++ b/tests/disk_custom_iscsi_postinstall.pm @@ -12,10 +12,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_lvmthin.pm b/tests/disk_custom_lvmthin.pm index 279bc4c6..596b9ae3 100644 --- a/tests/disk_custom_lvmthin.pm +++ b/tests/disk_custom_lvmthin.pm @@ -24,10 +24,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_no_swap.pm b/tests/disk_custom_no_swap.pm index 04d2bd7c..203c424b 100644 --- a/tests/disk_custom_no_swap.pm +++ b/tests/disk_custom_no_swap.pm @@ -26,10 +26,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_software_raid.pm b/tests/disk_custom_software_raid.pm index c6385729..ae4d6d39 100644 --- a/tests/disk_custom_software_raid.pm +++ b/tests/disk_custom_software_raid.pm @@ -22,10 +22,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_software_raid_postinstall.pm b/tests/disk_custom_software_raid_postinstall.pm index 314f200e..29319dda 100644 --- a/tests/disk_custom_software_raid_postinstall.pm +++ b/tests/disk_custom_software_raid_postinstall.pm @@ -9,10 +9,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_custom_xfs.pm b/tests/disk_custom_xfs.pm index 56f409e2..77bc5868 100644 --- a/tests/disk_custom_xfs.pm +++ b/tests/disk_custom_xfs.pm @@ -26,10 +26,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_delete_all.pm b/tests/disk_guided_delete_all.pm index 40ad3558..025a99ea 100644 --- a/tests/disk_guided_delete_all.pm +++ b/tests/disk_guided_delete_all.pm @@ -23,10 +23,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_delete_partial.pm b/tests/disk_guided_delete_partial.pm index 0e521798..f426c491 100644 --- a/tests/disk_guided_delete_partial.pm +++ b/tests/disk_guided_delete_partial.pm @@ -26,10 +26,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_delete_partial_postinstall.pm b/tests/disk_guided_delete_partial_postinstall.pm index 2e876369..0983a1eb 100644 --- a/tests/disk_guided_delete_partial_postinstall.pm +++ b/tests/disk_guided_delete_partial_postinstall.pm @@ -10,10 +10,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_empty.pm b/tests/disk_guided_empty.pm index 1696e36f..4c215aba 100644 --- a/tests/disk_guided_empty.pm +++ b/tests/disk_guided_empty.pm @@ -23,10 +23,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_encrypted.pm b/tests/disk_guided_encrypted.pm index ea0a3a23..f5903948 100644 --- a/tests/disk_guided_encrypted.pm +++ b/tests/disk_guided_encrypted.pm @@ -35,10 +35,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_encrypted_postinstall.pm b/tests/disk_guided_encrypted_postinstall.pm index 021ed89c..00da6cef 100644 --- a/tests/disk_guided_encrypted_postinstall.pm +++ b/tests/disk_guided_encrypted_postinstall.pm @@ -14,10 +14,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_free_space_postinstall.pm b/tests/disk_guided_free_space_postinstall.pm index 778bf8ef..54b6cb87 100644 --- a/tests/disk_guided_free_space_postinstall.pm +++ b/tests/disk_guided_free_space_postinstall.pm @@ -10,10 +10,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_multi.pm b/tests/disk_guided_multi.pm index 827211b6..bb068a2e 100644 --- a/tests/disk_guided_multi.pm +++ b/tests/disk_guided_multi.pm @@ -16,10 +16,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_multi_empty_all.pm b/tests/disk_guided_multi_empty_all.pm index 940c7467..bcba059e 100644 --- a/tests/disk_guided_multi_empty_all.pm +++ b/tests/disk_guided_multi_empty_all.pm @@ -16,10 +16,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_multi_empty_all_postinstall.pm b/tests/disk_guided_multi_empty_all_postinstall.pm index 07dc6f6e..ab2026f5 100644 --- a/tests/disk_guided_multi_empty_all_postinstall.pm +++ b/tests/disk_guided_multi_empty_all_postinstall.pm @@ -10,10 +10,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_multi_postinstall.pm b/tests/disk_guided_multi_postinstall.pm index a464da3a..60fb71ab 100644 --- a/tests/disk_guided_multi_postinstall.pm +++ b/tests/disk_guided_multi_postinstall.pm @@ -10,10 +10,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_shrink.pm b/tests/disk_guided_shrink.pm index a854fc8d..779dc244 100644 --- a/tests/disk_guided_shrink.pm +++ b/tests/disk_guided_shrink.pm @@ -28,10 +28,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/disk_guided_shrink_postinstall.pm b/tests/disk_guided_shrink_postinstall.pm index 28cfa6ff..2b5c24cb 100644 --- a/tests/disk_guided_shrink_postinstall.pm +++ b/tests/disk_guided_shrink_postinstall.pm @@ -10,10 +10,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/firewall_configured.pm b/tests/firewall_configured.pm index 89b75be7..6e746c1f 100644 --- a/tests/firewall_configured.pm +++ b/tests/firewall_configured.pm @@ -17,10 +17,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/firewall_disabled.pm b/tests/firewall_disabled.pm index d14e001a..bb01159e 100644 --- a/tests/firewall_disabled.pm +++ b/tests/firewall_disabled.pm @@ -14,10 +14,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/freeipa_client.pm b/tests/freeipa_client.pm index 49ccc5a2..00b45e8a 100644 --- a/tests/freeipa_client.pm +++ b/tests/freeipa_client.pm @@ -38,10 +38,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/freeipa_password_change.pm b/tests/freeipa_password_change.pm index 911f53bc..f010a688 100644 --- a/tests/freeipa_password_change.pm +++ b/tests/freeipa_password_change.pm @@ -45,11 +45,7 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' - return {}; + return { 'ignore_failure' => 1 }; } 1; diff --git a/tests/freeipa_webui.pm b/tests/freeipa_webui.pm index e535f522..afe60bc0 100644 --- a/tests/freeipa_webui.pm +++ b/tests/freeipa_webui.pm @@ -68,11 +68,7 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' - return { milestone => 1 }; + return { 'ignore_failure' => 1, 'milestone' => 1 }; } 1; diff --git a/tests/install_arm_image_deployment.pm b/tests/install_arm_image_deployment.pm index 1fdb5d10..b6cdce53 100644 --- a/tests/install_arm_image_deployment.pm +++ b/tests/install_arm_image_deployment.pm @@ -64,10 +64,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/install_source_graphical.pm b/tests/install_source_graphical.pm index 2f909ad9..a3ec27ba 100644 --- a/tests/install_source_graphical.pm +++ b/tests/install_source_graphical.pm @@ -61,10 +61,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/install_text.pm b/tests/install_text.pm index ea02bbf1..720d5924 100644 --- a/tests/install_text.pm +++ b/tests/install_text.pm @@ -102,10 +102,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/realmd_join_cockpit.pm b/tests/realmd_join_cockpit.pm index 820efc81..bc76f124 100644 --- a/tests/realmd_join_cockpit.pm +++ b/tests/realmd_join_cockpit.pm @@ -46,10 +46,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1, milestone => 1 }; } diff --git a/tests/realmd_join_sssd.pm b/tests/realmd_join_sssd.pm index fe7d5756..9846b406 100644 --- a/tests/realmd_join_sssd.pm +++ b/tests/realmd_join_sssd.pm @@ -24,10 +24,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/rescue_mode_encrypted.pm b/tests/rescue_mode_encrypted.pm index 5db1e0d2..66d7bf35 100644 --- a/tests/rescue_mode_encrypted.pm +++ b/tests/rescue_mode_encrypted.pm @@ -37,10 +37,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/role_deploy_database_server.pm b/tests/role_deploy_database_server.pm index 57c68344..357f959b 100644 --- a/tests/role_deploy_database_server.pm +++ b/tests/role_deploy_database_server.pm @@ -40,10 +40,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/role_deploy_domain_controller.pm b/tests/role_deploy_domain_controller.pm index 65a63a3e..c3585c07 100644 --- a/tests/role_deploy_domain_controller.pm +++ b/tests/role_deploy_domain_controller.pm @@ -101,10 +101,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/server_cockpit_basic.pm b/tests/server_cockpit_basic.pm index 4659051f..08dd7f89 100644 --- a/tests/server_cockpit_basic.pm +++ b/tests/server_cockpit_basic.pm @@ -27,10 +27,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/server_cockpit_default.pm b/tests/server_cockpit_default.pm index 064d5fad..40c1996f 100644 --- a/tests/server_cockpit_default.pm +++ b/tests/server_cockpit_default.pm @@ -20,10 +20,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/server_firewall_default.pm b/tests/server_firewall_default.pm index 2aa0c7b8..083e8dc7 100644 --- a/tests/server_firewall_default.pm +++ b/tests/server_firewall_default.pm @@ -17,10 +17,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/uefi_postinstall.pm b/tests/uefi_postinstall.pm index 77dda8ef..a99bb620 100644 --- a/tests/uefi_postinstall.pm +++ b/tests/uefi_postinstall.pm @@ -13,10 +13,6 @@ sub run { } sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/upgrade_postinstall.pm b/tests/upgrade_postinstall.pm index 6367a172..2c74a608 100644 --- a/tests/upgrade_postinstall.pm +++ b/tests/upgrade_postinstall.pm @@ -12,10 +12,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/upgrade_preinstall.pm b/tests/upgrade_preinstall.pm index ac3174a3..39864582 100644 --- a/tests/upgrade_preinstall.pm +++ b/tests/upgrade_preinstall.pm @@ -34,10 +34,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; } diff --git a/tests/upgrade_run.pm b/tests/upgrade_run.pm index 8e62fdcb..fad710a0 100644 --- a/tests/upgrade_run.pm +++ b/tests/upgrade_run.pm @@ -36,10 +36,6 @@ sub run { sub test_flags { - # without anything - rollback to 'lastgood' snapshot if failed - # 'fatal' - whole test suite is in danger if this fails - # 'milestone' - after this test succeeds, update 'lastgood' - # 'important' - if this fails, set the overall state to 'fail' return { fatal => 1 }; }