From f8f6d2f8bc64e595fb88c647af1ab0afd5ff3047 Mon Sep 17 00:00:00 2001
From: Garret Raziel <boloomka@gmail.com>
Date: Fri, 13 Mar 2015 12:58:03 +0100
Subject: [PATCH] fixing some issues - doublequotes and type_string

---
 needles/console_command_success2.json         |  18 ++++++++++++++++++
 needles/console_command_success2.png          | Bin 0 -> 514 bytes
 needles/password_required2.json               |  18 ++++++++++++++++++
 needles/password_required2.png                | Bin 0 -> 1149 bytes
 needles/root_logged_in2.json                  |  18 ++++++++++++++++++
 needles/root_logged_in2.png                   | Bin 0 -> 1184 bytes
 .../disk_guided_delete_partial_postinstall.pm |   4 ++--
 tests/disk_guided_free_space_postinstall.pm   |   4 ++--
 tests/disk_guided_multi_postinstall.pm        |   4 ++--
 9 files changed, 60 insertions(+), 6 deletions(-)
 create mode 100644 needles/console_command_success2.json
 create mode 100644 needles/console_command_success2.png
 create mode 100644 needles/password_required2.json
 create mode 100644 needles/password_required2.png
 create mode 100644 needles/root_logged_in2.json
 create mode 100644 needles/root_logged_in2.png

diff --git a/needles/console_command_success2.json b/needles/console_command_success2.json
new file mode 100644
index 00000000..2c3f7960
--- /dev/null
+++ b/needles/console_command_success2.json
@@ -0,0 +1,18 @@
+{
+  "area": [
+    {
+      "height": 13,
+      "width": 204,
+      "ypos": 16,
+      "type": "match",
+      "xpos": 0
+    }
+  ],
+  "tags": [
+    "console_command_success",
+    "ENV-DISTRI-fedora",
+    "ENV-INSTLANG-en_US",
+    "ENV-FLAVOR-server"
+  ],
+  "properties": []
+}
\ No newline at end of file
diff --git a/needles/console_command_success2.png b/needles/console_command_success2.png
new file mode 100644
index 0000000000000000000000000000000000000000..590895013554c453c284fc35951bea4807889ba4
GIT binary patch
literal 514
zcmeAS@N?(olHy`uVBq!ia0y~yU;#3j85o&?R6|L-ACO`T@Ck7R(yLaj5>Bpv!@$6}
z-P6S}q~g}w8-{(i97Gxt<qx=?(zIxq$`n{2p%s2*T6ej{s+BRp3pK8WMZaMbIK{KT
z)zZOc;t#vX7dNl=r$&D(k=_6PcK`K8-|%wt^DpmP-`W1Kbiw;q@4i{C6`qjg@Jsu_
z^DM^CGRLpPKKFj5WM}{U^uFCkwn`^yUY6>sop&n!-D&@G+oSE}b{q2Foip8N?E|x8
zi8_pdb$&l<`U-cl^Qb07KIQ2-y^c+%-TlBNg$44#ydGznia2jvYxpC(A=Xe~*$<8L
zb6&3QnfTen@2<q`ygn;N?HgP9EVl8T$d@mu`^|9O;q&bcKbtxJS+CyD`TqTC#;<92
z?oQ_n`=wO7lAGE2ivQ;?5o#~`d6|k%H+Ua0UEX0Sdpd+EPn+Gxl7D~Dx!P61&Bg|H
zOnwuO)no`3RIur&CS2Eg@QLR|JKJ>!&KvVinFcU_D*J1^;eXeSBX&u*>Zh!f$@tgB
g1Po`|fCICCGXL~ixZcKc&uowlp00i_>zopr05~DMe*gdg

literal 0
HcmV?d00001

diff --git a/needles/password_required2.json b/needles/password_required2.json
new file mode 100644
index 00000000..405f1bc3
--- /dev/null
+++ b/needles/password_required2.json
@@ -0,0 +1,18 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "ypos": 95,
+      "width": 72,
+      "height": 21,
+      "xpos": 0
+    }
+  ],
+  "tags": [
+    "password_required",
+    "ENV-DISTRI-fedora",
+    "ENV-INSTLANG-en_US",
+    "ENV-FLAVOR-server"
+  ],
+  "properties": []
+}
\ No newline at end of file
diff --git a/needles/password_required2.png b/needles/password_required2.png
new file mode 100644
index 0000000000000000000000000000000000000000..c6d20be827977bd751887552aae7ce4acc92fccd
GIT binary patch
literal 1149
zcmeAS@N?(olHy`uVBq!ia0y~yU;#3j85o&?R6|L-ACO`T@Ck7R(yLaj5>Bpv15{$<
z>EaktaqI2Pg?*1bMBE<Avx;U^IGUUfh!T+e;VBl$?Zw@r+q~K)dSQ1@GY^|-l)w&!
zPdWvYX3D+wGQNCw<Ca>xl}kfT_x0sWk1bLGTEw4!vF`5$k4bl?^i7(lGW`=XQ`e<m
z2UR>Tp6HvjNo4!~z3c7c*xtB3z5kx^B_m^f)$7kIZk}~7R}J3w;ipj7O?g2BH+knv
z0%Dp@X{W>ji!{7!o^a>{i-bq!e9Q|pOSRU`KJcldVV&Pa-&d=yu3Y)b=cZpN?}~mt
zkI=6l88@=E92Hq;FjF^>Z=uG=j?9X02hTU3yZ7tCx~D6ye2e?$Uiop)L)oJ3Uv;f=
zWj~nrpX7gB8Oy!n%+pWDwoIS>q<7Zu)*XD8E>FH!mp1KdpiGw2!WYuABE2GWcm2&>
zT$*6{`t5t)>kV^{1!RaXuDhH!Wzni_-y2rl(t5t;?ri___nzPMwT{%7a%hU}Or=#>
z`twcCZFk%k^XM(}F$u33x4uekn4HOD{I%|4YLLj%BIze{7T5l6SUTlt8OyX9qo=cc
zeOr<OMJjjl7M*)v!1C+X)GB+{*cnA{*D-nqnoPa@pqA-WcZ1ZjnAgtCi?kEDHg5>{
zl4f~m&4058RvQj0-m8<c`@OS5d;8+q*_nN2zlydLOs}6L&g**J@z(qP*?NL<d%b>q
z(q|6i1jc^_d+(BGo4+i1_UqW5*mw?|yv&bbm)?rA*5)laUv~Sv%4FM_QonbdJa6oI
z&9m~a)7t$(F3UU8;;&!7x_xUw`s@3<?n_PZO<NzSx1VD|4)2Z7w@Eqs*>2cAnEiL%
z&Tp%}?%LUZZFhW%oyq3RbCZIu>aAHn(WJllb^Xk=`R>K~XKgad%uUy&<>{TxIQuo^
zZ<K?}CPk&wNt={-BPYd9xwGuFVW!8@epju)s_qwSeY6DCxFa{_oXqL^C(3wrtxGw-
zMr06Q<c&?YRYmoK=PVIg8gb=gw!?O|9W!+=XEUj3U%bP-OJ^nb(+yj0tCn7_XEn(_
zkTUJ{YUWF(2d*{zs%^N-w9k_DrQC(RS_*2~g6-mrg3}HMEqTwpsHU7(Cda7z$Jd5y
zwHfp8e$TplTWM~zXLt0s$LjLYbK8w7JdSp6e|J8&aA)=EYgeb0-RH~Q{o{jL`Oz<n
zXP3S&iJn(iviUogM19F-<MS8(PhY;4`4c;T!Tua+fr*?yJ}|bgO+OgNU{+cyl4~x0
z+JEhd`-TV1xFzl$eqOej!Cz3&dH+q#7kgg&1ulEbv}~EB>-JO!ujMb)ZtE!|-86b&
rv*UZ6T+7?qpC1^3F*rcrLGv&6zqgr+1LV6TKu+*<^>bP0l+XkKFQD!T

literal 0
HcmV?d00001

diff --git a/needles/root_logged_in2.json b/needles/root_logged_in2.json
new file mode 100644
index 00000000..2e7c2ac8
--- /dev/null
+++ b/needles/root_logged_in2.json
@@ -0,0 +1,18 @@
+{
+  "area": [
+    {
+      "xpos": 0,
+      "ypos": 110,
+      "type": "match",
+      "height": 22,
+      "width": 156
+    }
+  ],
+  "tags": [
+    "root_logged_in",
+    "ENV-DISTRI-fedora",
+    "ENV-INSTLANG-en_US",
+    "ENV-FLAVOR-server"
+  ],
+  "properties": []
+}
\ No newline at end of file
diff --git a/needles/root_logged_in2.png b/needles/root_logged_in2.png
new file mode 100644
index 0000000000000000000000000000000000000000..c6173d4e379bc136b079faa8d072d1cbe1fa2435
GIT binary patch
literal 1184
zcmeAS@N?(olHy`uVBq!ia0y~yU;#3j85o&?R6|L-ACO`T@Ck7R(yLaj5>Bpv15^^~
z>EaktaqI1^wSA90MA{zmvr4ka37j>ZBId%jZ<6Cu)}^e+rX8HP{_G2d#|qh|D;{bU
zI6jG-uwO2-JTR%bPX5Z(tPiI=r``>n1~hix9@qBQ{99E{`d(GY)ZaNJj6-A9I{O(a
znprm$G(8Ld->v@pFZ;l{@L&HpR)lf<I4nKC`fT34-K&jMx##OIoKf4`V0Y_<R%v3O
z>j|HeN?u&9ouTUv7`YZsJt}s-dy?kO%$;mH*(^^AyKFT3&HTQu$nh$ZTF?0S7UR_w
zg?}4%u(cc&S!gg*H?VJ^#>QhNHr3Cc`=#gaDZXyBA}dP2-7(H4cZbuvZE=fMuVw!C
z%<N}sP0W1Om}f<mxmG89KSh0g++86X@_TQbz47U<VKS?n7iMJ3if$E&{8{jS@#_OY
zmtJ3A7Jb04R%1(d-2Tk#-iBE@a*T_QxoN7tjkB|jo}X_1Hf3Re=&~nMHIuH~IF<hO
zbL|AZ=_}&oF1Uvux)QUWxy<Nm;<9V{yL`G9t-8amxpc#IcAcd<-?cX^nXK7+GQ?d&
z%yr`Q-wI1bUVfE7IOFt>9~?z9F3reioVqAO>${_u=BLxlr}P<<XI!%QSAO8Nyr9<;
zp=Ac#+^*Tvl+N5b&$zu&w*TX=%pVV*KkB{1W_~@0|JrY(h#jZ*pX}bX==K6DnKsqj
z-FfSNP5JOSp3O!T7+()~vpm1@XRiOX(RP2l@d1^{X_MXvPB7!%p}I!;!M*6$brUPY
z&o8_AcT<*wOKPmkq@yXWuavIsWis3~^+bQern&<us;}G~?x`)<#d?E{(J->pqK?aA
zo#cfb<!9S}JN8xwFWLM%adl|n=lXri*D_b-^~PU%du;Q~GrRMy=UXzrXWSO)@LtZ&
zd^T%^sNlt|vujyy7TdYr%o98l96MhrUos$c`H9K7;sP6UBn#f%iMB7-Ie8%M-2829
zZSp}LM$>gy`COm;=<mO|@4wdGlako<W%?4UkbbKxtN15Px%4*o_;xmrW$z=SRK8k&
zU2MAd>sj3gz2{Hwtk2_(u+Ds$9;qt5)^u~2-Rq*t=hm@1tAN7hFGEU=CdZo0%n1@%
z`sEq}Na;+GxD?NAmy<T7wl=K%XPR(olg{nCX$NmJ*Ug_7&D`G*xNY;PoZbc_+wE*}
zjEddq2R{Bd*RZrYkJm(g?jq~#2$LQAc%}B8?B;7vyit*z(0ZM1+1hfwfAuRLZ*4SP
z`>*28i*F7E)}}LNPi3C8<jHy8>d?1rj2lxAys7JazOr#u>eB{2rN2LIOe6ktP02p+
z_e#Rwh8pf2bER^G4eb4Sul?tH(((8QQ2H;IN&5F@pwN|^?eVSc^W*J+@jD=(M)N<z
WBLn{TAEH9QZt!&Vb6Mw<&;$Us;rWmN

literal 0
HcmV?d00001

diff --git a/tests/disk_guided_delete_partial_postinstall.pm b/tests/disk_guided_delete_partial_postinstall.pm
index a4d6f8a4..5e0f9867 100644
--- a/tests/disk_guided_delete_partial_postinstall.pm
+++ b/tests/disk_guided_delete_partial_postinstall.pm
@@ -4,10 +4,10 @@ use testapi;
 
 sub run {
     assert_screen "root_logged_in";
-    type_string "reset; mount /dev/vda2 /mnt; echo $?";
+    type_string 'reset; mount /dev/vda2 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code
     send_key "ret";
     assert_screen "console_command_success";
-    type_string "reset; cat /mnt/testfile";
+    type_string 'reset; cat /mnt/testfile';
     send_key "ret";
     assert_screen "provided_second_partition_intact";
 }
diff --git a/tests/disk_guided_free_space_postinstall.pm b/tests/disk_guided_free_space_postinstall.pm
index c81b5f73..fc7cbf5f 100644
--- a/tests/disk_guided_free_space_postinstall.pm
+++ b/tests/disk_guided_free_space_postinstall.pm
@@ -4,10 +4,10 @@ use testapi;
 
 sub run {
     assert_screen "root_logged_in";
-    type_string "reset; mount /dev/vda1 /mnt; echo $?";
+    type_string 'reset; mount /dev/vda1 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code
     send_key "ret";
     assert_screen "console_command_success";
-    type_string "reset; cat /mnt/testfile";
+    type_string 'reset; cat /mnt/testfile';
     send_key "ret";
     assert_screen "provided_disk_intact";
 }
diff --git a/tests/disk_guided_multi_postinstall.pm b/tests/disk_guided_multi_postinstall.pm
index f14b7f24..e034428b 100644
--- a/tests/disk_guided_multi_postinstall.pm
+++ b/tests/disk_guided_multi_postinstall.pm
@@ -4,10 +4,10 @@ use testapi;
 
 sub run {
     assert_screen "root_logged_in";
-    type_string "reset; mount /dev/sdb1 /mnt; echo $?";
+    type_string 'reset; mount /dev/sdb1 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code
     send_key "ret";
     assert_screen "console_command_success";
-    type_string "reset; cat /mnt/testfile";
+    type_string 'reset; cat /mnt/testfile';
     send_key "ret";
     assert_screen "provided_disk_intact";
 }