Commit Graph

538 Commits

Author SHA1 Message Date
Adam Williamson
a0e191e097 Update cockpit login screen needle *again*
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-30 15:20:30 -07:00
Adam Williamson
efec7010cb Handle an 'akonadi did something' notification in KDE, etc.
This handles a case where KDE shows a notification saying
'PIM Maintenance (Finished)', like this:

https://openqa.fedoraproject.org/tests/477345#step/desktop_notifications/34

we need to click it away for the desktop_notification test to
pass. It also clarifies the difference between this notification
and the eternal 'akonadi_migration_agent is doing something'
popup in the needle names and comments. It also replaces the
'check_screen then assert_and_click if found' pattern in several
notifications-related places with the better 'check_screen then
click_lastmatch if found' pattern now available upstream.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-30 09:05:06 -07:00
Adam Williamson
81100e8a17 Add new Cockpit 'software updates' needle
Needed for the UI change in Cockpit 205.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-29 16:01:35 -07:00
Adam Williamson
4fb29f8bdb Add new Firefox GNOME app menu needle
Firefox icon changed, so this needs updating too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-29 15:55:52 -07:00
Adam Williamson
3cdfe96a5c Add another Firefox launcher needle variant
Seems we need two as the launcher background is a different
color on different Fedora releases...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-24 13:53:52 -07:00
Adam Williamson
51d37aeeef Update Firefox launcher needles for new icon
Firefox icon changed a bit in 70.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-24 13:23:24 -07:00
Adam Williamson
e313e58cdd Add new variant boot_enter_passphrase graphical needle
New plymouth has tweaked this screen's appearance.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-24 13:20:51 -07:00
Adam Williamson
e1030118f9 Add new cockpit login needle
The login screen background changed in 205.1 (it's actually the
same image, but it's now zoomed rather than just a chunk of it
being shown on a smaller screen).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-18 10:35:14 -07:00
Adam Williamson
b455e04188 Add new cockpit needles for 205
The cockpit UI went all GRIMDARK so we need a couple of new
needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 17:10:28 -07:00
Adam Williamson
5f38971a78 Add some new variant layout indicator needles
Once again, the text is at a slightly different height to the
needles we already have. I do not know why this sometimes
happens. It's a mystery.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 16:34:55 -07:00
Adam Williamson
b55782358d Don't check version or pre-release note on banners
This reduces the coverage of the identification test a bit but
also *substantially* simplifies it. We run into a ton of problems
when we try to check the version and prerelease text on screens
where it appears on banners:

* The banners differ between variants
* The pre-release text is translated
* The banners have gradients so for RTL languages, even if some
  text is untranslated (e.g. 'Fedora 31') it appears on a
  different background color than on LTR languages
* The prerelease text is dark red; if it appears on a dark blue
  area of the banner this can trigger an os-autoinst needle
  comparison bug: https://progress.opensuse.org/issues/56822

All of this together means we wind up continually fighting these
checks and we have a whole forest of needles just for them, and
it doesn't seem worthwhile. So let's drop all the places where
we were checking version and prerelease on banners, and only
check them in two places where they appear on a grey background,
which avoids most of the problems (we just need one version
needle per release, and one prerelease needle per language).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 11:08:24 -07:00
Adam Williamson
205c0c3d97 Add new variant ABRT needle for KDE app test
Font rendering changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-10 12:09:41 -07:00
Adam Williamson
6636122f62 New needle for *partly* translated 'install done' Japanese
Now one of the strings we check for is translated, but the other
is not...handle this, again with a workaround needle so the
missing translation triggers a soft fail.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-07 11:26:54 -07:00
Lukas Ruzicka
d82f4ecd7f Develop a new test for system updates via Cockpit.
* server-cockpit-updates tests that Cockpit can be used to update the system.
* server-cockpit-autoupdate tests that users can use dnf-automatic for system
updates.
* cockpit functions were removed from utils.pm and put into an extra library
for cockpit - cockpit.pm which all cockpit tests are now using.

Review cockpit.pm

Review autoupdate test.

Review the update test.

Fix typo in cockpit.pm

Add sleep.

Add missing command.

Delete an unused needle.
2019-10-01 16:04:01 +02:00
Adam Williamson
0782f4faf2 Add new akonadi migration agent needle for F31 background
Light blue throwing us off again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-26 10:24:37 -07:00
Adam Williamson
61f8adefdf Add some new update-related needles for KDE
The new background seems to be throwing us off here. I think
the menu is *very slightly* transparent so the needles usually
work for most Fedora backgrounds as they tend to have a similar
base color, but the 31 one is unusually light.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-19 10:23:21 -07:00
Adam Williamson
6e9a7a57c5 Add several more variant keyboard layout needles for new icon
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 12:26:26 -07:00
Adam Williamson
96cf14d555 Add new variant us_rtl layout needle
For RTL languages the keyboard icon and language indicator are
the other way around, so we have different needles even for the
US layout indicator which is otherwise the same in all langs.
This is a variant needle for the new keyboard icon that showed
up in Rawhide recently.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:32:58 -07:00
Adam Williamson
0f9fd1a76a Add alternative vdb selected needle for new blue checkboxes
This checkbox sometimes renders slightly differently, especially
on non-x86_64. We're not really sure why, but we just add more
needles to handle it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:23:47 -07:00
Adam Williamson
ea11c8344f Shrink KDE Firefox launcher icon to avoid background issues
Existing one doesn't match if the background is too different,
shrink it to just the center of the icon.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 15:12:03 -07:00
Adam Williamson
a1d9b14383 Some more prerelease needle updates 2019-09-11 15:01:44 -07:00
Adam Williamson
dc8ed1c9ba Yet more pre-release check fixes
We need another needle for French installs, and we need to use
ISO_URL for checking the ISO file name if ISO isn't set.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 14:31:54 -07:00
Adam Williamson
29a5e0bda7 Add variant 'permission denied' needle
For some reason, occasionally the 'm' character looks slightly
different. I have no idea why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 10:47:13 -07:00
Adam Williamson
be1baa90e5 Update main hub needles for changed keyboard icon
Someone is pretty OCD about this damn keyboard icon, it just
keeps getting changed...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-09 11:44:28 -07:00
Adam Williamson
a3c207a045 Add a few more 'blue button' needle variants
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 18:09:14 -07:00
Adam Williamson
23ad087ed3 Add blue button variants for workstation_selected needle too
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 17:28:41 -07:00
Adam Williamson
cf6f8db3e7 Add new variant 'minimal selected' needle for radio button change
Radio buttons look different with recent GTK, it seems.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 16:14:59 -07:00
Lukas Ruzicka
1d6e2aaa19 Add changed needle that failed for cyrillic test. 2019-09-05 17:10:50 +02:00
Adam Williamson
df88196357 Add F31 background needle
Now we have the backgrounds!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-04 12:44:55 -07:00
Adam Williamson
6d68b2c6fa Add yet another prerelease note needle
Seriously starting to think about separating out this ident
stuff into a separate test case :/

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-29 17:49:27 -07:00
Adam Williamson
53778fe494 Add language tags to the new language prerelease note needles
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:46:23 -07:00
Adam Williamson
b19e6bbda7 Add some needles for pre-release note translations
These showed up because I did a manual universal flavor run on
an ISO today, but we'll need them as soon as we do a candidate
compose too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:14:57 -07:00
Adam Williamson
2cb224a184 Make generic topbar needle narrower
We did this for the orange (Server) one already, but not the
blue generic one.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:07:33 -07:00
Adam Williamson
26308a6b47 Update rarely-used installer ext4/xfs partitioning needles
These only get used when we run universal tests on a non-Server
image, which is pretty rare (these days, as Server DVD is a
critical image and composes fail if it fails, it only really
happens when we do it manually for some reason, like I did
today). So they get stale and aren't updated for font rendering
changes and stuff. As I said I had to do a run like that today,
so I had to update all these needles...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:04:13 -07:00
Adam Williamson
4bb89046d3 Add one more updated GNOME app test needle
'Simple Scan' renamed itself.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 17:51:20 -07:00
Adam Williamson
28443abf04 Add new variants for GNOME app start/stop tests
Several apps changed icon.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:29:37 -07:00
Adam Williamson
77a6c0ed4d Add yet another variant 'vdb selected' needle
This screen often seems to show slight variances in color,
really not sure why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:28:44 -07:00
Lukas Ruzicka
022865ab9f KDE app start/stop: launch apps with commands not menus
This is doing slightly less to exercise the launcher menus and see
whether icons appear or disappear, but it's much faster and more
reliable. We do still use menu launch for one app, just to check
the mechanism works in general.
2019-08-23 12:41:49 -07:00
Adam Williamson
06e26e9721 Narrow topbar and add new version needle to cover languages
The top bar differs in non-English languages - for RTL the
version ident is on the left (so background is different), and
the width of the area with no text differs depending on the
length of the translations.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 14:36:53 -07:00
Adam Williamson
23552c777d Add a new KDE desktop update needle variant
Little black bits on the icon are in a different place now. Why,
I do not know.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 11:55:07 -07:00
Adam Williamson
ecfc9a5234 Add new variant abrt_runs needle for KDE app tests
Text rendering changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 10:44:25 -07:00
Adam Williamson
2f51f3ef20 Add PXE boot test
This adds a whole wodge of stuff to support_server to make it
act as a PXE server, then adds a new test which boots from PXE
and so should hit the PXE server. We use the NFS install repo as
that can be relied on to work for a support_server install.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-20 18:17:57 -07:00
Adam Williamson
0d66b4bbcd Add various new non-English language needle variants
Seems like there's been a change to freetype or something, text
rendering changed in all of these. Note there's one workaround
needle for an untranslated message in Japanese.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-19 19:03:57 -07:00
Adam Williamson
bc26017d84 Add needles for new anaconda icon
It's new!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-19 17:36:41 -07:00
Adam Williamson
ca0f772120 Add some new variant needles for anaconda text changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-16 12:35:52 -07:00
Adam Williamson
469a1395d0 Revise desktop background checks
Split this out of install_default, because it really is not a
part of that test and we do not want that test to fail because
the desktop background is wrong. Make it its own test module
and test suite instead. Don't do it on Rawhide, because we
really can't assert anything worthwhile about Rawhide at the
moment at least (this means the test runs but is a no-op and
will always pass on Rawhide, unfortunately). Move the needles
to a more appropriate location (this has nothing to do with
anaconda) and use 'background' not 'wallpaper' naming (that's
the name we use elsewhere in the project, e.g. package names).
Also, run the test on updates, and add an F29 needle for this
purpose.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-14 14:30:25 -07:00
Adam Williamson
d9c45454b2 Clean up wallpaper needles a bit
The backgrounds we have are F30 backgrounds, not F31: there are
no F31 backgrounds yet, F31 images are using F30 backgrounds
(which is a bug we should file). Also we really only need one
F30 background needle to match both KDE and GNOME if we pick a
sensible area of the screen to use, and let's use one that has
a bit more contrast for safer matching.

Note: F30 background is *meant* to be animated, but in fact
neither GNOME nor KDE seems to use the animated version by
default. Which makes our lives easier! Sucks for whoever put in
the work to animate it, though.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-14 13:17:35 -07:00
Lukas Ruzicka
d06b30e8dc Add new testcases and methods for release identification. 2019-07-30 15:45:02 -07:00
Adam Williamson
b31422d188 Add some new KDE app test needle variants
Underlines on button text seem to have moved.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-30 15:43:42 -07:00
Adam Williamson
c1393ec2de Add missing akonadi_migration_agent needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-30 15:43:04 -07:00
Adam Williamson
3fe3fc453c Add new Cockpit log detail variant needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-25 14:11:12 -07:00
Adam Williamson
be12f07900 GNOME apps: dismiss new LibreOffice 'tip of the day' if it shows
Also add a new needle for Impress startup.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-23 20:15:24 -07:00
Adam Williamson
17438386c1 Add new 'install done' needle
Text on the button was changed in Rawhide.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-23 13:16:04 -07:00
Adam Williamson
9078bca871 cockpit: update needles for 198, rejig Services page handling
Cockpit 198 comes with a UI overhaul, so almost all needles
need an update.

The 'auditd' service is no longer on the first page. To make
this less fragile (at the cost of not testing that clicking on
a service actually opens the detail page *for that service*,
tweak the needles to just look for *any* running service, click
on it, and check we got to a 'details' page. We also redo the
existing needles for this design.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-10 11:43:03 -07:00
Adam Williamson
0c650ce424 Add new anaconda warning bar needle (color changed)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-09 22:32:26 -07:00
Adam Williamson
0160b4dd4c Add yet another keyboard layout needle variant
Different distance between the text and the arrow. I dunno why.
GNOME is a mystery sometimes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-09 22:31:30 -07:00
Adam Williamson
de4a58438b Use existing needle for dismissing KDE update notification
@lruzicka added this to the KDE app tests in 71c4e273, but there
was no need for a new needle as I'd already done the same thing
in the desktop updates tests; let's just use the same needle.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-03 08:39:01 -07:00
Lukas Ruzicka
71c4e273ef Click off updates notification if it appears. 2019-07-03 10:52:47 +02:00
Adam Williamson
dcc8fb9370 Update Firefox new tab needle
This should make the desktop_browser test a bit more reliable.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-06-28 14:48:42 -07:00
Adam Williamson
1b43fc2055 Move layout_us_ltr_overview from arabic to GNOME too
This is really a 'generic' needle since it'd be needed for any
RTL language test, it's not specific to arabic.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-06-25 15:09:00 -07:00
Adam Williamson
fa2fd70b1f Update a bunch of needles that have changed in Rawhide
Mainly because the GDM background became a lighter shade of
grey, for some reason, but also some dialog and icon changes.

Also put all forms of layout_us_ltr-gdm in the same directory.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-06-25 15:07:46 -07:00
Adam Williamson
bc2add845e Add the settings needle that provides the 'workspace' tag back
Removing this broke the GNOME apps test entirely because there
was no GNOME 'workspace' needle any more.

I don't like this needle much, we should probably use
check_desktop_clean or something instead. But for now let's just
put it back.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-06-25 14:16:11 -07:00
Adam Williamson
6656f1659d apps_activities is a dupe with overview_app_grid, kill it
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-06-25 14:01:39 -07:00
Lukas Ruzicka
9e3b16bfcf Change Settings test due to change functionality. 2019-06-21 14:54:18 +02:00
Lukas Ruzicka
868fca87b3 Add new needle for Simple Scan Menu item. 2019-06-21 11:33:12 +02:00
Adam Williamson
47bf561712 Update some KDE app launch icons
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-06-11 17:14:46 -07:00
Adam Williamson
7953fb91d1 Try to handle spurious 'auth required' on KDE update test too
Sigh, now *this* is showing up in KDE too. Fun.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-30 17:54:27 -07:00
Adam Williamson
2e56facb68 Try to handle changes to KDE update notifications in Rawhide
The way KDE does update notifications has changed - it's now a
permanent pop-up notification. This is a bit awkward for our
logic; it's hard to define a needle that proves this pop-up is
the only notification. Instead, let's dismiss it, then open the
notification tray and assert that there aren't any others. But
we also retain the old behaviour (more or less) for testing old
releases.

The popup notification also blocks the 'refresh' needle in the
systray and so breaks the desktop update test, so we deal with
that too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-30 17:34:09 -07:00
Adam Williamson
8b353a216a Update some KDE app test needles for icon and font changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-30 14:40:32 -07:00
Adam Williamson
bad3263160 Update ABRT app launcher needle
Icon was changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-27 17:51:27 -07:00
Adam Williamson
ce7f5f9853 Add another new SDDM login needle
I cannot see how this varies from the other one, but os-autoinst
thinks they're different...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-27 17:50:40 -07:00
Adam Williamson
8109c49d5a Update KDE 'no notifications' needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-23 17:40:10 -07:00
Adam Williamson
a9da421d35 Update KDE login screen needle
We now skip straight to the password input stage, it seems...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-23 15:13:52 -07:00
Adam Williamson
b37ee51bfb Update a Firefox needle again
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-22 14:31:17 -07:00
Lukas Ruzicka
cc650ed195 Add needle to fix Mediawriter test. 2019-05-03 11:09:56 +02:00
Lukas Ruzicka
ddddc9d8eb Recreate needles to make Games working. 2019-05-02 17:35:31 +02:00
Adam Williamson
ed17620110 Add the new variant needle for realz this time
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-29 18:31:05 -07:00
Adam Williamson
c5e775a8d5 Whoops, wrong needle. REVERT! REVERT!
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-29 18:26:00 -07:00
Adam Williamson
aecd11d149 Add another Japanese needle variant
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-29 18:21:41 -07:00
Adam Williamson
9389acf4b0 Update a Japanese needle for slight font rendering change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-29 11:14:03 -07:00
Lukas Ruzicka
8a321dec2c Fix broken needles for foreign installations. 2019-04-25 10:12:36 +02:00
Adam Williamson
d30714dbca Add a variant apps_stop needle for Firefox 66 without header
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-17 12:30:11 -07:00
Adam Williamson
382f815110 Update KDE menu_games needle for icon change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-17 10:59:13 -07:00
Adam Williamson
e744cea358 Update GNOME apps needles for cheese and scan
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-16 18:46:31 -07:00
Guy Menanteau
9475fec56f New needle anaconda_blivet_vdb_selected-20190416
as previous needle only matched 96%
https://openqa.stg.fedoraproject.org/tests/520670#step/disk_custom_blivet_software_raid/36

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2019-04-16 17:01:13 +01:00
Adam Williamson
c043fb6189 Add a Bash 5.0 variant of the noprofile shell needle...
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-12 16:05:12 -07:00
Adam Williamson
33f63c3d95 rescue_shell_prompt is really just a root console needle...
...so make it look like all the other ones we have already.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-12 15:54:26 -07:00
Guy Menanteau
29070a54f1 New install_repository_hd_variation
use a new PREINSTALL to execute a rescue script before install.

This is covering the  Hard_drive_variation test as per:
https://fedoraproject.org/wiki/QA:Testcase_install_repository_Hard_drive_variation

Signed-off-by: Guy Menanteau <menantea@linux.vnet.ibm.com>
2019-04-12 15:49:54 -07:00
Lukas Ruzicka
99f93945b3 Change KDE desktop background at start of KDE app test
Since the KDE menus have transparency set, any time the wallpaper
changes the menus will look different, and the app tests may
fail. This sets the desktop wallpaper to black at the start of
the test suite to avoid this problem.
2019-04-09 08:57:43 -07:00
Lukas Ruzicka
9a2d9ea190 Create needles needed for firefox test to really work. 2019-03-28 14:18:51 +01:00
Lukas Ruzicka
f9201fb7d8 Fix kmail and kontakt tests
Fix to pass kontakt tests properly.
2019-03-27 18:00:05 +01:00
Adam Williamson
e396341f31 Handle 'authentication required' appearing on Boxes startup
In the last few weeks Boxes is showing an auth dialog on start.
I've filed a bug on this; let's have the test handle it as a
soft failure, since this isn't a fatal problem. Do this by
making an existing needle for this dialog a bit more generic
in name and using it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-03-26 12:30:47 -07:00
Adam Williamson
5a1a71c67f Use the existing 'oh hai this is firefox' needle for app tests
The KDE and GNOME 'apps' tests for Firefox both invented their
own 'oh look Firefox is running' needle, even though we already
had one. The GNOME one was broken by the removal of the app
title bar in Firefox 66.

Instead of having three needles for the same thing, let's just
throw the 'apps' ones out and use the pre-existing one from
needles/firefox for all cases.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-03-26 12:23:45 -07:00
Adam Williamson
846c2969a4 Update KDE 'addon install' Firefox needle
This looks different in KDE to GNOME for some reason, so we need
yet another new needle.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-03-25 13:16:23 -07:00
Adam Williamson
7ebe604135 Update Cockpit needle for upstream change
Looks like this label went from regular to bold font in a new
cockpit release.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-03-25 08:30:47 -07:00
Lukáš Růžička
6fc8c99515 Add needle to fix iscsi test. 2019-03-21 13:18:41 +01:00
Adam Williamson
26cdcb8d3c Add several new needles for changed GNOME app icons
Utilities came up different *again* in a Rawhide test today, so
this adds a needle which matches on the text. Usually we prefer
image matches to text, but this image seems to keep changing...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-03-20 12:21:55 -07:00
Adam Williamson
5195a20ab5 Add a variant needle for juk
This button can have the O underlined, apparently...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-03-20 12:10:13 -07:00
Lukas Ruzicka
9ae60de422 Reneedle menus and fix some issues in tests.
This update fixes the strange behaviour in KDE which causes wrong clicking.
With new logic, this is not an issue anymore.
2019-03-20 10:26:33 +01:00
Lukas Ruzicka
d4403962da Delete unused needles. 2019-03-19 12:15:03 -07:00