Commit Graph

157 Commits

Author SHA1 Message Date
Adam Williamson
2a2473b4bb Crop layout needles to not include down carets
...since GNOME doesn't have them any more in Rawhide.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-03 17:47:30 -08:00
Adam Williamson
179ab45bca Update various needles for GNOME down caret changing a bit
This affected apps_run_terminal and a ton of layout needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-01-25 16:27:39 -08:00
Adam Williamson
fba4a82587 Make g-i-s Start Setup button needle its own thing
There's a race issue with just treating it as a next button: it's
not in the same place as a next button. Sometimes in the g-i-s
code we actually get ahead of ourselves and click early, which
isn't really a problem when the buttons are all in the same
place, but if we click "Start Setup" in the middle of transition
to the Privacy screen - as in
https://openqa.fedoraproject.org/tests/745034#step/_graphical_wait_login/4
 - the click effectively gets lost. So let's make it its own tag
and have the initial assert look for it too. That way we won't
match on it again in the main loop over "@nexts".

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-21 09:16:40 -08:00
Adam Williamson
61bd4cb310 Update GNOME printing_check_sentence needle
Font rendering changed a bit again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-16 09:42:18 -08:00
Adam Williamson
d065974cc6 apps_run_terminal: match window area too
Just matching the Overview entry isn't really enough, the app
hasn't really run yet. This makes the test more robust and also
helps out on aarch64 desktop tests where the app window takes a
long time to appear.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-04 11:55:36 -08:00
Adam Williamson
387f8dd679 Update Arabic needles for some kind of font change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-02 14:47:20 -08:00
Adam Williamson
fde492aa5d Update a few desktop needles
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-11-10 13:00:46 -08:00
Adam Williamson
d2e6c11c7b Update GNOME printing sentence needle
Seems sometimes we now get the document at fit width, not fit
page.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-31 11:26:32 -07:00
Adam Williamson
1c33d07d38 Drop workaround_ble26, bug was fixed months ago
https://pagure.io/background-logo-extension/issue/26 was fixed
months back, we don't need this any more.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-15 15:36:04 -07:00
Adam Williamson
fba3a3a290 Update Cheese and Videos app needles, icons changed
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-18 13:40:23 -07:00
Adam Williamson
9ae60e4a1e Update GDM/GNOME keyboard layout needles
The down caret changed size, again...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-01 12:12:25 -07:00
Adam Williamson
461d9cc7b9 New getting started needle is language-agnostic
We're matching on the icon, so it should work for all languages.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-01 10:40:41 -07:00
Adam Williamson
9a90a06328 Add new 'getting_started' needle for GNOME Tour
Replaces the old Yelp-based thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-31 12:43:56 -07:00
Adam Williamson
3c1c9f3436 Rename log_out_entry needles to be unique
Even though we have subdirs, we actually usually make needle
names unique across subdirs due to limitations of openQA's UI
upstream.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-25 16:42:46 -07:00
Adam Williamson
b117d16133 Update GNOME Calculator app needle
Icon no longer has labels on the calculator buttons.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-18 17:04:20 -07:00
Adam Williamson
2713ce60dd Add a new not-really-a-Next-button needle for gnome-initial-setup
In g-i-s 3.37.91, the first screen has a 'Start Setup' button
rather than a 'Next' button. Easiest thing for us to do here is
just to add a new needle which has the 'next_button' tag even
though it's clearly not a 'Next' button, because then the code
still works :) So do that, but give the file a suggestive name
and explain the situation in a code comment.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-18 12:23:09 -07:00
Adam Williamson
7682872d95 desktop_login: update reboot flow for GNOME changes in F33+
GNOME now also splits 'Restart...' and 'Power Off...' as KDE
does, so we need to tweak the conditional and add some needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-17 16:25:32 -07:00
Adam Williamson
160602d8af Update a bunch of GNOME app test needles for latest Shell
Latest Shell changes how the icons look a bit, again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-09 16:24:29 -07:00
Adam Williamson
a20730bd0d Add overview search box Japanese needle for input test
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-09 16:22:40 -07:00
Adam Williamson
4ed2f90f32 Tweak overview_search_box needle so click hits right spot
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-08 17:15:58 -07:00
Adam Williamson
2f93645a55 Workaround GNOME overview search box not active bug
See https://pagure.io/background-logo-extension/issue/26 - in
current Rawhide, the search box in the overview is not active
when the overview is opened, so you can't just open the
overview and type, you have to click it first.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-08 17:07:48 -07:00
Adam Williamson
0cea4b1cd5 Update Screenshot app needle
Button turned blue!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-17 17:34:43 -07:00
Adam Williamson
87af7d4ecd Update GNOME app needles for GNOME 3.37.2
Not sure if the needles changed or just the way they're rendered
in the overview, but either way, we need to update a bunch.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-05 16:07:25 -07:00
Adam Williamson
2e21161785 Update various needles for a GNOME symbol change
The little triangle that's used on drop-down menus and stuff got
bigger. That breaks all these needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-05 14:27:34 -07:00
Adam Williamson
7fe5525c29 Drop unnecessary system menu match from apps_menu_button
This goes back to when we called this needle desktop_clean, but
there's really no point in having it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-05 11:22:16 -07:00
Adam Williamson
3c44f644a0 Reduce system_menu_button match area not to include background
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-11 16:07:18 -07:00
Lukáš Růžička
61f845dbbf Make solidify_wallpaper more universal to handle different desktops. 2020-05-05 00:14:35 +00:00
Lukáš Růžička
fd3e4e3280 Change the order of steps and add another check screen.
Since GDM shows the "system-menu-button", it could not correctly
switch users on a locked screen. I added a check to see
if we are on a locked screen and behave accordingly.
2020-04-22 21:52:19 +02:00
Adam Williamson
23904d71b2 Update French apps menu button, remove extra match areas
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-18 14:59:14 -07:00
Lukáš Růžička
f3d6a9574c Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.

While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.

So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-04-17 17:27:04 -07:00
Adam Williamson
417b876ead Add F31 variant Terminal app run needle
Needed for F31 respin tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:12:57 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Adam Williamson
8b5be61971 Update a few GNOME app needles that seem to have changed
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:27:01 -07:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Lukáš Růžička
d19cf9553e Reneedle the Gnome Application StartStop tests. 2020-03-18 18:06:34 +01:00
Adam Williamson
2c236ef16a Update GNOME Software 'Download' needle for changed kerning
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-26 11:34:21 -08:00
Adam Williamson
18c818da7d Update overview app grid needle (more GNOME icon changes)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 09:57:04 -08:00
Adam Williamson
5300c35106 Update desktop update notification only needle
More GNOME icon changes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 09:53:30 -08:00
Adam Williamson
7fd23dacea Update GDM input needles for non-English languages
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 10:37:51 -08:00
Adam Williamson
9f331dbbe3 Update authentication required GNOME needle
They took away the icon, so now we can only match on text :(

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 10:35:47 -08:00
Adam Williamson
f7a9625b55 Update GDM input needle
GNOME reworked this widget a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 09:47:13 -08:00
Adam Williamson
f8292bfeeb More Cantarell: Russian and French
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-18 23:56:11 +00:00
Adam Williamson
a653ded877 Next batch of Cantarell needles: Arabic install
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 15:32:30 +00:00
Adam Williamson
28642f4002 Move a stray app needle to the right place
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 15:19:17 +00:00
Adam Williamson
8612858b1f Second batch of Cantarell needles: GNOME apps tests
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 15:18:50 +00:00
Adam Williamson
21febe3592 First batch of updates for new version of cantarell
Still need to do the non-English languages. I'll do those
tomorrow.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 01:18:52 +00:00
Adam Williamson
e3430e82ef Update Rhythmbox app needle
The icon changed, so the needle needs changing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-06 12:32:44 -08:00
Adam Williamson
766d5f163e Update GDM input needles (an icon appeared in the text entry)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-06 10:57:53 -08:00
Adam Williamson
30a2b68974 Add some variant printing needles for F30
Printer icon is different, final output looks a bit different.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-12-06 17:28:27 -08:00
Lukáš Růžička
77ae127cce Create an automated test to test printing on Desktop
Add functions to test on KDE, too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-12-05 09:22:50 -08:00