Commit Graph

197 Commits

Author SHA1 Message Date
Adam Williamson
2a7787c1da Update lots of needles for os-autoinst behaviour change
Recent git os-autoinst no longer downsamples screenshots as far
as it did before comparison. This makes a lot of needles where
colors have changed slightly no longer match, so they all needed
updating.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-19 13:03:11 -07:00
Lukáš Růžička
6d1d549941 Introduce a resize check and a postinstall test for custom and blivet
tests.

This PR fixes #228.
2021-06-30 11:01:50 +02:00
Lukáš Růžička
395ed61a1a Automate the Anaconda_Save_Traceback_to_Bugzilla_Text test case.
This PR adds a new test that automates the above mentioned test case.
It starts the installation in text mode using the `install_text` test
case, which it interrupts using the Anaconda crash trigger.
When the crash happens, it goes through the process of reporting
the bug to Bugzilla, checks that Bugzilla sends a positive
confirmation of the action, but also performs some REST API
calls to do a proper check and then it closes the bug to clean up.
2021-06-17 16:28:29 -07:00
Adam Williamson
fcf96f73b7 Tweak Blivet LVM device type needles
There's some cheating/sloppiness going on here, with the same tag
and sometimes same needle being used to match "LVM2 Volume Group"
and "LVM2 Logical Volume". Today this caused us to pick the thin
pool entry instead in a test, so let's just clean this up and do
it right, with separate needles for matching each thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-07 18:16:46 -07:00
Adam Williamson
3364732110 anaconda_help: tweak nonlive needle handling, add waits, tabs
Some fixups for anaconda_help. Two runs of it failed today around
handoff from the root password screen to the install progress
screen; add a couple of wait_still_screens there to make it
safer. Drop the added nonlive needles, because they're too
permissive, causing problems for other tests (they're matching
before they should); instead we solve the problem of spokes being
highlighted by just pressing shift-tab a few times. And fix some
tabs to be spaces.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-31 16:17:06 -07:00
Lukáš Růžička
c6d443a20f Automate the QA:Testcase_Anaconda_help.
This PR automates the mentioned testcase to test that Help can be
displayed in Anaconda during the installation. It navigates through
the available Help screens and if it can see it, it finishes.

This test runs after `install_default_upload` to override the
installation defaults defined for all primary tests.

Delete a duplicated needle.

Reformat list extensions to make it nicer.

Get rid of wrong export and an empty line.

Delete empty line.

Use _boot_to_anaconda for booting and move subroutine accordingly.

Add variable to templates.fif.json

Delete trailing whitespace.

Fix calling the pretest.

Move help checking to another place.
2021-05-27 21:39:26 +00:00
Adam Williamson
875a817977 Drop Boxes/Connections needles for now
We're not using them, so they fail the unused needles check. We
can just revert this commit when we want them back.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-14 12:53:49 -07:00
Adam Williamson
8dc1bc7a8a Update leftbar generic needle, add rhbz#1959160 workaround
The background color of the generic left bar needle has changed
to match the new logo base color. The top bar's background color
has similarly changed, but this also caused us to notice a bug
in fedora-logos - that topbar image file seems to be basically
empty (just a transparent rectangle) so we see no 'image' in the
top bar, just solid electric blue. This needle matches that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-10 13:57:38 -07:00
Adam Williamson
35660bb4ed Use Vinagre instead of Boxes as VNC client, prepare Connections
Boxes dropped VNC functionality. It's supposed to be replaced by
Connections, but we can't use that until it has fullscreen:
https://gitlab.gnome.org/GNOME/connections/-/issues/5
so use Vinagre for now. We do also prepare some needles for
Connections in anticipation of being able to use it later (since
I already did the work and don't want to waste it...)

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-06 16:28:49 -07:00
Adam Williamson
28b1126c95 Update Japanese install_done-reboot needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 15:03:12 -07:00
Adam Williamson
ed9136225d Shorten the leftbar newlogo needle a bit for KDE live
KDE lives cut this off a bit because the taskbar is under it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-29 12:50:03 -07:00
Adam Williamson
10af8015ea Update anaconda newlogo identification icon for tweaked logo
Design team tweaked the new logo a bit in anaconda. We probably
won't need the old needle any more, but I'll take that out later.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-26 21:06:30 -07:00
Adam Williamson
cde370bf1b Update several needles for new Fedora logo
The package with the new logo is not submitted as an update yet,
but we ran the tests on the Koji build and these are the new
needles. We'll need more when we run the full set of compose
tests on the change.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 12:58:30 -07:00
Adam Williamson
784962c96e Fix btrfs_preserve_home for UEFI
When running this test on UEFI, we need to preserve /boot/efi.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-19 14:48:47 -08:00
Lukáš Růžička
866a8efa72 Add a new testcase to test creation of LVM with ext4 using Blivet.
This PR adds a test that uses the Blivet interface to create an LVM
layout with ext4 filesystem as well as a postinstall test that checks
that the LVM layout has been created correctly.
2021-02-19 13:42:20 -08:00
Adam Williamson
79c27e347f Add F35 IoT identification needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-17 18:02:02 -08:00
Adam Williamson
19c2a5dae7 Add version_34 identification needles, now we branched
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-10 11:01:37 -08:00
Lukáš Růžička
ecca7d3c01 Create testcase to recreate Btrfs layout using Blivet and preserve home.
This PR uses the Anaconda Blivet partitioning to recreate a partition
layout while preserving the content of the /home subvolume.

It also adds the postinstall test to check that the home has been
preserved.
2021-01-28 09:51:32 +01:00
Lukáš Růžička
ba90c70c8a Add several tests to test QA:Testcase_partitioning_custom_btrfs_preserve_home.
This PR adds the `install_btrfs_upload` to install the btrfs based
image, the `btrfs_preserve_home_extras` to prepare and test the data
on the home partition, as well as the `custom_btrfs_preserve_home` that
uses the preinstalled btrfs image and uses its current partitioning to
preserve the home partition and the data on it.
2021-01-20 16:50:39 +00:00
Michel Normand
e9c15a502a ppc64le changes in disk_custom_blivet_resize_lvm.pm
Required because ppc64le has a PReP partition
before boot partition.
PReP partition must not be changed by this script.

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2021-01-12 11:14:17 +01:00
Adam Williamson
9adfeb449d Make leftbar_generic match area a bit shorter
KDE menu bar got a bit taller lately.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-17 09:00:24 -08:00
Adam Williamson
387f8dd679 Update Arabic needles for some kind of font change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-02 14:47:20 -08:00
Lukáš Růžička
5718c7f1d4 Add an installation test using LVM partitioning as asset for resize tests.
When Fedora went to BTRFS as a default, we lost the LVM based image to
run LVM resize tests with.

This PR introduces the `install_lvm.pm` installation test that creates
an LVM based qcow2 image to be used by follow-up tests.
2020-11-26 09:55:19 +01:00
Adam Williamson
a2bbd5ecfb Add some needles for universal tests with btrfs default
The 'universal' tests have quite a few failures if you run them
on an image where btrfs is the default (currently they usually
run on the Server DVD, where xfs-on-LVM is still the default).
This fixes some of them, the others would need code fixes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-11 16:20:12 -07:00
Adam Williamson
86c881db80 Add IoT version "34" needles
IoT is still versioning its 'rawhide' composes, so here.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-24 12:49:56 -07:00
Adam Williamson
837f8e88cf Add 33 version ident needle (non-IoT)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-17 17:37:26 -07:00
Adam Williamson
0f072d973a Update anaconda network spoke IPv4 needle for GTK+ change
See https://gitlab.gnome.org/GNOME/gtk/-/issues/2652 . I thought
this was a bug at first but apparently not...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-22 12:45:08 -07:00
Dan Čermák
9768ac5178
Fix the install_lang_english_filtered needle for non en_US lang 2020-06-25 23:45:02 +02:00
Adam Williamson
2e21161785 Update various needles for a GNOME symbol change
The little triangle that's used on drop-down menus and stuff got
bigger. That breaks all these needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-05 14:27:34 -07:00
Lukáš Růžička
b5169e602b Use existing needles for fs selection. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
d8171958ed Rename needle to correct typo. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
c9bc7f0570 Rename needles to match the tag. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
2a3e67991b Whitelist not recognized needles in check-needles.py 2020-05-27 15:54:09 -07:00
Lukáš Růžička
5f1db40ebe Add to templates. 2020-05-27 15:54:09 -07:00
Lukáš Růžička
c42f62da14 Create a test for resizing using custom partitioning 2020-05-27 15:54:09 -07:00
Lukáš Růžička
9efb0e10e6 Create a test to resize LVM partitions using Blivet. 2020-05-27 15:54:09 -07:00
Adam Williamson
ac602d43b7 Update Japanese 'install done' needle
The button is translated now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-09 10:33:00 -07:00
Adam Williamson
0594fc8d57 Update French user creation screen needle for translation change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-01 16:48:21 -07:00
Adam Williamson
9bad775aae Update a blivet needle for a change to check mark design
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-29 12:19:39 -07:00
Adam Williamson
83a394bba2 Update a Boxes needle for a font rendering change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-27 15:06:14 -07:00
Adam Williamson
19677de20a Add variant anaconda keyboard layout needles
There's this weird thing where the vertical alignment of the
language name in the keyboard layout indicator is sometimes
different. I never can figure out why. It may be to do with
presence or absence of the pre-release indicator.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:07:06 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Adam Williamson
ea397783d5 Update French 'accept fate' needle
Verb changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:17:42 -07:00
Adam Williamson
6b5e933ff4 Update error_report needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:16:02 -07:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Adam Williamson
608209499d Add Fedora 33 IoT ident needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-16 14:17:31 -07:00
Adam Williamson
ff1d75050e Update French pre-release note needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-12 09:19:04 -07:00
Adam Williamson
948e5f23ae Add missing tags to Russian prerelease note needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-12 08:50:05 -07:00
Lukáš Růžička
0557af9a2d Add needle to cover a changed prerelease note for Russian. 2020-03-12 16:17:28 +01:00
Adam Williamson
00f1241318 Update French 'install done' needle
Translation was updated.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-10 16:04:45 -07:00