Commit Graph

42 Commits

Author SHA1 Message Date
1c7a6c6ef2
Needles moved to appropriate directories 2023-03-06 13:07:32 +00:00
lumarel
d8a05cd066 Add rocky distri, where it was missing in the needles 2023-02-07 20:33:40 -08:00
aa3c9f6eef add needles for install_iscsi 2023-02-07 20:33:40 -08:00
lumarel
2b1aad37e2 Revert "Add needles for the space reclaiming testsuites"
This reverts commit a1297bc2a87eeeaf51fbfbed2268f17c9ce53489.
2023-02-07 20:33:40 -08:00
lumarel
aeb9ee06f8 Add needles for the space reclaiming testsuites 2023-02-07 20:33:40 -08:00
Al Bowles
2297b70a6a
New Russian-language needles
- Update leftbar_generic for all non-English languages
- Update remaining Russian-language needles
2022-10-14 18:58:58 -05:00
Lukas Magauer
396caaac0d
[9.0 Release Issues] Test Suite: Missing Anaconda needles - the 5th ()
* Make top bar needle ready for multiple languages

* Add the rest of the custom partitioning needles

* Other languages needles

* Prepare login needles for other languages

* Support Azerty user as well

* Remove faulting needles which got dragged in

Co-authored-by: lumarel <lumarel@users.noreply.github.com>
2022-07-02 12:16:45 -05:00
akatch
2c427618ac
8.6 release fixes ()
* Handle the "reclaim space" dialog

Adds handling for the "Reclaim Space" dialog, which can appear after the
user clicks "Done" in the partitioning spoke.

* Fix indentations

* Set default HDD size to 15GB

* Remove redundant HDDSIZEGB definitions

* Add more GiBs

* Workaround for 

* Needle with new security policy spoke icon

* Add new needles to fix cockpit tests in 8.6

* Add contribution SOP to README

* Words

* Script fixes ()

* Increment version

* Fix this header

* Fix URL for updates.img ()

* ---
title: [8.6 Release Issues] Test Suite: install_delete_partial and install_custom_gui_lvm_ext4 on rocky 8.6
labels: 'test suite'
assignees: '@akatch'

---

# Description

Running openQA test suite `install_delete_partial` as above throws `Test died: no candidate needle with tag(s) 'anaconda_install_destination_reclaim_space_btn' matched` at module `disk_guided_delete_partial`.

At this stage, the "Reclaim Space" button in the lower right corner of the dialog is disabled.

Additionally, the dialog shows that 5GB will be reclaimed by the steps taken to that point in the test, but installation requires around 9GB. Do we need to reclaim enough space for installation in order to enable that button?
_Yes, the button is enabled when enough space to install is reclaimed._

Just adding HDDSIZEGB=20 to `templates.fif.json` did not increase volume size shown in the dialog. Do we need to recreate the img file?
_Yes, recreating the img file using createhdds.py against a larger size in hdds.json resolved this error._

The Reclaim Space dialog claimed 9.06GB was required to perform installation, and after doubling the size of disk_full_XXX.img we got past the Reclaim Space dialog. However, `_do_install_and_reboot` failed to install citing not enough disk space.

Fixes  when merged.

# How Has This Been Tested?

```
# NOTE: was not able to reproduce for install_custom_gui_lvm_ext4
openqa-cli api -X POST isos ISO=Rocky-8.6-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=8.6 BUILD=8.6_dvd-iso_$(date +%Y%m%d.%H%M%S).0 TEST=install_custom_gui_lvm_ext4 PACKAGE_SET=graphical-server

openqa-cli api -X POST isos ISO=Rocky-8.6-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.6 BUILD=8.6_universal_$(date +%Y%m%d.%H%M%S).0 TEST=install_delete_partial PACKAGE_SET=graphical-server
```

All tests must pass `_do_install_and_reboot`.
NOTE: These tests will fail at `_console_wait_login` with the issue in .

# Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] Any dependent changes have been merged and published in downstream modules

* Add new needle to mitigate the changed default
for install source on the network from http to https

Co-authored-by: lumarel <lumarel@users.noreply.github.com>
2022-06-09 18:15:17 -05:00
316e7d2c7a
add needles to complete tests requiring HDD_1 inputs () 2022-02-01 07:58:57 -08:00
Lukas Magauer
4f26a2cd84
Fix install multiple languages ()
* All generic language updates

* Add japanese needles

* Add arabic needles

* Add french needles

* Add russian needles

* Add right-to-left needles

* More arabic needles

* More french needles

* More japanese needles

* More russian needles

* More generic/english needles

* Add license accept to setup test

Co-authored-by: lumarel <lumarel@users.noreply.github.com>
2021-08-26 14:58:46 -05:00
Lukas Magauer
9138a28738
Fix Install Destination needle for already selected case ()
* Fix Install Destination needle for already select case

* Fix Encrypt Data needle

* Fix Encryption Passphrase needle

* Correct position of the Save Passphrase needle

Co-authored-by: lumarel <lumarel@users.noreply.github.com>
2021-08-24 09:23:42 -05:00
Lukas Magauer
ee903aa6be
Fix select disk needles ()
* Fix Select Disk Needle

* Fix needle for disk 2

Co-authored-by: lumarel <lumarel@users.noreply.github.com>
2021-08-24 08:03:25 -05:00
Adam Williamson
2a7787c1da Update lots of needles for os-autoinst behaviour change
Recent git os-autoinst no longer downsamples screenshots as far
as it did before comparison. This makes a lot of needles where
colors have changed slightly no longer match, so they all needed
updating.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-19 13:03:11 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Adam Williamson
884f71bb81 Revert "Workaround (single disk not selected as install target)"
This reverts commit adf3f91818.
The bug has been fixed in anaconda, so we can drop this, which
is good as it has timing issues producing false positives on
Rawhide...
2020-02-26 14:30:08 -08:00
Adam Williamson
adf3f91818 Workaround (single disk not selected as install target)
Rawhide seems to have developed a bug where a single disk is no
longer automatically selected as the install target when you
enter the INSTALLATION DESTINATION spoke. We need to work around
this (but register it as a soft failure).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 17:41:34 -08:00
Adam Williamson
54afe23572 Update an iSCSI needle for font changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 12:14:35 -08:00
Adam Williamson
b09936ba0a Update 'select_disk_1' needle
Some kinda font rendering change or something.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-17 08:33:57 -08:00
Adam Williamson
f8292bfeeb More Cantarell: Russian and French
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-18 23:56:11 +00:00
Adam Williamson
a653ded877 Next batch of Cantarell needles: Arabic install
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 15:32:30 +00:00
Adam Williamson
21febe3592 First batch of updates for new version of cantarell
Still need to do the non-English languages. I'll do those
tomorrow.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 01:18:52 +00:00
Adam Williamson
0d66b4bbcd Add various new non-English language needle variants
Seems like there's been a change to freetype or something, text
rendering changed in all of these. Note there's one workaround
needle for an untranslated message in Japanese.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-19 19:03:57 -07:00
Lukáš Růžička
6fc8c99515 Add needle to fix iscsi test. 2019-03-21 13:18:41 +01:00
Adam Williamson
f89e08e16d Add some new needle variants that failed ppc64 tests
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-03-01 08:52:25 -08:00
Adam Williamson
bd4edb0da7 GTK+ 3.24.5 needle retake
New GTK+ changed something so the background of many interface
elements is a slightly lighter grey, this broke a bunch of
needles. Here are the retakes. Includes one not-strictly-related
SDDM update and a rename of the one @lruzicka did to match the
others.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-02-06 13:27:30 -08:00
Adam Williamson
ad29a8fcde Great Stale Needle Cleanup 2018: anaconda
It's my second least favorite day of the year again: Stale
Needle Cleanup Day!

This should get rid of all anaconda needles that definitely are
not being used any more. A few borderline cases (where I'm not
100% sure if they may still be useful in odd corner cases, like
running universal tests on non-server images, and runs outside
of the US, and stuff) are kept around.

Cleanup of all non-anaconda needles will be in the next commit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-12-17 16:30:57 -08:00
Adam Williamson
0f1d0a1228 Add new Japanese needles
Seems the installer Japanese font changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-10-12 21:01:07 -07:00
Adam Williamson
1034104526 Add a large chunk of needles for Cantarell 0.111
This should cover nearly everything, I hope.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-09-10 02:44:50 -07:00
Lukas Ruzicka
8897fe45a6 Add test for Arabic installation (revisited). 2018-06-13 11:56:26 +02:00
Adam Williamson
fa73d2b8be Initial dump of Cantarell 100 / 101 needles
There will be more to come, but I want to push these out and go
to sleep.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-16 04:44:17 -07:00
Adam Williamson
672d60a840 Clean up a whole bunch of unused needles
Time for an annual spring clean. Based on the admin UI's list
of needles that haven't been matched for a long time, but with
some manual tweaking (some are actually still needed).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-01-02 16:13:47 -08:00
Adam Williamson
58ff0ecdbd Add updated add_network_disk needle
Icon changed a bit.
2017-02-08 12:17:05 -08:00
Adam Williamson
c4f32ab5ad add an Asian (Japanese) language install test
Summary:
Include some basic testing of Japanese input, and split the
input testing (including Russian) into a separate module, since
it's not really part of 'login' testing.

Test Plan:
Run the test, and the Russian and French tests too to
make sure they didn't break. Tested on staging. Note the Japanese
test soft fails, intentionally, at present, as I discovered a bug
while working on it:
https://bugzilla.gnome.org/show_bug.cgi?id=776189

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1072
2016-12-21 08:41:00 -08:00
Adam Williamson
7135a4e05d iSCSI: test user authentication
Summary:
This isn't in the criteria, but it's commonly used, so we ought
to test this way. Require authentication for the iSCSI target
and have the test provide the appropriate auth info.

Test Plan:
Run the iscsi test and check it works (you need the
recent fixes for support_server to make *that* work). Nothing
else should be affected.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1070
2016-12-20 08:34:30 -08:00
Adam Williamson
638aa01de2 update some iscsi needles for current f25 (and rawhide) 2016-10-27 00:35:42 -07:00
Adam Williamson
72074868a8 clean up lots of no-longer-used needles
Summary:
I've been wanting to do this for a while, but
https://github.com/os-autoinst/openQA/issues/786 is making it
difficult. Still, I think the quantity of needles is slowing
down openQA, so I'm doing it the old-fashioned way - looking
through test results and seeing what needles are actually used
now.

Test Plan:
Run full test suite for 24 Atomic, 25 and Rawhide and
make sure all tests still work. This is currently deployed on
staging (along with key-fixes) and I'm testing it there.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D994
2016-09-12 10:25:24 -07:00
Adam Williamson
5d7b46cb9d widen reclaim_space_delete_btn area to make it unambiguous
this needle can actually also match the 'Delete all' button,
resulting in the test not doing what it should. openQA should
prefer the match closer to the area's location in the needle,
but https://openqa.fedoraproject.org/tests/31136 seems to show
this not happening, so let's make the match area wider in all
versions of the needle so it should no longer match the Delete
all button.
2016-08-29 11:00:53 -07:00
Adam Williamson
232dad604c add a bunch of needles for changed font rendering
font rendering has changed somehow in both Rawhide and F25
updates-testing, retake a bunch of needles for this. Some more
may be needed later in tests that are currently failed or
skipped for other reasons.
2016-08-25 16:01:26 -07:00
Adam Williamson
7a8ae3a357 add an iscsi test, and a support_server test to support it
Summary:
this is following a SUSE model for tests where we need a server
end but don't want setting up the server to constitute a real
test in itself, we want it to be stable. The 'support_server'
test just boots a pre-built (by createhdds) disk image, sets up
networking, and runs the iSCSI server.

To run the iSCSI test we need to handle networking config in
anaconda (or we would need to set the support server up as a
DHCP server, which may be worth considering), so this adds that.
We also need to be able to specify the target device for a
volume in custom partitioning, so this adds that too.

Test Plan:
Build the necessary support server disk image (use
D883), then run the test and make sure it works. Also make sure
all other tests continue to work.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D884
2016-06-09 08:43:46 -07:00
Adam Williamson
a4f3267534 add Russian install test
Summary:
Requires new needles and test suite and job template, plus a
few tweaks to handle 'switched' keyboard layouts (so we use the
switched layout in the username and password).

Test Plan:
Run the test and see that it...fails. But that's OK!
It's a genuine bug: RHBZ  . At least make sure it gets
to that point and no other tests have broken and all the needles
look sane.

Reviewers: garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D846
2016-05-20 07:52:55 -07:00
Josef Skladanka
0d488890ba Organize needles to directories (step 2/2)
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D744
2016-05-13 13:43:31 +02:00