Commit Graph

1985 Commits

Author SHA1 Message Date
Adam Williamson
9eef80a85a base_services_start: convert mcelog exception to hcn-init
We've had this 'exception' for mcelog.service failing in here for
years. Looking into it, it seems to now be fixed:
https://bugzilla.redhat.com/show_bug.cgi?id=1526725
and hasn't happened in our official instances for years (I guess
because they're all Intel boxes). However, we have a similar case
on ppc64le with hcn-init.service failing spuriously:
https://bugzilla.redhat.com/show_bug.cgi?id=1894654
so I'm just converting it into a workaround for that instead. We
could wire this up to be more sophisticated, with some kind of
array or hash of services that are allowed to fail and more
complex checking code, but let's not bother unless/until it's
necessary.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-11-04 09:34:12 -08:00
Adam Williamson
b284e79250 Use PREVREL image not CURRREL for resize_lvm tests (#201)
These tests assume the desktop base disk image has an ext4-on-LVM
layout, but from F33 onwards it doesn't, it uses btrfs as that's
the new distro default.

We need a proper fix for this, but for now, just make the test
use the F32 disk image. This buys us six months at least.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-11-02 16:09:03 -08:00
Adam Williamson
d2e6c11c7b Update GNOME printing sentence needle
Seems sometimes we now get the document at fit width, not fit
page.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-31 11:26:32 -07:00
Adam Williamson
a569af3ed0 Enable more base tests on aarch64 images, fix up priorities a bit
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-30 15:57:24 -07:00
Adam Williamson
9deb95a876 Unify base tests across normal, Cloud and arm
We have variant versions of several of the base tests which exist
to account for differences in required variable settings to run
essentially the same test in different situations. By twiddling
the variables a little, including inventing a new variable
defined in the flavors and substituted into the test suites so
the same test suite can have a different START_AFTER_TEST when
run on different flavors, I think we can unite them all and make
this a lot simpler.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-30 15:27:25 -07:00
Adam Williamson
92d52c6ac6 Split VNC client steps in two for aarch64 timing issue
So, there's a problem with how we figure out the NetworkManager
connection to use in setup_tap_static: it expects the first
connection in the list to be the right one, but this is only
actually true so long as it's *active*. When we're in the tap
case, it's usually not going to actually *work* out of the box
on boot (or else we wouldn't need setup_tap_static at all...),
so some time after boot, NetworkManager gives up on it and marks
it as inactive. And after that, setup_tap_static won't work any
more.

I never noticed this as a problem before because usually we do
setup_tap_static before that point. But it seems in the vnc
client tests, on aarch64, desktop boot and login is slow enough
that by the time we switch to a VT and try to setup the network,
we're very close to that cutoff, and sometimes miss it.

This, I hope, avoids the problem by doing the network setup in
that test before we deal with the desktop login, then doing the
desktop login, then doing the actual VNC bits.

The alternative here would be to figure out a better way to do
setup_tap_static, but I can't.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-30 12:39:52 -07:00
Adam Williamson
bcefdd8357 Wait a bit before typing password on GNOME login screen
Seems like this often fails when booting the desktop disk image
on aarch64 if we start typing right away.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-30 12:39:52 -07:00
Adam Williamson
5341957960 cockpit: wait longer for services screen to load
It seems like it can be *really* slow on aarch64, since 218:
https://github.com/cockpit-project/cockpit/issues/14840
this should give it a total of 180 seconds on aarch64 (90 second
still screen timeout plus 30 second assert_screen timeout, with
1.5x scale).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-30 12:39:52 -07:00
Adam Williamson
c7a1b94c84 Enable aarch64 disk image testing, related fixes
This sets us up to test the release-blocking aarch64 disk images
(Minimal, Server and Workstation). It also allows for testing
armhfp disk images on aarch64 worker hosts (though my testing of
that isn't going too well so far), and fixes the initial-setup
handling for a change upstream ('use password' is now the default
so we don't need to choose it). We rewire disk image deployment
test loading to work through the generic loader code rather than
using ENTRYPOINT, as it allows us to more gracefully handle
graphical (Workstation) vs. console (Server, Minimal), moving
the code for handling console initial-setup to a helper function
just like the code for gnome-initial-setup and having _console_
wait_login call it when appropriate. We also tweak desktop_vt a
bit because now we need to switch from a console running as test
to a desktop, which breaks the assumption that the highest
numbered session of user test is the desktop...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-30 12:39:49 -07:00
Adam Williamson
f51a804357 Handle emergency console entry with no password
This happens on ARM disk images.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-28 15:21:03 -07:00
Adam Williamson
b57b306d4b _iot_zezere_remote: be careful when quitting firefox
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-28 13:52:07 -07:00
Adam Williamson
505c556c67 support_server: disable systemd-resolved
We're setting up our own (dnsmasq) name server, we can't have
resolved running.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-28 09:07:46 -07:00
Adam Williamson
9be79d3dc7 Drop match level on KDE update detected needle
Got a 93% match at
https://openqa.fedoraproject.org/tests/708115#step/desktop_update_graphical/22

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-27 08:53:59 -07:00
Adam Williamson
d8f5d3fd0b Update several KDE needles for font rendering / button changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-26 12:38:08 -07:00
Adam Williamson
cfb226d3fd Simplify anacondatest root_console to always use tty3
Rawhide KDE lives now have the desktop on tty2, and the installer
environment tty3 now has a shell (in Ye Olde Times it didn't, not
sure when that changed but it's the case at least back to F31).
So let's make our lives simple and just always use tty3 here.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-26 09:21:53 -07:00
Adam Williamson
d20f64967c Update a couple of KDE needles
Font rendering change, or transparency, or some damn thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-23 23:07:10 -07:00
Adam Williamson
d3569dbf37 Update anaconda rescue select needle
"Rescue" was downcased to "rescue".

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-23 22:48:51 -07:00
Adam Williamson
a9704de4bd FreeIPA: disable dnssec validation till weird bug is fixed
I noticed today that if we deploy FreeIPA with dnssec validation
enabled, dnf can't resolve dl.fedoraproject.org afterwards, which
is a problem because it means we wind up falling through to
random mirrors for metadata and package download once the server
is deployed, which can be slow and give old packages. This seems
to be why the server upgrade test on F33 is sometimes failing
because we get an older FreeIPA package on upgrade, even though
the newer one has been stable for a week.

It's difficult to pin down exactly where this bug is and fix it,
I've mailed some folks to try and work it out, but until that's
figured out, let's just disable dnssec validation.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-23 11:38:01 -07:00
Adam Williamson
0d8ceec820 Try to make desktop_browser more robust
We've been getting failures lately on the first page load, I
think because Firefox is getting even more grindy on startup. So
turn the 'sleep' into a 'wait_still_screen', extend another wait,
and tweak the 'browser' needle so it only matches after the
bookmark bar has loaded rather than as soon as half the chrome
appears. Also make all the wait_still_screens use similarity 45
for consistency (flashing cursor could be there on any of them).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-23 09:48:09 -07:00
Adam Williamson
bd7d3cd663 Fix desktop_terminal command check (thanks defolos)
This check wasn't working, the test passed whatever wait_serial
found. This version suggested by defolos works, I checked.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-15 16:25:26 -07:00
Adam Williamson
33c290d15a Remove now-unused desktop_network_notification needle
Dropped the use of this in the recent notification simplification,
but forgot to remove the needle. Should've run tox...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-15 15:36:37 -07:00
Adam Williamson
e5f396a785 Drop workaround for fixed GNOME submenu bug
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2878 was
fixed (or just rendered obsolete by a change to how submenus
work), so we don't need this any more.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-15 15:36:09 -07:00
Adam Williamson
1c33d07d38 Drop workaround_ble26, bug was fixed months ago
https://pagure.io/background-logo-extension/issue/26 was fixed
months back, we don't need this any more.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-15 15:36:04 -07:00
Adam Williamson
a008ffb8be Simplify desktop notification checks (#195)
This is the best option I can come up with to deal with #195.
Update notifications seem to have become transient in KDE lately
(even in F31 and F32, if I'm looking at these screenshots right).
This actually simplifies things a lot to do more or less the
same in the KDE and GNOME paths: open the 'permanent' store of
notifications (in GNOME you get to it by clicking on the clock,
in KDE via the systray) and then look for no notifications (live
path) or only an update notification (post-install path). We
only run this test for composes so we shouldn't need to worry
about anything older than F32, and I believe this should work
for KDE in F32 and F33. I left out click_unwanted_notifications
for now as I'm hoping it should be unnecessary, but we can add
it back in if necessary.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-14 23:30:00 -07:00
Adam Williamson
656e1f6856 Add another F33 background needle
Yeesh, this background is fun.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-11 10:04:37 -07:00
Adam Williamson
db99e5462c Drop F33 FreeIPA update from workarounds, it went stable
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-10 17:27:33 -07:00
Adam Williamson
da0b079686 Update KDE desktop no notifications needle
Probably changed with the background, darn translucency.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-09 18:06:19 -07:00
Adam Williamson
415dabd92e Update Firefox addon_install alt needle too (for F31)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-09 17:53:22 -07:00
Adam Williamson
10f7e7a7d2 Update Firefox addon_install needle for 81.0.1
Seems to have changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-09 17:25:10 -07:00
Adam Williamson
9de75af60b Drop f33-backgrounds from workarounds (it went stable)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-09 16:57:21 -07:00
Adam Williamson
94b47afc53 Tweak setup_tap_static and FreeIPA tests for resolved
This does some of the things suggested by cheimes in
https://bugzilla.redhat.com/show_bug.cgi?id=1880628#c24 . It
seems to make the replica tests work with resolved, still work
with pre-F33 resolving, and not break anything. Also remove the
workaround to disable resolved if it's running, as we can now
work with it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-09 16:54:46 -07:00
Adam Williamson
92f5bf90c0 Update Krusader settings close needle
The button changed a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-08 16:22:44 -07:00
Adam Williamson
40e07b487d Add another F33 background needle
For the transition between dawn and day. This is right in the
middle of it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-08 16:21:59 -07:00
Adam Williamson
40974c2f94 Simplify Krusader app test
We don't need a separate 'welcome' needle because it just matches
on an OK button anyway. So turn that needle into an OK needle
(we don't have any existing 'blue OK button' needle) and simplify
the logic to a single loop for kde_ok and krusader_settings_close.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-08 14:47:46 -07:00
Adam Williamson
401ebecc10 Add F33 FreeIPA 4.8.10-5 update as workaround to fix upgrades
FreeIPA upgrade test is failing because of
https://bugzilla.redhat.com/show_bug.cgi?id=1886205. The test
failing every time is not useful as we know what the issue is,
so add the update as a workaround to avoid it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-08 11:28:10 -07:00
Adam Williamson
e89de5fffb Bump a timeout a bit for aarch64
Seems like 10 seconds here isn't always long enough for aarch64,
so bump it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 15:21:17 -07:00
Adam Williamson
200cab3899 disk_custom_resize_lvm: add some waits
On ppc64le it looks like this test is often failing because it
takes a second or two to update the partition list after we
click update settings, but we're not waiting for that, so we
wind up clicking in the wrong place because we match the next
partition needle before the list is refreshed but click after
it's refreshed. Let's hope these waits solve it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 14:52:49 -07:00
Adam Williamson
5e5dbac636 Add updated cockpit_updates_reconnect needle
We only use this one rarely. Font rendering on it changed at
some point.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 14:42:26 -07:00
Adam Williamson
d2adecf03d Add some more updated F33 background needles
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 14:41:54 -07:00
Adam Williamson
36fd4c10b1 Correct tag for new kde_ok needle
It had krusader_settings_close as its tag, not kde_ok. That's
why the krusader test module was failing weirdly.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 14:39:08 -07:00
Adam Williamson
4fcea15610 Updates testing: add f33-backgrounds workaround
Add FEDORA-2020-27f80050a2 as a workaround because without it the
KDE desktop background test fails due to the bug in -6.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 12:40:27 -07:00
Adam Williamson
8d9684dd80 Update tests: don't install git any more
We were using it to checkout a git version of python-fedora to
work around a bug, long ago, but we don't do that any more so
we don't need it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 10:19:33 -07:00
Adam Williamson
aafe460f85 Update testing: drop all workarounds
They're all stable now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 10:09:59 -07:00
Adam Williamson
1fdf7cd567 Handle update build not having any packages for target arch
openQA sometimes winds up testing an update that doesn't have
any packages for x86_64 (or aarch64). The most common case is
s390utils, which is on the critpath but only has packages for
s390x. I would ideally like to skip scheduling entirely if the
update has no packages for the arch we're scheduling on, but
sadly that involves using the Koji API which is XML-RPC and I
don't really want to deal with that again. This deals with it
at the test level instead, by checking the error message if
`koji download-build` fails and carrying on if it's the "no
packages for this arch" error. That means if the update has no
packages at all for our arch we're not really testing anything,
but that's better than a bunch of false failures, I guess.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 09:49:03 -07:00
Adam Williamson
ea0dc63fc3 Add updated F33 day background needle
The backgrounds were tweaked so I get to take a bunch more
screenshots, fun fun fun.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-06 14:54:58 -07:00
Lukáš Růžička
b5a7b49f6e Correct the misconfigured needle from the previous commit and add a proper one. 2020-10-01 12:42:56 +02:00
Lukáš Růžička
3986984eb3 Fix needles for Krusader and Notifications. 2020-09-30 09:08:20 +02:00
Dan Čermák
3316e04d20
Update live_anaconda_icon KDE needle 2020-09-20 11:59:16 +02:00
Adam Williamson
fdf142dbd5 Disable systemd-resolved before deploying FreeIPA server/replica
Having systemd-resolved in use seems to cause problems for
FreeIPA servers:
https://bugzilla.redhat.com/show_bug.cgi?id=1880628
until the scripts are enhanced to do this or something, let's
disable it before server/replica deployment.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-18 13:49:11 -07:00
Adam Williamson
aab6935707 FreeIPA replica: don't re-do setup_tap_static after deployment
ipa-replica-install already changes the DNS config to use the
local bind instance, we don't need to do this and it's actually
wrong (as it bypasses the local BIND we should use and uses
the VM host's DNS servers instead).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-18 13:43:28 -07:00