Commit Graph

498 Commits

Author SHA1 Message Date
Adam Williamson
7fbaa426e8 Update a bunch of needles for font rendering change in Rawhide
Not sure what changed; it seems like mostly browser needles got
broken, but there's a few installer needles too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-29 13:00:54 -08:00
Adam Williamson
5c03c435ca Stop having two 'firefox close tabs' needle tags, drop old ones
We still have a 'apps_run_firefox_stop' needle tag which is for
the same thing as 'firefox_close_tabs'. That's dumb. Get rid of
it and only have the firefox_close_tabs tag and needles. Also
clean up some old firefox_close_tabs needles that haven't matched
for months and all the 'apps_run_firefox_stop' needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-29 12:10:35 -08:00
Adam Williamson
e7a7c053bd Update firefox_close_tabs needle
Seems to look different in a recent Rawhide test.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-27 11:08:44 -08:00
Adam Williamson
e8802935f9 Tweak text_console_login match area
On Rawhide Cloud_Base boots, there's some SSH key and network
information printed above the 'login:' prompt, so we can't
expect empty space there. Also tweak console_login() to clear
the screen after logging in, so the login prompt is cleared and
doesn't confuse things on subsequent runs (like it did first
time we tried this). And add a new user logged in needle, as it
seems after we clear the screen the tilde appears in a slightly
different position and the existing needle doesn't match.

https://openqa.fedoraproject.org/tests/489003#step/_console_wait_login/7

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-27 10:39:29 -08:00
Adam Williamson
411f0d34e7 Revert "Tweak text_console_login match area"
This reverts commit f66f510832.
Turns out this breaks lots of stuff, so it needs to go back.
I'll have to figure another way to handle the cloud login.
2019-11-27 08:36:35 -08:00
Adam Williamson
f66f510832 Tweak text_console_login match area
On Rawhide Cloud_Base boots, there's some SSH key and network
information printed above the 'login:' prompt, so we can't
expect empty space there. Let's just hope not looking for the
empty space doesn't break anything else.

https://openqa.fedoraproject.org/tests/489003#step/_console_wait_login/7

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-26 08:26:27 -08:00
Adam Williamson
25cce2361c Update a KDE app test needle
Window title changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-22 09:13:27 -08:00
Adam Williamson
0722cc5bcf Update Cockpit 'join domain' needle for cockpit 207
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-14 08:43:03 -08:00
Adam Williamson
4f72d4ebd3 Add one missing needle for VNC test
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-05 14:48:25 -08:00
Adam Williamson
b82a1dec6f Add test for QA:Testcase_Anaconda_User_Interface_VNC
This adds a test for QA:Testcase_Anaconda_User_Interface_VNC -
the VNC install test case. It's implemented as a server/client
pair, with the server booting from the Server DVD image with
`inst.vnc` and the client booting from the desktop base disk
image, setting up networking, then running Boxes to connect to
the server and run the install.

There are various little tweaks to test loading and logic to
handle this, mostly pretty clear. We also move the workaround
for 'spurious auth prompt appears on desktop after you switch
away to a VT and back' out of the desktop update test and into
the `desktop_vt` helper function, since now this test can hit
it as well. We enhance _graphical_wait_login to handle the boot
loader if needed (it has never needed to until now).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-05 14:46:10 -08:00
Adam Williamson
a0e191e097 Update cockpit login screen needle *again*
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-30 15:20:30 -07:00
Adam Williamson
efec7010cb Handle an 'akonadi did something' notification in KDE, etc.
This handles a case where KDE shows a notification saying
'PIM Maintenance (Finished)', like this:

https://openqa.fedoraproject.org/tests/477345#step/desktop_notifications/34

we need to click it away for the desktop_notification test to
pass. It also clarifies the difference between this notification
and the eternal 'akonadi_migration_agent is doing something'
popup in the needle names and comments. It also replaces the
'check_screen then assert_and_click if found' pattern in several
notifications-related places with the better 'check_screen then
click_lastmatch if found' pattern now available upstream.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-30 09:05:06 -07:00
Adam Williamson
81100e8a17 Add new Cockpit 'software updates' needle
Needed for the UI change in Cockpit 205.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-29 16:01:35 -07:00
Adam Williamson
4fb29f8bdb Add new Firefox GNOME app menu needle
Firefox icon changed, so this needs updating too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-29 15:55:52 -07:00
Adam Williamson
3cdfe96a5c Add another Firefox launcher needle variant
Seems we need two as the launcher background is a different
color on different Fedora releases...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-24 13:53:52 -07:00
Adam Williamson
51d37aeeef Update Firefox launcher needles for new icon
Firefox icon changed a bit in 70.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-24 13:23:24 -07:00
Adam Williamson
e313e58cdd Add new variant boot_enter_passphrase graphical needle
New plymouth has tweaked this screen's appearance.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-24 13:20:51 -07:00
Adam Williamson
e1030118f9 Add new cockpit login needle
The login screen background changed in 205.1 (it's actually the
same image, but it's now zoomed rather than just a chunk of it
being shown on a smaller screen).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-18 10:35:14 -07:00
Adam Williamson
b455e04188 Add new cockpit needles for 205
The cockpit UI went all GRIMDARK so we need a couple of new
needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 17:10:28 -07:00
Adam Williamson
5f38971a78 Add some new variant layout indicator needles
Once again, the text is at a slightly different height to the
needles we already have. I do not know why this sometimes
happens. It's a mystery.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 16:34:55 -07:00
Adam Williamson
b55782358d Don't check version or pre-release note on banners
This reduces the coverage of the identification test a bit but
also *substantially* simplifies it. We run into a ton of problems
when we try to check the version and prerelease text on screens
where it appears on banners:

* The banners differ between variants
* The pre-release text is translated
* The banners have gradients so for RTL languages, even if some
  text is untranslated (e.g. 'Fedora 31') it appears on a
  different background color than on LTR languages
* The prerelease text is dark red; if it appears on a dark blue
  area of the banner this can trigger an os-autoinst needle
  comparison bug: https://progress.opensuse.org/issues/56822

All of this together means we wind up continually fighting these
checks and we have a whole forest of needles just for them, and
it doesn't seem worthwhile. So let's drop all the places where
we were checking version and prerelease on banners, and only
check them in two places where they appear on a grey background,
which avoids most of the problems (we just need one version
needle per release, and one prerelease needle per language).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 11:08:24 -07:00
Adam Williamson
205c0c3d97 Add new variant ABRT needle for KDE app test
Font rendering changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-10 12:09:41 -07:00
Adam Williamson
6636122f62 New needle for *partly* translated 'install done' Japanese
Now one of the strings we check for is translated, but the other
is not...handle this, again with a workaround needle so the
missing translation triggers a soft fail.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-07 11:26:54 -07:00
Lukas Ruzicka
d82f4ecd7f Develop a new test for system updates via Cockpit.
* server-cockpit-updates tests that Cockpit can be used to update the system.
* server-cockpit-autoupdate tests that users can use dnf-automatic for system
updates.
* cockpit functions were removed from utils.pm and put into an extra library
for cockpit - cockpit.pm which all cockpit tests are now using.

Review cockpit.pm

Review autoupdate test.

Review the update test.

Fix typo in cockpit.pm

Add sleep.

Add missing command.

Delete an unused needle.
2019-10-01 16:04:01 +02:00
Adam Williamson
0782f4faf2 Add new akonadi migration agent needle for F31 background
Light blue throwing us off again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-26 10:24:37 -07:00
Adam Williamson
61f8adefdf Add some new update-related needles for KDE
The new background seems to be throwing us off here. I think
the menu is *very slightly* transparent so the needles usually
work for most Fedora backgrounds as they tend to have a similar
base color, but the 31 one is unusually light.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-19 10:23:21 -07:00
Adam Williamson
6e9a7a57c5 Add several more variant keyboard layout needles for new icon
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 12:26:26 -07:00
Adam Williamson
96cf14d555 Add new variant us_rtl layout needle
For RTL languages the keyboard icon and language indicator are
the other way around, so we have different needles even for the
US layout indicator which is otherwise the same in all langs.
This is a variant needle for the new keyboard icon that showed
up in Rawhide recently.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:32:58 -07:00
Adam Williamson
0f9fd1a76a Add alternative vdb selected needle for new blue checkboxes
This checkbox sometimes renders slightly differently, especially
on non-x86_64. We're not really sure why, but we just add more
needles to handle it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:23:47 -07:00
Adam Williamson
ea11c8344f Shrink KDE Firefox launcher icon to avoid background issues
Existing one doesn't match if the background is too different,
shrink it to just the center of the icon.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 15:12:03 -07:00
Adam Williamson
a1d9b14383 Some more prerelease needle updates 2019-09-11 15:01:44 -07:00
Adam Williamson
dc8ed1c9ba Yet more pre-release check fixes
We need another needle for French installs, and we need to use
ISO_URL for checking the ISO file name if ISO isn't set.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 14:31:54 -07:00
Adam Williamson
29a5e0bda7 Add variant 'permission denied' needle
For some reason, occasionally the 'm' character looks slightly
different. I have no idea why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 10:47:13 -07:00
Adam Williamson
be1baa90e5 Update main hub needles for changed keyboard icon
Someone is pretty OCD about this damn keyboard icon, it just
keeps getting changed...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-09 11:44:28 -07:00
Adam Williamson
a3c207a045 Add a few more 'blue button' needle variants
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 18:09:14 -07:00
Adam Williamson
23ad087ed3 Add blue button variants for workstation_selected needle too
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 17:28:41 -07:00
Adam Williamson
cf6f8db3e7 Add new variant 'minimal selected' needle for radio button change
Radio buttons look different with recent GTK, it seems.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 16:14:59 -07:00
Lukas Ruzicka
1d6e2aaa19 Add changed needle that failed for cyrillic test. 2019-09-05 17:10:50 +02:00
Adam Williamson
df88196357 Add F31 background needle
Now we have the backgrounds!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-04 12:44:55 -07:00
Adam Williamson
6d68b2c6fa Add yet another prerelease note needle
Seriously starting to think about separating out this ident
stuff into a separate test case :/

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-29 17:49:27 -07:00
Adam Williamson
53778fe494 Add language tags to the new language prerelease note needles
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:46:23 -07:00
Adam Williamson
b19e6bbda7 Add some needles for pre-release note translations
These showed up because I did a manual universal flavor run on
an ISO today, but we'll need them as soon as we do a candidate
compose too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:14:57 -07:00
Adam Williamson
2cb224a184 Make generic topbar needle narrower
We did this for the orange (Server) one already, but not the
blue generic one.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:07:33 -07:00
Adam Williamson
26308a6b47 Update rarely-used installer ext4/xfs partitioning needles
These only get used when we run universal tests on a non-Server
image, which is pretty rare (these days, as Server DVD is a
critical image and composes fail if it fails, it only really
happens when we do it manually for some reason, like I did
today). So they get stale and aren't updated for font rendering
changes and stuff. As I said I had to do a run like that today,
so I had to update all these needles...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:04:13 -07:00
Adam Williamson
4bb89046d3 Add one more updated GNOME app test needle
'Simple Scan' renamed itself.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 17:51:20 -07:00
Adam Williamson
28443abf04 Add new variants for GNOME app start/stop tests
Several apps changed icon.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:29:37 -07:00
Adam Williamson
77a6c0ed4d Add yet another variant 'vdb selected' needle
This screen often seems to show slight variances in color,
really not sure why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:28:44 -07:00
Lukas Ruzicka
022865ab9f KDE app start/stop: launch apps with commands not menus
This is doing slightly less to exercise the launcher menus and see
whether icons appear or disappear, but it's much faster and more
reliable. We do still use menu launch for one app, just to check
the mechanism works in general.
2019-08-23 12:41:49 -07:00
Adam Williamson
06e26e9721 Narrow topbar and add new version needle to cover languages
The top bar differs in non-English languages - for RTL the
version ident is on the left (so background is different), and
the width of the area with no text differs depending on the
length of the translations.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 14:36:53 -07:00
Adam Williamson
23552c777d Add a new KDE desktop update needle variant
Little black bits on the icon are in a different place now. Why,
I do not know.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 11:55:07 -07:00