Commit Graph

1555 Commits

Author SHA1 Message Date
Adam Williamson
3c44f644a0 Reduce system_menu_button match area not to include background
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-11 16:07:18 -07:00
Adam Williamson
21ecfa8538 os_release: blow up on RC compose with prerelease fedora-release
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-11 16:05:47 -07:00
Adam Williamson
6f9ee2484c Fix prerelease check in os_release.pm
Whoops, bracket in wrong place...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-11 15:41:21 -07:00
Adam Williamson
ac602d43b7 Update Japanese 'install done' needle
The button is translated now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-09 10:33:00 -07:00
Adam Williamson
acc46464f8 Revise release variable handling, prerelease checks, os-release
I started out trying to fix os-release for the recent change to
add "Prerelease" tags to the VERSION and PRETTY_NAME fields, then
things spiralled. It got me thinking about the awkward DEVELOPMENT
variable we use, so I decided to get rid of it and refactor the
few things that use it. I refactored the anaconda prerelease tag
check, and wrote a new giant comment that gives details about
exactly how anaconda decides whether to show those tags, to give
context to our choices about when to expect them. This check now
uses a new LABEL variable the scheduler now sets. I also wound up
creating new UP1REL and UP2REL vars to define the 'source' release
for upgrade tests, separate from CURRREL and PREVREL, which are
now never lies - they really are the current stable and previous
stable release, even for update upgrade tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-07 15:42:08 -07:00
Adam Williamson
8eaddd8c3d Set OfferToSaveLogins policy to false in Firefox config
This seems to work around the Firefox 76 bug with password entry
sometimes breaking:
https://bugzilla.mozilla.org/show_bug.cgi?id=1635833

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-06 13:25:46 -07:00
Adam Williamson
e67d3e7c01 Drop similarity level on Cockpit login screen wait_still_screen
We have a flashing cursor, folks.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-06 12:58:59 -07:00
Adam Williamson
3bc1e8335a Put /var/lib/mock on separate disk for live image build test
The update live image build test keeps running out of disk space.
We've bumped the minimal disk image from 12GB all the way up to
20GB so far but it keeps happening. So let's try a different
strategy: use a scratch disk to mount /var/lib/mock. That's where
all the space gets used. This should allow us to reduce the size
of the minimal disk image again, and giving it 25GB of empty disk
should avoid it running out of space again for a while.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-05 21:12:12 -07:00
Adam Williamson
d66b185471 solidify_wallpaper: restore a wait_still_screen in GNOME path
The old code waited after launching the terminal, the new code
doesn't, which led to a 'g' being swallowed in the first command
in https://openqa.fedoraproject.org/tests/592759 .

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-05 10:19:31 -07:00
Adam Williamson
8866b5289e Fix solidify_wallpaper for KDE
The desktop check used the wrong case.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-05 10:08:47 -07:00
Adam Williamson
c7031448ec Update Cockpit 'main screen' needle
It seems like sometimes the machine ID is off the bottom of the
screen now, so let's just match on the section title instead.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-04 17:24:31 -07:00
Lukáš Růžička
61f845dbbf Make solidify_wallpaper more universal to handle different desktops. 2020-05-05 00:14:35 +00:00
Adam Williamson
0594fc8d57 Update French user creation screen needle for translation change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-01 16:48:21 -07:00
Adam Williamson
9bad775aae Update a blivet needle for a change to check mark design
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-29 12:19:39 -07:00
Adam Williamson
664d5d559f Update cockpit 'services entry' needle for new release
Unfortunately only the entry name is clickable now so we can't
have a 'generic' needle that'll work for any service.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-29 12:16:26 -07:00
Adam Williamson
9d2dabb5f9 Add a helper script for moving needle files
I actually wrote this a while back but have just been keeping it
on my local machine till now; figured I'd clean it up a bit and
add it to the repo. It's just a little helper for moving needles
into subdirectories, it's useful if you do a big needle retake
and have dozens of needles you need to put in the right subdirs,
saves figuring them out for yourself.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-27 15:06:34 -07:00
Adam Williamson
83a394bba2 Update a Boxes needle for a font rendering change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-27 15:06:14 -07:00
Adam Williamson
3e5e1104b7 Update a bunch of KDE needles for Rawhide font change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-27 15:06:09 -07:00
Adam Williamson
8c76fa8458 Work around #1811234 for update upgrade tests
This is failing on every update and that's not telling us anything
useful - we already know about the bug - so let's work around it.
Not adding a softfail as it's a bit more awkward to do that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-27 12:55:34 -07:00
Adam Williamson
41aed12b16 Handle Boxes tutorial screen in _vnc_client_connect
We can get tripped up by the tutorial screen when launching
Boxes; borrow some code from the app start/stop test to check for
and handle it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-27 12:04:00 -07:00
Adam Williamson
0b7a9cf3c8 desktop_login: give 'ret' keypress a bit of time to take effect
The default timeout for check_screen is 0, so we were only giving
the enter key press a fraction of a second to take effect before
expecting to see locked_screen_switch_user. This is too tight,
see https://openqa.fedoraproject.org/tests/586257 . Let's give it
five seconds before we give up.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-24 10:39:12 -07:00
Lukáš Růžička
fd3e4e3280 Change the order of steps and add another check screen.
Since GDM shows the "system-menu-button", it could not correctly
switch users on a locked screen. I added a check to see
if we are on a locked screen and behave accordingly.
2020-04-22 21:52:19 +02:00
Adam Williamson
23904d71b2 Update French apps menu button, remove extra match areas
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-18 14:59:14 -07:00
Adam Williamson
ea9ac508ac Fix check_desktop variable timeouts
I forgot that tries was configurable. Sigh. Convert it to a
timeout argument.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-18 14:54:48 -07:00
Adam Williamson
3a0b6349e7 fifloader: Run upstream loader with check=True
Otherwise we exit 0 even if that run fails.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-18 12:08:55 -07:00
Lukáš Růžička
f3d6a9574c Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.

While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.

So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-04-17 17:27:04 -07:00
Adam Williamson
49c8d46744 Update some Cockpit button needles for 217
Seems like text rendering on buttons changed a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-15 11:40:45 -07:00
Adam Williamson
c914b1ad88 Update F32 background needles
This adds a needle for the 'day' background from 32.1.1, which
is the non-animated default, and renames the needle for the
background from 32.0.0 to 'old' as it's no longer present at all
in the new build. Depending on whether animation actually works
after the update we may later need to add needles for the other
images plus possibly some transition needles too. Sigh.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-15 11:39:04 -07:00
Adam Williamson
417b876ead Add F31 variant Terminal app run needle
Needed for F31 respin tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:12:57 -07:00
Adam Williamson
252013fe3a Tweak desktop_notifications to work around #1821499 (again)
...this one should really work!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:10:02 -07:00
Adam Williamson
19677de20a Add variant anaconda keyboard layout needles
There's this weird thing where the vertical alignment of the
language name in the keyboard layout indicator is sometimes
different. I never can figure out why. It may be to do with
presence or absence of the pre-release indicator.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:07:06 -07:00
Adam Williamson
610572f8a0 Add new variant SDDM input needle
Looks like a kerning difference or something.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:05:33 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Adam Williamson
dce733d186 Re-enable py39 in tox config
diff-cover merged my PR and cut a release, so I hope this should
work again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 11:47:06 -07:00
Adam Williamson
0189b338d0 Drop all #1821499 workaround attempts
This stuff is kinda broken in various ways and halfline thinks
he can fix the underlying bug anyway. So let's go back to just
the GNOME live test being broken for now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-07 15:14:57 -07:00
Adam Williamson
e2fdf125b2 tox: disable py39 environment until diff-cover is fixed
diff-cover is broken on Python 3.9:
https://github.com/Bachmann1234/diff_cover/pull/140
once that is fixed we can re-enable this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-07 12:20:50 -07:00
Adam Williamson
1c3106ebe3 OK, try setting GDM to debug mode instead?
I tested this workaround on staging before pushing it to git and
it worked, but then when I pushed it to prod it didn't work. On
stg I also had this to set GDM to debugging mode, so maybe this
is also needed for the workaround to work for some reason?

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-06 17:30:03 -07:00
Adam Williamson
b811d93c4c Try a sleep before hitting enter on GDM screen
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-06 17:19:06 -07:00
Adam Williamson
d8c7f85ecb Workaround RHBZ#1821499 in desktop live notifications test
A GNOME bug seems to result in us getting to GDM, not a liveuser
desktop, after running 'systemctl isolate graphical.target' from
a live boot to runlevel 3 since the end of March. This works
around that to let the test run, as it's not really a failure of
the test per se.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-06 17:05:11 -07:00
Michel Normand
cc5c85a3e4 Increase timeout for getting_started ppc64le f32
Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2020-04-03 19:38:04 +02:00
Adam Williamson
8b5be61971 Update a few GNOME app needles that seem to have changed
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:27:01 -07:00
Adam Williamson
ea397783d5 Update French 'accept fate' needle
Verb changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:17:42 -07:00
Adam Williamson
6b5e933ff4 Update error_report needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:16:02 -07:00
Michel Normand
d384cfed30 Regenerate grub.cfg for ppc64le Silverblue to boot (step 2)
Previous commit same summary had some side effect
solved by this new one.

And avoid a warning in autoinst-log when ABRT var not defined.

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2020-04-02 20:50:06 +00:00
Lukáš Růžička
603ee871c1 Prevent the Konqueror test from running on F32 and later.
Rework changes after the review.
2020-04-02 14:08:19 +02:00
Adam Williamson
36181eea76 Fix 'actions' ordering after last commit
I merged the previous commit before realizing the ordering was
wrong. All other 'actions' lines have to come *before* the one
that adds 'reboot', because one of the conditions for that is
whether @actions is populated - basically, if we're taking any
actions, we also have to reboot afterwards. If we add an action
*after* that line (but no actions were added before that line),
we'll do it but then not reboot and the test will break.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-01 10:34:50 -07:00
Guy Menanteau
8d7be9a227 Regenerate grub.cfg for ppc64le Silverblue to boot, brc#1817004
Patch for https://bugzilla.redhat.com/show_bug.cgi?id=1817004

Signed-off-by: Guy Menanteau <menantea@linux.vnet.ibm.com>
2020-04-01 09:57:23 +02:00
Lukáš Růžička
29f9da9331 Revert "Prevent the Konqueror test from running on F32 and later."
This reverts commit 00b756f0e2.

Unfortunately, I made a typo in the script and the fix did not
work. I do not want to rebase the master (in order not to break
things for everyone) so I am reverting again.
Sorry.
2020-03-31 13:04:50 +02:00
Lukáš Růžička
00b756f0e2 Prevent the Konqueror test from running on F32 and later. 2020-03-31 09:37:11 +02:00
Lukáš Růžička
a54f020118 Revert "Fix the Konqueror test - handle Locations dialogue."
This reverts commit d784bf54ca.

It turned out that Locations are not connected to Konqueror
at all. The reason why the test is failing is that the
application has been removed to limit the number of
web browsers.
2020-03-31 09:23:13 +02:00