Commit Graph

55 Commits

Author SHA1 Message Date
Adam Williamson
2a7787c1da Update lots of needles for os-autoinst behaviour change
Recent git os-autoinst no longer downsamples screenshots as far
as it did before comparison. This makes a lot of needles where
colors have changed slightly no longer match, so they all needed
updating.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-19 13:03:11 -07:00
Adam Williamson
6a79565afa Fix up KDE 'plasma-disks' test stuff
In #235 we accidentally included an entire disks.pm test that
wasn't meant to be there - the infocenter module test is the
right thing to exercise plasma-disks, there is no standalone
app, running 'disks' just gets you the KDE Partition Manager,
which we already test. So this removes that test and renames a
needle that looks like it's for that test but is actually for
the kinfocenter module, to make this clearer.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-21 15:16:40 -07:00
Lukáš Růžička
9f0103a95f Enhance the Infocenter test to test the presence of Disks module. 2021-06-18 11:39:28 -07:00
Lukáš Růžička
2c366cc7a4 Add startstop test for Plasma Vault. 2021-06-18 11:39:24 -07:00
Lukáš Růžička
9fdc63d4e2 Delete needles reported as unused by the check_needles script. 2021-06-10 12:13:41 +02:00
Adam Williamson
4fd395ff74 Update KDE Spectacle app runs needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 15:40:53 -07:00
Adam Williamson
6c52a1c1dd Update Konsole runs needle, maximize Konsole in desktop_terminal
The needle match seems to have changed when bug #1957858 showed
up, but it's actually just a text rendering change in the window
title, it's not exactly caused by the tiny window. So not marking
as a workaround needle.

Maximizing the window makes the test work faster when we hit that
bug, as type_safely needs to be able to see the results of its
typing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-02 11:07:49 -07:00
Adam Williamson
5b15979f54 Update KDE system-settings runs needle (some font change)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-19 12:09:09 -07:00
Adam Williamson
143f553ec4 Update kparted-runs needle
Font rendering changed slightly, dunno why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-10 15:52:56 -07:00
Adam Williamson
571d7c2efe Update KDE app needles once again for Noto with grey background
...sigh.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-22 17:00:21 -07:00
Adam Williamson
24e1bfef24 Update konsole_runs needle again for Noto-on-grey
I sense another fun day updating a zillion KDE app needles in my
future.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-15 16:53:30 -07:00
Adam Williamson
4962f9c628 Update a few more needles for Noto in KDE
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-08 08:37:20 -07:00
Adam Williamson
9e08112ae9 Update a lot of needles for KDE switch to Noto fonts
KDE switched to using Noto fonts by default (and title bars seem
to be blue again), many needles need to be updated.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-07 19:44:41 -07:00
Adam Williamson
a8f7d3639f Remove kgpg_tips_close needles
I tweaked the test to no longer require these.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 18:23:25 -07:00
Adam Williamson
36ad08868c Remove Calligra needles
KDE has LibreOffice now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 18:22:56 -07:00
Adam Williamson
a32a205e7a Update kgpg_runs needle for latest Plasma
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:50:22 -08:00
Adam Williamson
3c92696d98 Convert ksysguard test to Plasma system monitor test
These were switched out in comps recently.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:20:59 -08:00
Adam Williamson
f6fa89f2cf Remove falkon, k3b, krusader, ktorrent from KDE app startstop
They have all been dropped from the spin recently. Remove all
related needles too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 15:58:37 -08:00
Adam Williamson
4758782d56 KDE apps: replace Calligra with LibreOffice
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-04 08:58:55 -08:00
Adam Williamson
4bc0ac79da Update a few more KDE app needles for newer Plasma
Missed these in the last round.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-03 18:57:51 -08:00
Adam Williamson
274a8f1b47 Update a ton of KDE app needles for UI changes
KDE changed the color of the window title background, so all
these need redoing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-26 13:54:46 -08:00
Adam Williamson
818bacfb60 Update several needles for KDE going all grimdark
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-12 12:02:05 -08:00
Adam Williamson
a038423920 Add a workaround needle for Konsole running with wrong font
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-02 14:50:59 -08:00
Adam Williamson
d8f5d3fd0b Update several KDE needles for font rendering / button changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-26 12:38:08 -07:00
Adam Williamson
92f5bf90c0 Update Krusader settings close needle
The button changed a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-08 16:22:44 -07:00
Adam Williamson
40974c2f94 Simplify Krusader app test
We don't need a separate 'welcome' needle because it just matches
on an OK button anyway. So turn that needle into an OK needle
(we don't have any existing 'blue OK button' needle) and simplify
the logic to a single loop for kde_ok and krusader_settings_close.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-08 14:47:46 -07:00
Adam Williamson
36fd4c10b1 Correct tag for new kde_ok needle
It had krusader_settings_close as its tag, not kde_ok. That's
why the krusader test module was failing weirdly.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 14:39:08 -07:00
Lukáš Růžička
b5a7b49f6e Correct the misconfigured needle from the previous commit and add a proper one. 2020-10-01 12:42:56 +02:00
Lukáš Růžička
3986984eb3 Fix needles for Krusader and Notifications. 2020-09-30 09:08:20 +02:00
Adam Williamson
3e5e1104b7 Update a bunch of KDE needles for Rawhide font change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-27 15:06:09 -07:00
Lukáš Růžička
f3d6a9574c Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.

While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.

So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-04-17 17:27:04 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Lukáš Růžička
a54f020118 Revert "Fix the Konqueror test - handle Locations dialogue."
This reverts commit d784bf54ca.

It turned out that Locations are not connected to Konqueror
at all. The reason why the test is failing is that the
application has been removed to limit the number of
web browsers.
2020-03-31 09:23:13 +02:00
Lukáš Růžička
d784bf54ca Fix the Konqueror test - handle Locations dialogue. 2020-03-26 10:57:00 +01:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Adam Williamson
5c03c435ca Stop having two 'firefox close tabs' needle tags, drop old ones
We still have a 'apps_run_firefox_stop' needle tag which is for
the same thing as 'firefox_close_tabs'. That's dumb. Get rid of
it and only have the firefox_close_tabs tag and needles. Also
clean up some old firefox_close_tabs needles that haven't matched
for months and all the 'apps_run_firefox_stop' needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-29 12:10:35 -08:00
Adam Williamson
25cce2361c Update a KDE app test needle
Window title changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-22 09:13:27 -08:00
Adam Williamson
205c0c3d97 Add new variant ABRT needle for KDE app test
Font rendering changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-10 12:09:41 -07:00
Lukas Ruzicka
022865ab9f KDE app start/stop: launch apps with commands not menus
This is doing slightly less to exercise the launcher menus and see
whether icons appear or disappear, but it's much faster and more
reliable. We do still use menu launch for one app, just to check
the mechanism works in general.
2019-08-23 12:41:49 -07:00
Adam Williamson
ecfc9a5234 Add new variant abrt_runs needle for KDE app tests
Text rendering changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 10:44:25 -07:00
Adam Williamson
b31422d188 Add some new KDE app test needle variants
Underlines on button text seem to have moved.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-30 15:43:42 -07:00
Adam Williamson
de4a58438b Use existing needle for dismissing KDE update notification
@lruzicka added this to the KDE app tests in 71c4e273, but there
was no need for a new needle as I'd already done the same thing
in the desktop updates tests; let's just use the same needle.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-03 08:39:01 -07:00
Lukas Ruzicka
71c4e273ef Click off updates notification if it appears. 2019-07-03 10:52:47 +02:00
Adam Williamson
47bf561712 Update some KDE app launch icons
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-06-11 17:14:46 -07:00
Adam Williamson
8b353a216a Update some KDE app test needles for icon and font changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-05-30 14:40:32 -07:00
Lukas Ruzicka
cc650ed195 Add needle to fix Mediawriter test. 2019-05-03 11:09:56 +02:00
Lukas Ruzicka
ddddc9d8eb Recreate needles to make Games working. 2019-05-02 17:35:31 +02:00
Adam Williamson
382f815110 Update KDE menu_games needle for icon change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-04-17 10:59:13 -07:00
Lukas Ruzicka
99f93945b3 Change KDE desktop background at start of KDE app test
Since the KDE menus have transparency set, any time the wallpaper
changes the menus will look different, and the app tests may
fail. This sets the desktop wallpaper to black at the start of
the test suite to avoid this problem.
2019-04-09 08:57:43 -07:00
Lukas Ruzicka
f9201fb7d8 Fix kmail and kontakt tests
Fix to pass kontakt tests properly.
2019-03-27 18:00:05 +01:00