sig_core/toolkit
sig_core/toolkit
7
2
Fork 3
Code Issues 6 Pull Requests 2 Actions Projects Releases Wiki Activity

fresh-empanadas - Bug fixes #20

Open
kemotaha wants to merge 16 commits from kemotaha/toolkit:fresh-empanadas into fresh-empanadas
pull from: kemotaha/toolkit:fresh-empanadas
merge into: sig_core:fresh-empanadas
Conversation 2 Commits 16 Files Changed 22 +1217 -479
kemotaha commented 2024-10-07 21:27:50 +00:00
First-time contributor
Copy Link

Bug fixes to empanadas

Bug fixes to empanadas
kemotaha added 4 commits 2024-10-07 21:27:53 +00:00
kemotaha changed title from fresh-empanadas to fresh-empanadas - Bug fixes 2024-10-07 21:28:13 +00:00
label commented 2024-10-07 22:17:01 +00:00
Owner
Copy Link
                podman_cmd_entry = '{} run -d -it -v "{}:{}:z" -v "{}:{}:z" -v "{}:{}:z" --name {} --entrypoint {}/{} {}'.format(

This breaks scenarios where the compose dir (and by extension, the entries dir) is in an NFS mount. Our compose data is in NFS, This change would break our workflow.

Please consider using this change instead to see if this fixes your workflow. This prevents context changes.

This will require the fresh-empanadas branch to rebase against devel.

``` podman_cmd_entry = '{} run -d -it -v "{}:{}:z" -v "{}:{}:z" -v "{}:{}:z" --name {} --entrypoint {}/{} {}'.format( ``` This breaks scenarios where the compose dir (and by extension, the entries dir) is in an NFS mount. Our compose data is in NFS, This change would break our workflow. Please consider using [this change](https://git.resf.org/sig_core/toolkit/commit/08d899534443e1bd4c09728d6dd12f205c47e868) instead to see if this fixes your workflow. This prevents context changes. This will require the `fresh-empanadas` branch to rebase against devel.
kemotaha added 1 commit 2024-10-08 20:45:30 +00:00
kemotaha commented 2024-10-08 20:46:28 +00:00
Author
First-time contributor
Copy Link

Looks like it worked. I updated the pull request to include that change over the other one I made.

Looks like it worked. I updated the pull request to include that change over the other one I made.
This pull request has changes conflicting with the target branch.
  • iso/empanadas/empanadas/util/shared.py
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fresh-empanadas:kemotaha-fresh-empanadas
git checkout kemotaha-fresh-empanadas
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sig_core/toolkit#20
No description provided.
Delete Branch "kemotaha/toolkit:fresh-empanadas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?