Commit Graph

1877 Commits

Author SHA1 Message Date
Adam Williamson
0b45cd4adc Try and clean up desktop update needles a bit
The 'desktop_pacakge_tool_update-kde-detected' needles and
'desktop_update_notification_systray-kde' needles are actually
matching on exactly the same thing, so drop the redundancy. We
need to have the desktop_package_tool_update tag on the older
(F33) version of this needle because on F33 we click on it to
launch the update tool in the desktop_update_graphical test; from
F34 onwards this is *not* what we want to do so the needle should
not have that tag to avoid throwing the test off. When F33 goes
EOL we can drop that tag from the needle and simplify the
destop_update_graphical test. Also add a needle for the Discover
app's 'update' icon when no updates are found.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-14 12:32:27 -07:00
Adam Williamson
c28785afec Add F33 KDE variant Firefox 89 needles
KDE on F33 uses a different font, so needs its own needles...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-10 14:13:32 -07:00
Lukáš Růžička
9fdc63d4e2 Delete needles reported as unused by the check_needles script. 2021-06-10 12:13:41 +02:00
Adam Williamson
2f73b7302b Add another Firefox 'close tabs' needle
Not sure why. Some font difference in different tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 16:36:52 -07:00
Adam Williamson
2961a06dbd Update cockpit auto-updates needle
Radio button style change.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 16:36:20 -07:00
Adam Williamson
4fd395ff74 Update KDE Spectacle app runs needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 15:40:53 -07:00
Adam Williamson
bb9eb7d60e Update Firefox close tabs needle for GNOME
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 15:40:14 -07:00
Adam Williamson
5a9a65bb5b Remove juk and kget from KDE app tests
They were removed from comps in c4d9287.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 15:18:02 -07:00
Adam Williamson
3b4d0aa00b Revert "Prevent the Konqueror test from running on F32 and later."
This reverts commit 603ee871c1. We
are well past F32 at this point so it's not longer needed. Just
wipe the test entirely instead.
2021-06-08 15:17:25 -07:00
Adam Williamson
59fbfcaa91 Update Firefox needles for new version
They did a UI refresh, it seems.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 11:36:49 -07:00
Adam Williamson
fcf96f73b7 Tweak Blivet LVM device type needles
There's some cheating/sloppiness going on here, with the same tag
and sometimes same needle being used to match "LVM2 Volume Group"
and "LVM2 Logical Volume". Today this caused us to pick the thin
pool entry instead in a test, so let's just clean this up and do
it right, with separate needles for matching each thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-07 18:16:46 -07:00
Adam Williamson
b231f87417 desktop_printing: adjust for cups-pdf output filename change
A recent cups-pdf build changed the default filename for files
output by cups-pdf. We need to have the test look for the
correct filename based on the cups-pdf version.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-04 13:51:24 -07:00
Adam Williamson
6c52a1c1dd Update Konsole runs needle, maximize Konsole in desktop_terminal
The needle match seems to have changed when bug #1957858 showed
up, but it's actually just a text rendering change in the window
title, it's not exactly caused by the tiny window. So not marking
as a workaround needle.

Maximizing the window makes the test work faster when we hit that
bug, as type_safely needs to be able to see the results of its
typing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-02 11:07:49 -07:00
Adam Williamson
0b55fda6f5 Update copyright statements to current RH recommendations
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-01 13:31:56 -07:00
Adam Williamson
f91b21dec9 anaconda_help: try a wait_still_screen after install_destination
Still hitting a fail sometimes on the spoke after Installation
Destination, when anaconda is still sorting things out and the
test tries to do stuff too fast. e.g.
https://openqa.stg.fedoraproject.org/tests/1206252 . See if this
helps.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-31 16:17:09 -07:00
Adam Williamson
2583f18c05 anaconda_help: check for screen change when entering spoke
Otherwise if it lags a bit we might try and click the Help!
button on the hub, and if that happens before anaconda has caught
up, we won't open Help at all.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-31 16:17:09 -07:00
Adam Williamson
45381f33ff anaconda_help: change the check for root password creation
Seems silly to wait 120 seconds when we know what the criteria
are. GNOME installs, can't do this; others, we have to.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-31 16:17:09 -07:00
Adam Williamson
3364732110 anaconda_help: tweak nonlive needle handling, add waits, tabs
Some fixups for anaconda_help. Two runs of it failed today around
handoff from the root password screen to the install progress
screen; add a couple of wait_still_screens there to make it
safer. Drop the added nonlive needles, because they're too
permissive, causing problems for other tests (they're matching
before they should); instead we solve the problem of spokes being
highlighted by just pressing shift-tab a few times. And fix some
tabs to be spaces.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-31 16:17:06 -07:00
Adam Williamson
5d4cf014a2 Add a wait_still_screen to desktop_update_graphical for safety
Had some repeated failures where there's kind of a race between
Software doing some kind of auto-refresh and the test clicking
on stuff. This seems to help.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-28 15:04:37 -07:00
Lukáš Růžička
c6d443a20f Automate the QA:Testcase_Anaconda_help.
This PR automates the mentioned testcase to test that Help can be
displayed in Anaconda during the installation. It navigates through
the available Help screens and if it can see it, it finishes.

This test runs after `install_default_upload` to override the
installation defaults defined for all primary tests.

Delete a duplicated needle.

Reformat list extensions to make it nicer.

Get rid of wrong export and an empty line.

Delete empty line.

Use _boot_to_anaconda for booting and move subroutine accordingly.

Add variable to templates.fif.json

Delete trailing whitespace.

Fix calling the pretest.

Move help checking to another place.
2021-05-27 21:39:26 +00:00
Adam Williamson
f475156eff Fix cockpit version check
There's a 244.1. D'oh.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-27 08:56:58 -07:00
Adam Williamson
f38dc4cfe1 realmd_join_cockpit: only hit tab twice for Cockpit 245+
Since 232, there's been a bug where we need to hit tab three
times to get into the first field in the "Join domain" dialog.
In 245, it's down to two times, for some reason. So, handle
that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-26 17:46:04 -07:00
Adam Williamson
c8004201ae Update check_install_source checks for anaconda changes
Since f33b50e, anaconda doesn't log "enabled repo:" any more. To
ensure the repo actually is enabled we need to check some other
lines. Good news is, we don't need the 'anaconda'|'' dodge any
more, so we can drop that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-25 18:04:06 -07:00
Adam Williamson
4a11af9958 Revert "Wait a bit longer from software selection back to main hub"
This reverts commit 90cc65b2fa.
There does not seem to be such a long delay any more, so let's
drop the time.
2021-05-25 15:10:06 -07:00
Adam Williamson
592f50d3c2 Fix Cloud tests to run on correct image
For Cloud, we want to run these tests directly on the disk image
from the compose. But for other flavors, they are run on a disk
image produced by install_default_upload, so the test suites
specify HDD_1. This causes a problem as the value from the test
suite is used as the filename when downloading the image, but
that file name does not change between composes, so instead of
downloading the image to be tested for each compose, we just
wound up downloading it one time and then re-using that same
file every day.

Solving this is a bit tricky for reasons explained in the
fedora_openqa commit, but this is the best option I could think
of. The scheduler has been changed to schedule the downloaded
image as HDD_2_URL, not HDD_1_URL; so now in the templates we just
override the HDD_1 value for the Cloud flavors to "%HDD_2%",
meaning to take the value of HDD_2 (which will be parsed from
HDD_2_URL). We do not actually attach HDD_2 at all, it's only
used to be copied to HDD_1.

We also explicitly set DEPLOY_UPLOAD_TEST to "" for all flavors
(it was only set for one before), just for clarity.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-20 13:15:34 -07:00
Adam Williamson
5b15979f54 Update KDE system-settings runs needle (some font change)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-19 12:09:09 -07:00
Adam Williamson
1b28976f49 Update several GNOME app test needles
Not sure why these changed, but oh well. Utilities menu was
highlighted in a test run for some reason, so let's just handle
that. Other needles changed very slightly.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-14 14:26:10 -07:00
Adam Williamson
875a817977 Drop Boxes/Connections needles for now
We're not using them, so they fail the unused needles check. We
can just revert this commit when we want them back.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-14 12:53:49 -07:00
Adam Williamson
65eef45cda Update Firefox addon_add needle, icon on button disappeared
I think this is in upstream page source, not on our end.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-13 18:08:59 -07:00
Adam Williamson
143f553ec4 Update kparted-runs needle
Font rendering changed slightly, dunno why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-10 15:52:56 -07:00
Adam Williamson
8dc1bc7a8a Update leftbar generic needle, add rhbz#1959160 workaround
The background color of the generic left bar needle has changed
to match the new logo base color. The top bar's background color
has similarly changed, but this also caused us to notice a bug
in fedora-logos - that topbar image file seems to be basically
empty (just a transparent rectangle) so we see no 'image' in the
top bar, just solid electric blue. This needle matches that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-10 13:57:38 -07:00
Adam Williamson
f5377ad1d2 Tweak _vnc_client_connect to click things better
vinagre likes to make things move around and pop up in awkward
ways...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-07 09:47:35 -07:00
Adam Williamson
35660bb4ed Use Vinagre instead of Boxes as VNC client, prepare Connections
Boxes dropped VNC functionality. It's supposed to be replaced by
Connections, but we can't use that until it has fullscreen:
https://gitlab.gnome.org/GNOME/connections/-/issues/5
so use Vinagre for now. We do also prepare some needles for
Connections in anticipation of being able to use it later (since
I already did the work and don't want to waste it...)

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-06 16:28:49 -07:00
Adam Williamson
a4867ebe76 desktop_login: use esc not alt-f4 to dismiss menu on KDE
alt-f4 makes sense for an app (Terminal on GNOME) but not really
for closing the system menu (KDE). It seems like it worked till
a day or two back then broke, but I think just using Esc instead
rather than filing a bug is the best plan, I'm not sure I'd
*expect* alt-f4 to work for this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-06 09:52:13 -07:00
Adam Williamson
c9609cf26d Drop bypass_1691487 function and usage (bug seems fixed)
Per https://bugzilla.redhat.com/show_bug.cgi?id=1691487#c14 it
seems like the bug here got fixed along the way and we probably
don't need this any more.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-06 09:02:52 -07:00
Adam Williamson
4691928c2f Enhance _software_selection environment check for anaconda change
anaconda changed how this log line looks (again); update the
check to handle old and new styles for now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-06 09:00:28 -07:00
Tomas Popela
055662fe36 Mark qt as unwanted package 2021-05-04 15:34:14 +00:00
Adam Williamson
93628ed230 Tweak desktop_login test for GNOME after wrong password entry
It doesn't seem to return to the top level automatically any more,
though the message goes away after a short time, still.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 15:54:41 -07:00
Adam Williamson
b1e28d4e77 Update Cockpit log entry detail needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 15:04:02 -07:00
Adam Williamson
28b1126c95 Update Japanese install_done-reboot needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 15:03:12 -07:00
Adam Williamson
f73ff0968c Update KDE addon install Firefox needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 15:02:05 -07:00
Adam Williamson
2b02253ecb Fix modularity test to use Rawhide repo on Rawhide
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 13:55:43 -07:00
Lukáš Růžička
114610bf90 Rewrite Modularity tests to use Perl only.
The Modularity tests rely on an external script to test the modular
behaviour of DNF. There is a potentional risk that the connection
is be down and the script cannot be downloaded.

This enhancement uses a regular OpenQA perl test case script to only
invoke DNF commands and parse their output to test the same behaviour
that we have been testing already.

This enhancement picks a random module for each of the operations,
and thus tries to mimick reality a little bit more.
2021-05-03 19:13:09 +00:00
Adam Williamson
6c5507b174 Add an 'unwanted packages' test, run on Workstation for now (#218)
This adds a test that just fails if any one of a given list of
unwanted packages is installed. This was a request for the
Workstation edition from @catanzaro so I've just implemented it
for Workstation so far, but it's designed to be easily extended
to cover other subvariants too if we want.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 08:59:46 -07:00
Lukáš Růžička
477d918b64 Add testcase to test the Package_install_remove testcase. 2021-05-01 00:11:43 +02:00
Adam Williamson
1a613fc8c2 Restore the cockput updated "Reboot" needle
OK, so sometimes we have a Reboot button, sometimes a Restart
button, sometimes both, but never *always* one or the other. So
we need both needles. Sigh.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-30 14:37:35 -07:00
Adam Williamson
92d17499c0 Update Firefox close tabs needles for font changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-30 11:34:19 -07:00
Adam Williamson
b4f3e6ea5a Move install_blivet_resize_lvm, fix install_resize_lvm (#201)
This is the same thing we did for install_resize_lvm, to address
issue #201. We just didn't get around to doing it for the blivet
test yet. We also change the HDDSIZEGB for the parent test to
15GB so the resizing stuff actually works in both resize tests;
ever since we changed this the install_resize_lvm test has not
been working properly, it hasn't actually been doing any resize.
Also drop the swap partition stuff from that test as it's for
sure no longer needed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-30 11:10:21 -07:00
Adam Williamson
87a2477c31 Update KDE live installer needle for new logo
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-29 15:34:06 -07:00
Adam Williamson
efe793a465 Update some Cockpit needles for cockpit 243
There's a spurious warning on the Updates page, but we don't
want to fail tests for non-related updates on that, and I've
already reported it so it should get fixed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-29 15:32:37 -07:00