New topbar and leftbar needles #120

2022-07-06T19:05:17Z

akatch commented

2022-07-06 19:05:17 +00:00

(Migrated from github.com)

Description

This PR adds topbar and leftbar needles for RC2.

Related to #103

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-9.0-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ ip=dhcp"

Installation should complete against 9.0 RC2. We will still see some failures in postinstall, which should be resolved with #119 .

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

# Description This PR adds topbar and leftbar needles for RC2. Related to #103 # How Has This Been Tested? ``` openqa-cli api -X POST isos ISO=Rocky-9.0-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ ip=dhcp" ``` Installation should complete against 9.0 RC2. We will still see some failures in postinstall, which should be resolved with #119 . # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] Any dependent changes have been merged and published in downstream modules

lumarel (Migrated from github.com) requested changes 2022-07-06 19:52:35 +00:00

needles/anaconda/identification/rocky-topbar_generic-20220706.json

lumarel (Migrated from github.com) commented

2022-07-06 19:52:29 +00:00

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}

If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```