[BUG] Needle in PR #66 breaks minimal install when GRUB="ip=dhcp" is not set #68

New Issue

2021-12-04T22:02:12Z

tcooper commented

2021-12-04 22:02:12 +00:00

(Migrated from github.com)

Describe the bug
The needle added in #66 to resolve _boot_to_anaconda issue in text install is not specific enough and also matches when using dvd-iso with a server based install and no network connection is required. In that case the test passes until the final stage where network access is required for _collect_data. Without network enabled _collect_data is a hard failure.

To Reproduce
Steps to reproduce the behavior:

Clone repo and/or update latest devel branch to include #66
POST the standard minimal case
Installation will succeed but _collect_data will fail with no network access to upload results to openQA.

Expected behavior
Network interface should ALWAYS be enabled and minimal test should complete regardless of whether a GRUB=... variable is configured to preset the network interface connection (or not).

Desktop (please complete the following information):

OS: Fedora 34 Server with openQA
Browser: Chrome 96.0.4664.5
Version: This repo at 33dd37f

Additional context
It appears only a fix to the needle to make it more specific is required and additional logic in _anaconda_network_enable.pm is not required.

**Describe the bug** The needle added in #66 to resolve `_boot_to_anaconda` issue in text install is not specific enough and also matches when using `dvd-iso` with a server based install and no network connection is required. In that case the test passes until the final stage where network access is required for `_collect_data`. Without network enabled `_collect_data` is a hard failure. **To Reproduce** Steps to reproduce the behavior: 1. Clone repo and/or update latest `devel` branch to include #66 2. POST the standard `minimal` case 3. Installation will succeed but `_collect_data` will fail with no network access to upload results to openQA. **Expected behavior** Network interface should ALWAYS be enabled and minimal test should complete regardless of whether a `GRUB=...` variable is configured to preset the network interface connection (or not). **Desktop (please complete the following information):** - OS: Fedora 34 Server with openQA - Browser: Chrome 96.0.4664.5 - Version: This repo at [33dd37f](https://github.com/rocky-linux/os-autoinst-distri-rocky/commit/33dd37fdea09e9b1e6ca297e79f4fdca46436b7d) **Additional context** It appears only a fix to the needle to make it more specific is required and additional logic in `_anaconda_network_enable.pm` is not required.

Sign in to join this conversation.