testing/os-autoinst-distri-rocky-migrated
10
0
Fork 0
Code Issues 12 Pull Requests 1 Packages Projects Releases Wiki Activity

Correct needle to properly detect network connected #69

Merged
tcooper merged 1 commits from issue_68 into develop 2021-12-10 00:11:18 +00:00
Conversation 3 Commits 1 Files Changed 1 +1 -1
tcooper commented 2021-12-05 04:27:58 +00:00 (Migrated from github.com)
Copy Link

Description

This PR fixes #68 to allow needle match when network is connected before entering Network spoke and when network is not required for install for minimal-iso and dvd-iso flavors.

Before this change needle would also match if network was not connected but not required (ie. minimal-iso or dvd-iso).

NOTE: Perhaps the smallest fix yet... 32 pixels... but hours wasted.

How Has This Been Tested?

$ openqa-cli api -X POST isos \
    ISO=Rocky-8.5-x86_64-minimal.iso \
    ARCH=x86_64 DISTRI=rocky \
    FLAVOR=minimal-iso \
    VERSION=8.5 \
    BUILD=$(date +%Y%m%d.%H%M%S).0 \
    GRUB="ip=dhcp"
    
$ openqa-cli api -X POST isos \
    ISO=Rocky-8.5-x86_64-minimal.iso \
    ARCH=x86_64 \
    DISTRI=rocky \
    FLAVOR=minimal-iso \
    VERSION=8.5 \
    BUILD=$(date +%Y%m%d.%H%M%S).0
    
$ openqa-cli api -X POST isos \
    ISO=Rocky-8.5-x86_64-dvd1.iso \
    ARCH=x86_64 \
    DISTRI=rocky \
    FLAVOR=dvd-iso \
    VERSION=8.5 \
    BUILD=$(date +%Y%m%d.%H%M%S).0 \
    GRUB="ip=dhcp" \
    TEST=install_lvm_ext4 \
    PACKAGE_SET=server
    
$ openqa-cli api -X POST isos \
    ISO=Rocky-8.5-x86_64-dvd1.iso \
    ARCH=x86_64 \
    DISTRI=rocky \
    FLAVOR=dvd-iso \
    VERSION=8.5 \
    BUILD=$(date +%Y%m%d.%H%M%S).0 \
    TEST=install_lvm_ext4 \
    PACKAGE_SET=server

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation where required
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
### Description This PR fixes #68 to allow needle match when network is connected before entering Network spoke and when network is not required for install for `minimal-iso` and `dvd-iso` flavors. Before this change needle would also match if network was not connected but _not_ required (ie. `minimal-iso` or `dvd-iso`). _NOTE: Perhaps the smallest fix yet... 32 pixels... but **hours** wasted._ ### How Has This Been Tested? ```sh $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-minimal.iso \ ARCH=x86_64 DISTRI=rocky \ FLAVOR=minimal-iso \ VERSION=8.5 \ BUILD=$(date +%Y%m%d.%H%M%S).0 \ GRUB="ip=dhcp" $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-minimal.iso \ ARCH=x86_64 \ DISTRI=rocky \ FLAVOR=minimal-iso \ VERSION=8.5 \ BUILD=$(date +%Y%m%d.%H%M%S).0 $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-dvd1.iso \ ARCH=x86_64 \ DISTRI=rocky \ FLAVOR=dvd-iso \ VERSION=8.5 \ BUILD=$(date +%Y%m%d.%H%M%S).0 \ GRUB="ip=dhcp" \ TEST=install_lvm_ext4 \ PACKAGE_SET=server $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-dvd1.iso \ ARCH=x86_64 \ DISTRI=rocky \ FLAVOR=dvd-iso \ VERSION=8.5 \ BUILD=$(date +%Y%m%d.%H%M%S).0 \ TEST=install_lvm_ext4 \ PACKAGE_SET=server ``` ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation where required - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules
StackKorora (Migrated from github.com) reviewed 2021-12-05 04:27:58 +00:00
lumarel (Migrated from github.com) reviewed 2021-12-05 04:27:58 +00:00
akatch commented 2021-12-05 07:10:33 +00:00 (Migrated from github.com)
Copy Link

PR looks good. On my first pass I encountered one failure which I believe is an environmental performance thing. I'm rerunning to be sure. Here's my initial test report:

Build8.5_minimal-iso_20211205.001108.0

$ openqa-cli api -X POST isos \
	ISO=Rocky-8.5-x86_64-minimal.iso \
	ARCH=x86_64 DISTRI=rocky \
	FLAVOR=minimal-iso \
	VERSION=8.5 \
	BUILD=8.5_minimal-iso_$(date +%Y%m%d.%H%M%S).0 \
	GRUB="ip=dhcp"
Test Result Failure Reason Effort to Fix Notes
install_minimal@64bit passed
install_minimal_upload@64bit passed

Build8.5_minimal-iso_20211205.001216.0

$ openqa-cli api -X POST isos \
	ISO=Rocky-8.5-x86_64-minimal.iso \
	ARCH=x86_64 \
	DISTRI=rocky \
	FLAVOR=minimal-iso \
	VERSION=8.5 \
	BUILD=8.5_minimal-iso_$(date +%Y%m%d.%H%M%S).0
Test Result Failure Reason Effort to Fix Notes
install_minimal@64bit passed
install_minimal_upload@64bit failed Failed to match "anaconda_install_done" needle, because the installation took longer than expected. I'm rerunning this one, believe it's a non-blocking failure.

Build8.5_dvd-iso_20211205.001335.0

$ openqa-cli api -X POST isos \
	ISO=Rocky-8.5-x86_64-dvd1.iso \
	ARCH=x86_64 \
	DISTRI=rocky \
	FLAVOR=dvd-iso \
	VERSION=8.5 \
	BUILD=8.5_dvd-iso_$(date +%Y%m%d.%H%M%S).0 \
	GRUB="ip=dhcp" \
	TEST=install_lvm_ext4 \
	PACKAGE_SET=server
Test Result Failure Reason Effort to Fix Notes
install_lvm_ext4@64bit softfailed AVCs found: audit(1638686232.075:74): avc: denied { getattr } for pid=1082 comm="login" name="/" dev="tmpfs"
install_lvm_ext4@uefi softfailed AVCs found: audit(1638686256.063:74): avc: denied { getattr } for pid=1089 comm="login" name="/" dev="tmpfs"

Build8.5_dvd-iso_20211205.001342.0

$ openqa-cli api -X POST isos \
	ISO=Rocky-8.5-x86_64-dvd1.iso \
	ARCH=x86_64 \
	DISTRI=rocky \
	FLAVOR=dvd-iso \
	VERSION=8.5 \
	BUILD=8.5_dvd-iso_$(date +%Y%m%d.%H%M%S).0 \
	TEST=install_lvm_ext4 \
	PACKAGE_SET=server
Test Result Failure Reason Effort to Fix Notes
install_lvm_ext4@64bit softfailed AVCs found: audit(1638687101.493:74): avc: denied { getattr } for pid=1091 comm="login" name="/" dev="tmpfs"
install_lvm_ext4@uefi softfailed AVCs found: audit(1638687150.002:74): avc: denied { getattr } for pid=1095 comm="login" name="/" dev="tmpfs"
PR looks good. On my first pass I encountered one failure which I believe is an environmental performance thing. I'm rerunning to be sure. Here's my initial test report: # Build8.5_minimal-iso_20211205.001108.0 $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-minimal.iso \ ARCH=x86_64 DISTRI=rocky \ FLAVOR=minimal-iso \ VERSION=8.5 \ BUILD=8.5_minimal-iso_$(date +%Y%m%d.%H%M%S).0 \ GRUB="ip=dhcp" | Test | Result | Failure Reason | Effort to Fix | Notes | | ---- | ------ | -------------- | ------------- | ----- | | install_minimal@64bit | passed | | | | | install_minimal_upload@64bit | passed | | | | # Build8.5_minimal-iso_20211205.001216.0 $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-minimal.iso \ ARCH=x86_64 \ DISTRI=rocky \ FLAVOR=minimal-iso \ VERSION=8.5 \ BUILD=8.5_minimal-iso_$(date +%Y%m%d.%H%M%S).0 | Test | Result | Failure Reason | Effort to Fix | Notes | | ---- | ------ | -------------- | ------------- | ----- | | install_minimal@64bit | passed | | | | | install_minimal_upload@64bit | failed | Failed to match "anaconda_install_done" needle, because the installation took longer than expected. I'm rerunning this one, believe it's a non-blocking failure. | | | # Build8.5_dvd-iso_20211205.001335.0 $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-dvd1.iso \ ARCH=x86_64 \ DISTRI=rocky \ FLAVOR=dvd-iso \ VERSION=8.5 \ BUILD=8.5_dvd-iso_$(date +%Y%m%d.%H%M%S).0 \ GRUB="ip=dhcp" \ TEST=install_lvm_ext4 \ PACKAGE_SET=server | Test | Result | Failure Reason | Effort to Fix | Notes | | ---- | ------ | -------------- | ------------- | ----- | | install_lvm_ext4@64bit | softfailed | AVCs found: `audit(1638686232.075:74): avc: denied { getattr } for pid=1082 comm="login" name="/" dev="tmpfs"` | | | | install_lvm_ext4@uefi | softfailed | AVCs found: `audit(1638686256.063:74): avc: denied { getattr } for pid=1089 comm="login" name="/" dev="tmpfs"`| | | # Build8.5_dvd-iso_20211205.001342.0 $ openqa-cli api -X POST isos \ ISO=Rocky-8.5-x86_64-dvd1.iso \ ARCH=x86_64 \ DISTRI=rocky \ FLAVOR=dvd-iso \ VERSION=8.5 \ BUILD=8.5_dvd-iso_$(date +%Y%m%d.%H%M%S).0 \ TEST=install_lvm_ext4 \ PACKAGE_SET=server | Test | Result | Failure Reason | Effort to Fix | Notes | | ---- | ------ | -------------- | ------------- | ----- | | install_lvm_ext4@64bit | softfailed | AVCs found: `audit(1638687101.493:74): avc: denied { getattr } for pid=1091 comm="login" name="/" dev="tmpfs"`| | | | install_lvm_ext4@uefi | softfailed | AVCs found: `audit(1638687150.002:74): avc: denied { getattr } for pid=1095 comm="login" name="/" dev="tmpfs"` | | |
akatch (Migrated from github.com) approved these changes 2021-12-05 15:44:52 +00:00
akatch (Migrated from github.com) left a comment
Copy Link

The one failure I got in my first run passed on a rerun. I think I need to find and increase the timeout, since I keep running into this. Anyways, looks good to me.

The one failure I got in my first run passed on a rerun. I think I need to find and increase the timeout, since I keep running into this. Anyways, looks good to me.
tcooper commented 2021-12-06 00:09:39 +00:00 (Migrated from github.com)
Copy Link

The one failure I got in my first run passed on a rerun. I think I need to find and increase the timeout, since I keep running into this. Anyways, looks good to me.

I have a couple of standard changes that I make that generally takes care of these.

➜  os-autoinst-distri-rocky git:(install_destination) ✗ git --no-pager diff
diff --git a/tests/_do_install_and_reboot.pm b/tests/_do_install_and_reboot.pm
index af2d6225..03105f65 100644
--- a/tests/_do_install_and_reboot.pm
+++ b/tests/_do_install_and_reboot.pm
@@ -112,8 +112,8 @@ sub run {
     # we're on a debug kernel, debug kernel installs are really slow.
     my $timeout = 1800;
     my $version = lc(get_var('VERSION'));
-    if ($version eq "rawhide") {
-        $timeout = 2400;
+    if ($version eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") {
+        $timeout = 4800;
     }
     # workstation especially has an unfortunate habit of kicking in
     # the screensaver during install...
diff --git a/tests/install_text.pm b/tests/install_text.pm
index 26f015d7..f86ba721 100644
--- a/tests/install_text.pm
+++ b/tests/install_text.pm
@@ -153,7 +153,7 @@ sub run {
     # we're on a debug kernel, debug kernel installs are really slow.
     my $timeout = 1800;
     if (lc(get_var('VERSION')) eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") {
-        $timeout = 2400;
+        $timeout = 4800;
     }

     if (testapi::is_serial_terminal) {

I can add a PR with them to get them included as defaults if you want. I thought I was the only one running into them. Almost anywhere there are longer timeouts for rawhide we can add to the conditional and option for DISTRI=rocky and double the timeout.

> The one failure I got in my first run passed on a rerun. I think I need to find and increase the timeout, since I keep running into this. Anyways, looks good to me. I have a couple of standard changes that I make that generally takes care of these. ```diff ➜ os-autoinst-distri-rocky git:(install_destination) ✗ git --no-pager diff diff --git a/tests/_do_install_and_reboot.pm b/tests/_do_install_and_reboot.pm index af2d6225..03105f65 100644 --- a/tests/_do_install_and_reboot.pm +++ b/tests/_do_install_and_reboot.pm @@ -112,8 +112,8 @@ sub run { # we're on a debug kernel, debug kernel installs are really slow. my $timeout = 1800; my $version = lc(get_var('VERSION')); - if ($version eq "rawhide") { - $timeout = 2400; + if ($version eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") { + $timeout = 4800; } # workstation especially has an unfortunate habit of kicking in # the screensaver during install... diff --git a/tests/install_text.pm b/tests/install_text.pm index 26f015d7..f86ba721 100644 --- a/tests/install_text.pm +++ b/tests/install_text.pm @@ -153,7 +153,7 @@ sub run { # we're on a debug kernel, debug kernel installs are really slow. my $timeout = 1800; if (lc(get_var('VERSION')) eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") { - $timeout = 2400; + $timeout = 4800; } if (testapi::is_serial_terminal) { ``` I can add a PR with them to get them included as defaults if you want. I thought I was the only one running into them. Almost anywhere there are longer timeouts for `rawhide` we can add to the conditional and option for `DISTRI=rocky` and double the timeout.
akatch commented 2021-12-06 04:34:57 +00:00 (Migrated from github.com)
Copy Link

Perfect, that would be awesome if you could toss up a PR for adding this
to defaults. I seem to run into it only sporadically, when I've got all
my workers working at a time... but it's kind of annoying nonetheless.
On 5 Dec 16:09, Trevor Cooper wrote:

The one failure I got in my first run passed on a rerun. I think I need to find and increase the timeout, since I keep running into this. Anyways, looks good to me.

I have a couple of standard changes that I make that generally takes care of these.

➜  os-autoinst-distri-rocky git:(install_destination) ✗ git --no-pager diff
diff --git a/tests/_do_install_and_reboot.pm b/tests/_do_install_and_reboot.pm
index af2d6225..03105f65 100644
--- a/tests/_do_install_and_reboot.pm
+++ b/tests/_do_install_and_reboot.pm
@@ -112,8 +112,8 @@ sub run {
     # we're on a debug kernel, debug kernel installs are really slow.
     my $timeout = 1800;
     my $version = lc(get_var('VERSION'));
-    if ($version eq "rawhide") {
-        $timeout = 2400;
+    if ($version eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") {
+        $timeout = 4800;
     }
     # workstation especially has an unfortunate habit of kicking in
     # the screensaver during install...
diff --git a/tests/install_text.pm b/tests/install_text.pm
index 26f015d7..f86ba721 100644
--- a/tests/install_text.pm
+++ b/tests/install_text.pm
@@ -153,7 +153,7 @@ sub run {
     # we're on a debug kernel, debug kernel installs are really slow.
     my $timeout = 1800;
     if (lc(get_var('VERSION')) eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") {
-        $timeout = 2400;
+        $timeout = 4800;
     }

     if (testapi::is_serial_terminal) {

I can add a PR with them to get them included as defaults if you want. I thought I was the only one running into them. Almost anywhere there are longer timeouts for rawhide we can add to the conditional and option for DISTRI=rocky and double the timeout.

--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/69#issuecomment-986330513

Perfect, that would be awesome if you could toss up a PR for adding this to defaults. I seem to run into it only sporadically, when I've got all my workers working at a time... but it's kind of annoying nonetheless. On 5 Dec 16:09, Trevor Cooper wrote: > > The one failure I got in my first run passed on a rerun. I think I need to find and increase the timeout, since I keep running into this. Anyways, looks good to me. > > I have a couple of standard changes that I make that generally takes care of these. > > ```diff > ➜ os-autoinst-distri-rocky git:(install_destination) ✗ git --no-pager diff > diff --git a/tests/_do_install_and_reboot.pm b/tests/_do_install_and_reboot.pm > index af2d6225..03105f65 100644 > --- a/tests/_do_install_and_reboot.pm > +++ b/tests/_do_install_and_reboot.pm > @@ -112,8 +112,8 @@ sub run { > # we're on a debug kernel, debug kernel installs are really slow. > my $timeout = 1800; > my $version = lc(get_var('VERSION')); > - if ($version eq "rawhide") { > - $timeout = 2400; > + if ($version eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") { > + $timeout = 4800; > } > # workstation especially has an unfortunate habit of kicking in > # the screensaver during install... > diff --git a/tests/install_text.pm b/tests/install_text.pm > index 26f015d7..f86ba721 100644 > --- a/tests/install_text.pm > +++ b/tests/install_text.pm > @@ -153,7 +153,7 @@ sub run { > # we're on a debug kernel, debug kernel installs are really slow. > my $timeout = 1800; > if (lc(get_var('VERSION')) eq "rawhide" || lc(get_var('DISTRI')) eq "rocky") { > - $timeout = 2400; > + $timeout = 4800; > } > > if (testapi::is_serial_terminal) { > ``` > > > I can add a PR with them to get them included as defaults if you want. I thought I was the only one running into them. Almost anywhere there are longer timeouts for `rawhide` we can add to the conditional and option for `DISTRI=rocky` and double the timeout. > > -- > You are receiving this because your review was requested. > Reply to this email directly or view it on GitHub: > https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/69#issuecomment-986330513
Sign in to join this conversation.
Reviewers
No reviewers
lumarel
StackKorora
akatch
Labels
Clear labels   
priority: critical

This issue or pull request is of utmost priority

  
priority: high

This issue or pull request is of high priority

  
priority: low

This issue or pull request is of low priority

  
priority: medium

This issue or pull request is of medium priority

  
status: abandoned

This issue or pull request has been abandoned or is stale

  
status: duplicate

This issue or pull request already exists

  
status: invalid

This doesn't seem right

  
status: peer review needed

Requires at least one review in order to be merged

  
status: wontfix

This will not be worked on

  
tag: content

Additions to (or modifications of) content in the repository

  
tag: good first issue

Good for newcomers

  
tag: help wanted

Extra attention is needed

  
test suite

This issue or pull request is for test suite changes

  
type: bug

Something isn't working

  
type: documentation

Improvements or additions to documentation

  
type: enhancement

New feature or request

  
type: maintenance

To improve or continue maintenance for something

  
type: question

Further information is requested

No Label
priority: critical
priority: high
priority: low
priority: medium
status: abandoned
status: duplicate
status: invalid
status: peer review needed
status: wontfix
tag: content
tag: good first issue
tag: help wanted
test suite
type: bug
type: documentation
type: enhancement
type: maintenance
type: question
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#69
No description provided.
Delete Branch "issue_68"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?