testing/os-autoinst-distri-rocky-migrated
10
0
Fork 0
Code Issues 12 Pull Requests 1 Packages Projects Releases Wiki Activity

[9.0 Release Issues]: Skip license screen #109

Merged
akatch merged 2 commits from skip_license_screen into 9.0_release_fixes 2022-06-19 19:29:33 +00:00
Conversation 1 Commits 2 Files Changed 5 +59 -12
akatch commented 2022-06-17 15:51:01 +00:00 (Migrated from github.com)
Copy Link

Description

In 9.0, the license screen is only displayed post-login if initial-setup-gui is installed. This PR handles that scenario.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/" TEST=install_default

These tests should succeed up to the "Welcome Tour" step in _graphical_wait_login. The "Welcome Tour" is not handled as part of this PR.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
# Description In 9.0, the license screen is only displayed post-login if `initial-setup-gui` is installed. This PR handles that scenario. # How Has This Been Tested? ``` openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/" TEST=install_default ``` These tests should succeed up to the "Welcome Tour" step in `_graphical_wait_login`. The "Welcome Tour" is _not_ handled as part of this PR. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules
lumarel commented 2022-06-17 17:43:20 +00:00 (Migrated from github.com)
Copy Link

Works up to now as expected 👌🏻

Works up to now as expected 👌🏻
lumarel (Migrated from github.com) requested changes 2022-06-19 19:14:41 +00:00
tests/_graphical_wait_login.pm
@ -55,0 +54,4 @@
# As well as coming back
wait_still_screen 5, 30;
assert_screen "gdm_initial_setup_license_accepted";
assert_and_click "gdm_initial_setup_spoke_forward";
lumarel (Migrated from github.com) commented 2022-06-19 19:06:55 +00:00
Copy Link

The description above does not correspond to the actual conditional, it will work for now but not for 10.

The description above does not correspond to the actual conditional, it will work for now but not for 10.
tests/_graphical_wait_login.pm
lumarel (Migrated from github.com) commented 2022-06-19 19:14:23 +00:00
Copy Link

Maybe change to everything above incl. 9 (might be harder to implement because it's string compare right now and has to change to long number compare though), we might stick with this if too much work

Maybe change to everything above incl. 9 (might be harder to implement because it's string compare right now and has to change to long number compare though), we might stick with this if too much work
tests/_graphical_wait_login.pm
lumarel (Migrated from github.com) commented 2022-06-19 19:14:26 +00:00
Copy Link

The same as before this one

The same as before this one
lumarel (Migrated from github.com) approved these changes 2022-06-19 19:28:32 +00:00
lumarel (Migrated from github.com) left a comment
Copy Link

Looks good for me now 👌🏻

Looks good for me now 👌🏻
Sign in to join this conversation.
Reviewers
No reviewers
lumarel
Labels
Clear labels   
priority: critical

This issue or pull request is of utmost priority

  
priority: high

This issue or pull request is of high priority

  
priority: low

This issue or pull request is of low priority

  
priority: medium

This issue or pull request is of medium priority

  
status: abandoned

This issue or pull request has been abandoned or is stale

  
status: duplicate

This issue or pull request already exists

  
status: invalid

This doesn't seem right

  
status: peer review needed

Requires at least one review in order to be merged

  
status: wontfix

This will not be worked on

  
tag: content

Additions to (or modifications of) content in the repository

  
tag: good first issue

Good for newcomers

  
tag: help wanted

Extra attention is needed

  
test suite

This issue or pull request is for test suite changes

  
type: bug

Something isn't working

  
type: documentation

Improvements or additions to documentation

  
type: enhancement

New feature or request

  
type: maintenance

To improve or continue maintenance for something

  
type: question

Further information is requested

No Label
priority: critical
priority: high
priority: low
priority: medium
status: abandoned
status: duplicate
status: invalid
status: peer review needed
status: wontfix
tag: content
tag: good first issue
tag: help wanted
test suite
type: bug
type: documentation
type: enhancement
type: maintenance
type: question
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#109
No description provided.
Delete Branch "skip_license_screen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?