I once broke a bootloader needle #128

2022-07-24T12:12:07Z

lumarel commented

2022-07-24 12:12:07 +00:00

(Migrated from github.com)

Description

This PR fixes one of the bootloader needles, which I unfortunately broke while beside adding the actual needle I wanted to add. (#104)
This then fixes the rescue test.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-9.0-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.0 BUILD=-universal-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 TEST=install_rescue_encrypted

The test should fully complete.

I'm also running this through all other tests, but doesn't look to have side effects.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

# Description This PR fixes one of the bootloader needles, which I unfortunately broke while beside adding the actual needle I wanted to add. (#104) This then fixes the rescue test. # How Has This Been Tested? ``` openqa-cli api -X POST isos ISO=Rocky-9.0-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.0 BUILD=-universal-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 TEST=install_rescue_encrypted ``` The test should fully complete. I'm also running this through all other tests, but doesn't look to have side effects. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

akatch commented

2022-07-24 15:24:16 +00:00

(Migrated from github.com)

The BIOS tests passed but install_simple_encrypted@uefi failed (And then install_rescue_encrypted@uefi was skipped. Is this the expected result?

The BIOS tests passed but `install_simple_encrypted@uefi` failed (And then `install_rescue_encrypted@uefi` was skipped. Is this the expected result?

lumarel commented

2022-07-24 16:02:15 +00:00

(Migrated from github.com)

Let me check that again 🤔

lumarel commented

2022-07-24 16:21:16 +00:00

(Migrated from github.com)

Hrm... still looks good on my side 🤔

akatch commented

2022-07-25 00:37:59 +00:00

(Migrated from github.com)

I must be missing something. I'm getting failures on disk_guided_encrypted_postinstall with # Test died: no candidate needle with tag(s) 'boot_enter_passphrase' matched. It's failing at the step where the decryption passphrase should be supplied.

I must be missing something. I'm getting failures on `disk_guided_encrypted_postinstall` with `# Test died: no candidate needle with tag(s) 'boot_enter_passphrase' matched`. It's failing at the step where the decryption passphrase should be supplied.

tcooper (Migrated from github.com) approved these changes 2022-07-25 04:39:35 +00:00

tcooper (Migrated from github.com) left a comment

All four tests pass for me.