Merge branch 'develop' into 'main' #155

Merged
tcooper merged 3 commits from develop into main 2023-03-02 23:14:09 +00:00
tcooper commented 2023-02-24 17:19:44 +00:00 (Migrated from github.com)

Brings _pxe_setup selinux fix recently merged in develop into main branch.

This PR will be a candidate for openQA test triggered on open GitHub pull request as described in openQA docs.

Brings `_pxe_setup` selinux fix recently merged in `develop` into `main` branch. This PR will be a candidate for openQA test triggered on open GitHub pull request as [described in openQA docs](http://open.qa/docs/#_triggering_tests_based_on_an_any_remote_git_refspec_or_open_github_pull_request).
akatch (Migrated from github.com) reviewed 2023-02-24 17:19:44 +00:00
tcooper commented 2023-02-24 17:45:22 +00:00 (Migrated from github.com)

For those interested, this PR is being tested in openQA now via...

$ openqa-clone-custom-git-refspec https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/155 https://openqa.rockylinux.org/tests/6584
Cloning parents of rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-install_pxeboot@64bit
Cloning children of rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-support_server@64bit
Created job #6692: rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-install_pxeboot@64bit -> https://openqa.rockylinux.org/t6692
Created job #6691: rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-support_server@64bit -> https://openqa.rockylinux.org/t6691

...and now support_server get's past the issue that is fixed and on to the next problem which appears to be a network connectivity issue preventing the support_server (172.16.2.110) from uploading assets to the openQA API service...

...
[2023-02-24T17:46:03.607620Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs
[2023-02-24T17:46:03.607712Z] [debug] <<< testapi::assert_script_run(cmd="curl --form upload=\@/etc/dnsmasq.conf --form upname=_support_server-dnsmasq.conf [http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf",](http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf) fail_message="", quiet=undef, timeout=90)
[2023-02-24T17:46:03.607824Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs
[2023-02-24T17:46:03.607918Z] [debug] <<< testapi::type_string(string="curl --form upload=\@/etc/dnsmasq.conf --form upname=_support_server-dnsmasq.conf [http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf",](http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf) max_interval=250, wait_screen_change=0, wait_still_screen=0, timeout=30, similarity_level=47)
[2023-02-24T17:46:08.724593Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs
[2023-02-24T17:46:08.725101Z] [debug] <<< testapi::type_string(string="; echo kUYc2-\$?- > /dev/ttyS0\n", max_interval=250, wait_screen_change=0, wait_still_screen=0, timeout=30, similarity_level=47)
[2023-02-24T17:46:09.853213Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs
[2023-02-24T17:46:09.853699Z] [debug] <<< testapi::wait_serial(buffer_size=undef, timeout=90, record_output=undef, expect_not_found=0, quiet=undef, no_regex=0, regexp=qr/kUYc2-\d+-/u)
[2023-02-24T17:48:22.090408Z] [debug] >>> testapi::wait_serial: (?^u:kUYc2-\d+-): ok
[2023-02-24T17:48:22.192704Z] [info] ::: basetest::runtest: # Test died: command 'curl --form upload=@/etc/dnsmasq.conf --form upname=_support_server-dnsmasq.conf http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf' failed at /var/lib/openqa/pool/9/os-autoinst-distri-rocky/tests/_support_server.pm line 59.
  
[2023-02-24T17:48:22.196894Z] [debug] lib/installedtest.pm:36 called testapi::check_screen
[2023-02-24T17:48:22.197301Z] [debug] <<< testapi::check_screen(mustmatch=[
    "emergency_rescue",
    "emergency_rescue_nopassword"
  ], timeout=3)
...

Test links in openQA...

support_server - https://openqa.rockylinux.org/tests/6691
install_pxeboot - https://openqa.rockylinux.org/tests/6692

From this analysis I think it's fine to merge this PR as it fixes what is intended.

For those interested, this PR is being tested in openQA **now** via... ``` $ openqa-clone-custom-git-refspec https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/155 https://openqa.rockylinux.org/tests/6584 Cloning parents of rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-install_pxeboot@64bit Cloning children of rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-support_server@64bit Created job #6692: rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-install_pxeboot@64bit -> https://openqa.rockylinux.org/t6692 Created job #6691: rocky-9.1-universal-x86_64-Build20230224-Rocky-9.1-x86_64.0-support_server@64bit -> https://openqa.rockylinux.org/t6691 ``` ...and now [`support_server` get's past the issue that is fixed](https://openqa.rockylinux.org/tests/6691#step/_support_server/29) and on to the next problem which appears to be a network connectivity issue preventing the support_server (172.16.2.110) from uploading assets to the openQA API service... ``` ... [2023-02-24T17:46:03.607620Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs [2023-02-24T17:46:03.607712Z] [debug] <<< testapi::assert_script_run(cmd="curl --form upload=\@/etc/dnsmasq.conf --form upname=_support_server-dnsmasq.conf [http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf",](http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf) fail_message="", quiet=undef, timeout=90) [2023-02-24T17:46:03.607824Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs [2023-02-24T17:46:03.607918Z] [debug] <<< testapi::type_string(string="curl --form upload=\@/etc/dnsmasq.conf --form upname=_support_server-dnsmasq.conf [http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf",](http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf) max_interval=250, wait_screen_change=0, wait_still_screen=0, timeout=30, similarity_level=47) [2023-02-24T17:46:08.724593Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs [2023-02-24T17:46:08.725101Z] [debug] <<< testapi::type_string(string="; echo kUYc2-\$?- > /dev/ttyS0\n", max_interval=250, wait_screen_change=0, wait_still_screen=0, timeout=30, similarity_level=47) [2023-02-24T17:46:09.853213Z] [debug] tests/_support_server.pm:123 called _support_server::_pxe_setup -> tests/_support_server.pm:59 called testapi::upload_logs [2023-02-24T17:46:09.853699Z] [debug] <<< testapi::wait_serial(buffer_size=undef, timeout=90, record_output=undef, expect_not_found=0, quiet=undef, no_regex=0, regexp=qr/kUYc2-\d+-/u) [2023-02-24T17:48:22.090408Z] [debug] >>> testapi::wait_serial: (?^u:kUYc2-\d+-): ok [2023-02-24T17:48:22.192704Z] [info] ::: basetest::runtest: # Test died: command 'curl --form upload=@/etc/dnsmasq.conf --form upname=_support_server-dnsmasq.conf http://10.0.2.2:20093/LRIUsP1YAxx_rFuE/uploadlog/dnsmasq.conf' failed at /var/lib/openqa/pool/9/os-autoinst-distri-rocky/tests/_support_server.pm line 59. [2023-02-24T17:48:22.196894Z] [debug] lib/installedtest.pm:36 called testapi::check_screen [2023-02-24T17:48:22.197301Z] [debug] <<< testapi::check_screen(mustmatch=[ "emergency_rescue", "emergency_rescue_nopassword" ], timeout=3) ... ``` Test links in openQA... support_server - https://openqa.rockylinux.org/tests/6691 install_pxeboot - https://openqa.rockylinux.org/tests/6692 From this analysis I think it's fine to merge this PR as it fixes what is intended.
AlanMarshall (Migrated from github.com) approved these changes 2023-02-24 19:51:56 +00:00
AlanMarshall (Migrated from github.com) left a comment

Agreed.

Agreed.
lumarel (Migrated from github.com) approved these changes 2023-02-24 20:03:35 +00:00
lumarel (Migrated from github.com) left a comment

As well looks good to me, with the output of the test!

As well looks good to me, with the output of the test!
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#155
No description provided.