consider Rocky Linux version when adding powertools/crb #176

2023-05-06T04:03:45Z

tcooper commented

2023-05-06 04:03:45 +00:00

(Migrated from github.com)

Original implementation for fix for base_update_cli with switch from python3-kickstart to pandoc-common did not consider the different name of the PowerTools (aka CRB) repository in Rocky Linux 9. This PR adds logic to do the right thing in both Rocky Linux 8 and 9.

After submission this PR will be tested in openQA and, if passed, will be moved from DRAFT status.

NOTE: Running perltidy on this file caused long lines (ie. assert_script lines) to be wrapped in a strange fashion. Investigate modifying the config for perltidy to allow these long lines.

Original implementation for fix for `base_update_cli` with switch from `python3-kickstart` to `pandoc-common` did not consider the different name of the PowerTools (aka CRB) repository in Rocky Linux 9. This PR adds logic to do the right thing in both Rocky Linux 8 and 9. After submission this PR will be tested in openQA and, if passed, will be moved from DRAFT status. NOTE: Running `perltidy` on this file caused long lines (ie. `assert_script` lines) to be wrapped in a strange fashion. Investigate modifying the config for `perltidy` to allow these long lines.

akatch commented

2023-05-10 23:28:30 +00:00

(Migrated from github.com)

I think we're still deciding what to do about pandoc-common but wanted to just note that the PR as it exists now seems to correctly enable crb instead of powertools for 9.x.

I think we're still deciding what to do about `pandoc-common` but wanted to just note that the PR as it exists now seems to correctly enable `crb` instead of `powertools` for 9.x.

AlanMarshall commented

2023-05-16 19:48:46 +00:00

(Migrated from github.com)

We still have to decide which package to use instead of pandoc-common and I agree with Al that it does correctly enable crb instead of powertools for 9.x
When this goes out of draft then it will be well on the way to approval and if we have a new package to use by then that will be even better.

We still have to decide which package to use instead of pandoc-common and I agree with Al that it does correctly enable crb instead of powertools for 9.x When this goes out of draft then it will be well on the way to approval and if we have a new package to use by then that will be even better.

tcooper commented

2023-05-24 15:59:43 +00:00

(Migrated from github.com)

Rebased to develop branch with only minor cleanup. As @AlanMarshall correctly points out we still need to resolve the choice of an appropriate replacement package for pandoc-common, possibly to revert to our own empty python3-kickstart package. The code here though does the right thing for the powertools vs crb repository enablement depending on Rocky Linux major version.

Rebased to develop branch with only minor cleanup. As @AlanMarshall correctly points out we still need to resolve the choice of an appropriate replacement package for `pandoc-common`, possibly to revert to our own empty `python3-kickstart` package. The code here though does the right thing for the `powertools` vs `crb` repository enablement depending on Rocky Linux major version.

👍 1

akatch (Migrated from github.com) approved these changes 2023-05-26 00:15:18 +00:00

Sign in to join this conversation.

No reviewers

akatch