add uefi bootloader needles #187

2023-08-04T20:52:43Z

tcooper commented

2023-08-04 20:52:43 +00:00

(Migrated from github.com)

This MR New bootloader needles for uefi boot to handle screen wrap of "Press Enter" line that appears in both 9.2 and 8.8. The 9.2 needles doesn't match for 8.8 so two needles added.

How Has This Been Tested?

needles were created in openQA production system from failed tests and tests were rerun to verify.

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

This MR New bootloader needles for uefi boot to handle screen wrap of "Press Enter" line that appears in both 9.2 and 8.8. The 9.2 needles doesn't match for 8.8 so two needles added. # How Has This Been Tested? - needles were created in openQA production system from failed tests and tests were rerun to verify. # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

akatch (Migrated from github.com) approved these changes 2023-08-05 21:57:37 +00:00

AlanMarshall (Migrated from github.com) approved these changes 2023-08-06 07:15:56 +00:00

AlanMarshall commented

2023-08-06 11:47:49 +00:00

(Migrated from github.com)

Tested on f37 and f38 servers using:

./fifloader.py --clean --load templates.fif.json
openqa-cli api -X POST isos ISO=Rocky-8.8-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.8 CURRREL=8 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-#187 TEST=install_rescue_encrypted
openqa-cli api -X POST isos ISO=Rocky-9.2-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.2 CURRREL=9 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-#187 TEST=install_rescue_encrypted

Result:
Observed successful use of needle in this and other cases :

but there is another problem here:

Tested on f37 and f38 servers using: ``` ./fifloader.py --clean --load templates.fif.json openqa-cli api -X POST isos ISO=Rocky-8.8-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.8 CURRREL=8 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-#187 TEST=install_rescue_encrypted openqa-cli api -X POST isos ISO=Rocky-9.2-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.2 CURRREL=9 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-#187 TEST=install_rescue_encrypted ``` Result: Observed successful use of needle in this and other cases : ![Screenshot 2023-08-06 at 13-22-51 openQA rocky-8 8-universal-x86_64-Build-20230806 084056 0-_187-install_simple_encrypted@uefi test results](https://github.com/rocky-linux/os-autoinst-distri-rocky/assets/3416699/fd0d1895-4098-4899-b521-c0c1712a3f86) but there is another problem here: ![Screenshot 2023-08-06 at 13-18-02 openQA rocky-8 8-universal-x86_64-Build-20230806 084056 0-_187-install_rescue_encrypted@uefi test results](https://github.com/rocky-linux/os-autoinst-distri-rocky/assets/3416699/9bdf5b96-9c6d-4a52-92c0-a62113a94b68)

AlanMarshall commented

2023-08-06 13:48:57 +00:00

(Migrated from github.com)

With the patch:

[root@107 console]# git diff
diff --git a/needles/console/rocky-bootloader_uefi-20230803.json b/needles/console/rocky-bootloader_uefi-20230803.json
index 5f779fb6..2febb713 100644
--- a/needles/console/rocky-bootloader_uefi-20230803.json
+++ b/needles/console/rocky-bootloader_uefi-20230803.json
@@ -12,6 +12,7 @@
   "tags": [
     "ENV-DISTRI-rocky",
     "ENV-LANGUAGE-english",
+    "bootloader",
     "bootloader_uefi"
   ]
 }
diff --git a/needles/console/rocky-bootloader_uefi-20230804.json b/needles/console/rocky-bootloader_uefi-20230804.json
index 896c0fc3..5badb664 100644
--- a/needles/console/rocky-bootloader_uefi-20230804.json
+++ b/needles/console/rocky-bootloader_uefi-20230804.json
@@ -12,6 +12,7 @@
   "tags": [
     "ENV-DISTRI-rocky",
     "ENV-LANGUAGE-english",
+    "bootloader",
     "bootloader_uefi"
   ]
 }
[root@107 console]#

in above test now needle used successfully:

After patch have observed successful use of needle in all cases.

With the patch: ``` [root@107 console]# git diff diff --git a/needles/console/rocky-bootloader_uefi-20230803.json b/needles/console/rocky-bootloader_uefi-20230803.json index 5f779fb6..2febb713 100644 --- a/needles/console/rocky-bootloader_uefi-20230803.json +++ b/needles/console/rocky-bootloader_uefi-20230803.json @@ -12,6 +12,7 @@ "tags": [ "ENV-DISTRI-rocky", "ENV-LANGUAGE-english", + "bootloader", "bootloader_uefi" ] } diff --git a/needles/console/rocky-bootloader_uefi-20230804.json b/needles/console/rocky-bootloader_uefi-20230804.json index 896c0fc3..5badb664 100644 --- a/needles/console/rocky-bootloader_uefi-20230804.json +++ b/needles/console/rocky-bootloader_uefi-20230804.json @@ -12,6 +12,7 @@ "tags": [ "ENV-DISTRI-rocky", "ENV-LANGUAGE-english", + "bootloader", "bootloader_uefi" ] } [root@107 console]# ``` in above test now needle used successfully: ![Screenshot 2023-08-06 at 14-17-51 openQA rocky-8 8-universal-x86_64-Build-20230806 135303 0-_187-install_rescue_encrypted@uefi test results](https://github.com/rocky-linux/os-autoinst-distri-rocky/assets/3416699/0e955963-5eb7-4865-9e8c-6338475671df) After patch have observed successful use of needle in all cases.

Sign in to join this conversation.

No reviewers

akatch

AlanMarshall