Fix select disk needles #26

2021-08-21T17:06:44Z

lumarel commented

2021-08-21 17:06:44 +00:00

(Migrated from github.com)

Description

Updates the select_disk_1 and select_disk_2 needles to fix the broken disk_guided_multi_empty_all.pm

How Has This Been Tested?

Rerun of the whole test with the fixed needles rocky-select_disk_1 and rocky-select_disk_2

How to test this

openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings (install_software_raid also uses these needles and there's a new selection select_root_already_selected needle has to be fixed, tracked in #32 )
Any dependent changes have been merged and published in downstream modules

This PR fixes #21 and will automatically close when this is resolved.

## Description Updates the `select_disk_1` and `select_disk_2` needles to fix the broken `disk_guided_multi_empty_all.pm` ## How Has This Been Tested? - [x] Rerun of the whole test with the fixed needles `rocky-select_disk_1` and `rocky-select_disk_2` ## How to test this `openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4` ## Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings (install_software_raid also uses these needles and there's a new selection `select_root_already_selected` needle has to be fixed, tracked in #32 ) - [ ] Any dependent changes have been merged and published in downstream modules This PR fixes #21 and will automatically close when this is resolved.

akatch commented

2021-08-23 05:46:29 +00:00

(Migrated from github.com)

Ran openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4 against this branch and confirmed that the full install_multi_empty@64bit suite passed.

Ran `openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4` against this branch and confirmed that the full `install_multi_empty@64bit` suite passed.

StackKorora commented

2021-08-24 13:03:18 +00:00

(Migrated from github.com)

Confirmed install_multi_empty@64bit suite passed.

Sign in to join this conversation.

No reviewers