Fix select root needle #33

2021-08-22T00:00:29Z

lumarel commented

2021-08-22 00:00:29 +00:00

(Migrated from github.com)

Description

Updates the select_root_already_selected needles to fix the broken disk_custom_software_raid.pm

How Has This Been Tested?

Rerun of the whole test with the fixed needles rocky-select_root_already_selected

How to test this

openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

This PR fixes #32 and will automatically close when this is resolved.

## Description Updates the `select_root_already_selected` needles to fix the broken `disk_custom_software_raid.pm` ## How Has This Been Tested? - [x] Rerun of the whole test with the fixed needles `rocky-select_root_already_selected` ## How to test this `openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4` ## Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] Any dependent changes have been merged and published in downstream modules This PR fixes #32 and will automatically close when this is resolved.

akatch commented

2021-08-24 02:06:07 +00:00

(Migrated from github.com)

I'm having trouble getting this one to work. Against this branch, the install_software_raid@64bit suite fails consistently at the disk_custom_software_raid module with this error:

# Test died: no candidate needle with tag(s) 'anaconda_install_destination_select_disk_1' matched

Additionally, none of the other needles in this module appear to match up with the ones listed in this PR.

I'm having trouble getting this one to work. Against this branch, the `install_software_raid@64bit` suite fails consistently at the `disk_custom_software_raid` module with this error: ``` # Test died: no candidate needle with tag(s) 'anaconda_install_destination_select_disk_1' matched ``` Additionally, none of the other needles in this module appear to match up with the ones listed in this PR.

lumarel commented

2021-08-24 05:22:55 +00:00

(Migrated from github.com)

@akatch Could you send me a screenshot of the mismatching needle with the matching? I will look into where it is not behaving 👌🏻