Needles for _graphical_wait_login
allowing English language Gnome environments to Getting Started
#49
No reviewers
Labels
No Label
priority: critical
priority: high
priority: low
priority: medium
status: abandoned
status: duplicate
status: invalid
status: peer review needed
status: wontfix
tag: content
tag: good first issue
tag: help wanted
test suite
type: bug
type: documentation
type: enhancement
type: maintenance
type: question
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: testing/os-autoinst-distri-rocky-migrated#49
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "issue_48"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Add needles to enable completion of
_graphical_wait_login
screens for Rocky EULA and Getting Started in English language installs that have GNOME desktop.Fixes #48
How Has This Been Tested?
templates.fif.json
to support briefPACKAGE_SET
variation testing.POST
of DVD ISO forFLAVOR=package-set
._graphical_wait_login
completed successfully.ISO POST
Testsuite JSON for
server_cockpit_updates
Checklist:
Hi @tcooper, I was unable to run this on top of develop.
As far as I can see #46 is needed, so this can complete successfully, will have to rerun it later, when I have the time 👌🏻
And it might be trivial to us, but if we add something to the fif files we also have to run the fif-loader again (nope I didn't fall over this, definitely not 👀)
Okay did the second run! Looks good to me 👍🏻
Yup... I assumed that those knowing how to test this would see the updated
templates.fif.json
and know that it would require a rerun offifloader.py
. That was a mistake.Also, there does seem to be a dependency on #46 that I missed when pushing these up that I didn't notice in my test machine until I redeployed it and tried re-testing everything from a clean clone with PRs dropped sequentially onto develop.
@lumarel can you drop me the sequence you used to clone/pull the changes for testing so that I can compare with my sequence? I thought there were missing needles for #49 but they appear to be in #46 as you indicated.
On the 2nd thought it really should be common knowledge, that the rerun is needed, it just was the only thing what was missing in the line ^^
@tcooper So my normal sequence is now to load the base
develop
branch and thengit fetch origin pull/49/head && git checkout FETCH_HEAD
on it to pull the PR changes (easily revertable by switching back to develop)Here I needed to fork the repo, create a new branch based on
develop
and merge the two branches from your repo and then clone my forked branch. There might be a way how this can be done offline, but I was unable to find the correct sequence to create a offline branch where I could merge your branches.@lumarel I just double checked my PR test sequence and it wasn't a complete merge of all three PRs.
Indeed, #46 is required for #49 and there is a conflict between #46 and #47 that I'll need to resolve to merge #47 after #46.
Also, I found a strange case where the
_software_selection
for thegraphical-server
package set passed for me before but will not pass now. Not sure if/how your testing could have passed this step before but it's likely yet another test system speed/timing issue.It is resolved with a small check that I added to this PR.
The last commit (I hope) to this PR restores the test suites for
PACKAGE_SET={minimal,server,virtualization-host}
to therocky-package-set
Job Group via an update totemplates.fif.json
. Yes... you must re-run./fifloader.py ...
to make these available.The following
POST
will trigger all 5 primary package set installs from the DVD ISO...Sorry for the delay, it took me some more time to test this more extensively now 🙂
@tcooper and @StackKorora I think this can also be merged 👌🏻