Fixes install_mirrorlist_graphical@64bit on rocky-8.4-universal-x86_64 #53

Merged

lumarel merged 1 commit from fix-install-source-graphical-2 into develop

2021-10-21 23:46:48 +00:00

lumarel commented

2021-10-08 20:41:12 +00:00

(Migrated from github.com)

Description

This PR integrates a check for the mirrorlist applying by applying a second time if it errors out on the first time, unfortunately this happens quite consistently when the internet connection is to slow.

This PR fixes #52 and will automatically close when this is resolved.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4

It is only necessary to run install_mirrorlist_graphical@64bit, all other test-suites can be aborted.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

## Description This PR integrates a check for the mirrorlist applying by applying a second time if it errors out on the first time, unfortunately this happens quite consistently when the internet connection is to slow. This PR fixes #52 and will automatically close when this is resolved. ## How Has This Been Tested? `openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4` It is only necessary to run `install_mirrorlist_graphical@64bit`, all other test-suites can be aborted. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

tcooper (Migrated from github.com) approved these changes 2021-10-13 16:17:37 +00:00

tcooper (Migrated from github.com) left a comment

Works as advertised...

Configure upstream remote and pull PR

[rocky@openqa-dev ~]$ cd /var/lib/openqa/tests/rocky
[rocky@openqa-dev rocky]$ git remote -v
origin  https://github.com/rocky-linux/os-autoinst-distri-rocky.git (fetch)
origin  https://github.com/rocky-linux/os-autoinst-distri-rocky.git (push)

[rocky@openqa-dev rocky]$ git remote add upstream https://github.com/rocky-linux/os-autoinst-distri-rocky.git

[rocky@openqa-dev rocky]$ git fetch upstream pull/53/head:pr53
remote: Enumerating objects: 15, done.
remote: Counting objects: 100% (15/15), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 9 (delta 6), reused 9 (delta 6), pack-reused 0
Unpacking objects: 100% (9/9), 52.61 KiB | 286.00 KiB/s, done.
From https://github.com/rocky-linux/os-autoinst-distri-rocky
 * [new ref]           refs/pull/53/head -> pr53

[rocky@openqa-dev rocky]$ git checkout pr53
Switched to branch 'pr53'

[rocky@openqa-dev rocky]$ git diff --compact-summary develop
 ...ocky-anaconda_main_hub_installation_source_error-20211008.json (new) |  16 ++++++++++++++++
 ...rocky-anaconda_main_hub_installation_source_error-20211008.png (new) | Bin 0 -> 57319 bytes
 tests/install_source_graphical.pm                                       |  12 ++++++++++++
 3 files changed, 28 insertions(+)

Apply stashed local mods to ensure test completes (not required on other systems)

[rocky@openqa-dev rocky]$ git stash apply
On branch pr53
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   tests/_do_install_and_reboot.pm

no changes added to commit (use "git add" and/or "git commit -a")

[rocky@openqa-dev rocky]$ git diff tests/_do_install_and_reboot.pm
diff --git a/tests/_do_install_and_reboot.pm b/tests/_do_install_and_reboot.pm
index af2d6225..d7096e50 100644
--- a/tests/_do_install_and_reboot.pm
+++ b/tests/_do_install_and_reboot.pm
@@ -110,7 +110,7 @@ sub run {
 
     # Wait for install to end. Give Rawhide a bit longer, in case
     # we're on a debug kernel, debug kernel installs are really slow.
-    my $timeout = 1800;
+    my $timeout = 7200;
     my $version = lc(get_var('VERSION'));
     if ($version eq "rawhide") {
         $timeout = 2400;

POST specified ISO and specify only install_mirrorlist_graphical test

[rocky@openqa-dev rocky]$ sudo openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4 BUILD=-universal-$(date +%Y%m%d.%H%M%S).0 TEST=install_mirrorlist_graphical
{"count":1,"failed":[],"ids":[390],"scheduled_product_id":29}

Verify job is running

[rocky@openqa-dev rocky]$ openqa-cli api jobs/390 | jq '.["job"]|.["state"]'
"running"

Verify job success

[rocky@openqa-dev rocky]$ openqa-cli api jobs/390 | jq '.["job"]|.["id","name","result","state","t_started","t_finished"]'
390
"rocky-8.4-universal-x86_64-Build-universal-20211013.074145.0-install_mirrorlist_graphical@64bit"
"passed"
"done"
"2021-10-13T14:43:27"
"2021-10-13T15:21:22"

Works as advertised... ### Configure upstream remote and pull PR ``` [rocky@openqa-dev ~]$ cd /var/lib/openqa/tests/rocky [rocky@openqa-dev rocky]$ git remote -v origin https://github.com/rocky-linux/os-autoinst-distri-rocky.git (fetch) origin https://github.com/rocky-linux/os-autoinst-distri-rocky.git (push) ``` ``` [rocky@openqa-dev rocky]$ git remote add upstream https://github.com/rocky-linux/os-autoinst-distri-rocky.git ``` ``` [rocky@openqa-dev rocky]$ git fetch upstream pull/53/head:pr53 remote: Enumerating objects: 15, done. remote: Counting objects: 100% (15/15), done. remote: Compressing objects: 100% (3/3), done. remote: Total 9 (delta 6), reused 9 (delta 6), pack-reused 0 Unpacking objects: 100% (9/9), 52.61 KiB | 286.00 KiB/s, done. From https://github.com/rocky-linux/os-autoinst-distri-rocky * [new ref] refs/pull/53/head -> pr53 ``` ``` [rocky@openqa-dev rocky]$ git checkout pr53 Switched to branch 'pr53' ``` ``` [rocky@openqa-dev rocky]$ git diff --compact-summary develop ...ocky-anaconda_main_hub_installation_source_error-20211008.json (new) | 16 ++++++++++++++++ ...rocky-anaconda_main_hub_installation_source_error-20211008.png (new) | Bin 0 -> 57319 bytes tests/install_source_graphical.pm | 12 ++++++++++++ 3 files changed, 28 insertions(+) ``` ### Apply stashed local mods to ensure test completes (not required on other systems) ``` [rocky@openqa-dev rocky]$ git stash apply On branch pr53 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: tests/_do_install_and_reboot.pm no changes added to commit (use "git add" and/or "git commit -a") ``` ``` [rocky@openqa-dev rocky]$ git diff tests/_do_install_and_reboot.pm diff --git a/tests/_do_install_and_reboot.pm b/tests/_do_install_and_reboot.pm index af2d6225..d7096e50 100644 --- a/tests/_do_install_and_reboot.pm +++ b/tests/_do_install_and_reboot.pm @@ -110,7 +110,7 @@ sub run { # Wait for install to end. Give Rawhide a bit longer, in case # we're on a debug kernel, debug kernel installs are really slow. - my $timeout = 1800; + my $timeout = 7200; my $version = lc(get_var('VERSION')); if ($version eq "rawhide") { $timeout = 2400; ``` ### POST specified ISO and specify only install_mirrorlist_graphical test ``` [rocky@openqa-dev rocky]$ sudo openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4 BUILD=-universal-$(date +%Y%m%d.%H%M%S).0 TEST=install_mirrorlist_graphical {"count":1,"failed":[],"ids":[390],"scheduled_product_id":29} ``` ### Verify job is running ``` [rocky@openqa-dev rocky]$ openqa-cli api jobs/390 | jq '.["job"]|.["state"]' "running" ``` ### Verify job success ``` [rocky@openqa-dev rocky]$ openqa-cli api jobs/390 | jq '.["job"]|.["id","name","result","state","t_started","t_finished"]' 390 "rocky-8.4-universal-x86_64-Build-universal-20211013.074145.0-install_mirrorlist_graphical@64bit" "passed" "done" "2021-10-13T14:43:27" "2021-10-13T15:21:22" ```