Fixes needle with invalid JSON and adds pre-commit configuration #59

2021-11-10T08:34:15Z

tcooper commented

2021-11-10 08:34:15 +00:00

(Migrated from github.com)

Description

This PR adds repairs a needle with invalid JSON and fixes #58. In addition, it adds pre-commit configuration to prevent future errors similar in nature.

NOTE: The pre-commit configuration includes the end-of-file-fixer hook which will make sure all files end with a newline character. openQA needle editor does not put a newline at the end of needle JSON files. All new needles will be modified to include a newline at the end automatically.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

## Description This PR adds repairs a needle with invalid JSON and fixes #58. In addition, it adds `pre-commit` configuration to prevent future errors similar in nature. *NOTE: The `pre-commit` configuration includes the `end-of-file-fixer` hook which will make sure all files end with a newline character. openQA needle editor does not put a newline at the end of needle JSON files. All new needles will be modified to include a newline at the end automatically.* ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

lumarel commented

2021-11-10 17:37:51 +00:00

(Migrated from github.com)

Looks good to me, looking forward to getting checked by pre-commit 🙂 👌🏻

Sign in to join this conversation.

No reviewers