Add needles to complete tests requiring HDD_1 inputs #75

2022-01-31T00:17:57Z

tcooper commented

2022-01-31 00:17:57 +00:00

(Migrated from github.com)

Description

This PR adds needles to complete tests currently part of FLAVOR=universal requiring pre-created *.img files generated by createdhdds.py.

This PR also fixes #57 and will automatically close that issue when this is merged.

How Has This Been Tested?

openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_delete_partial
openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_delete_pata
openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_shrink_ext4
openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_shrink_ntfs
openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_simple_free_space

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

## Description This PR adds needles to complete tests currently part of `FLAVOR=universal` requiring pre-created `*.img` files generated by `createdhdds.py`. This PR also fixes #57 and will automatically close that issue when this is merged. ## How Has This Been Tested? ```sh openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_delete_partial openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_delete_pata openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_shrink_ext4 openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_shrink_ntfs openqa-cli api -X POST isos ARCH=x86_64 BUILD=Rocky-8.5-$(date +%Y%m%d.%H%M%S).0 DISTRI=rocky VERSION=8.5 ISO=Rocky-8.5-x86_64-dvd1.iso FLAVOR=universal TEST=install_simple_free_space ``` ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

StackKorora (Migrated from github.com) reviewed 2022-01-31 00:17:57 +00:00

lumarel (Migrated from github.com) approved these changes 2022-01-31 15:41:40 +00:00

lumarel (Migrated from github.com) left a comment

Everything looks good 🙂👌🏻
All tests pass!

Everything looks good 🙂👌🏻 All tests pass!

akatch (Migrated from github.com) approved these changes 2022-02-01 07:31:48 +00:00

akatch (Migrated from github.com) left a comment

LGTM

Sign in to join this conversation.

No reviewers

StackKorora

lumarel