[8.6 Release Issues] Add new needle to mitigate source default change #96

2022-05-15T00:08:34Z

lumarel commented

2022-05-15 00:08:34 +00:00

(Migrated from github.com)

Description

This PR adds a needle which mitigates the change of the source spoke, when switched to "install from network", so it defaults to https now instead of http, which the previous needle doesn't expect.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-8.6-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.6 BUILD=-universal-$(date +%Y%m%d.%H%M%S).0 TEST=install_mirrorlist_graphical

Expect this change break on _check_install_source because there is no 8.6 in the mirrorlist.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

# Description This PR adds a needle which mitigates the change of the source spoke, when switched to "install from network", so it defaults to https now instead of http, which the previous needle doesn't expect. # How Has This Been Tested? ``` openqa-cli api -X POST isos ISO=Rocky-8.6-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.6 BUILD=-universal-$(date +%Y%m%d.%H%M%S).0 TEST=install_mirrorlist_graphical ``` Expect this change break on `_check_install_source` because there is no 8.6 in the mirrorlist. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] Any dependent changes have been merged and published in downstream modules

tcooper (Migrated from github.com) reviewed 2022-05-15 00:08:34 +00:00

akatch (Migrated from github.com) approved these changes 2022-05-16 18:45:31 +00:00

akatch (Migrated from github.com) left a comment

Test as above passes install_source_graphical and fails on check_install_source as expected. LGTM :shipit:

Test as above passes `install_source_graphical` and fails on `check_install_source` as expected. LGTM :shipit:

Sign in to join this conversation.

No reviewers

tcooper

akatch