Commit Graph

1711 Commits

Author SHA1 Message Date
Adam Williamson
b9df4c4671 More fiddling with this goddamn KDE logic loop
Man, this thing can get into a lot of states. Apparently somehow
it can go straight from refresh to reboot?

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-30 12:50:32 -07:00
Adam Williamson
16ded56935 Add KDE package refresh needle, tweak retry logic a bit
KDE update was still often failing on #1943943, so this tries a
bit harder to work around it. We add a 'refresh' needle for KDE,
and tweak the 'retry' logic to click it if we get to that point.
Note adding the needle also changes behaviour slightly - we may
click this needle if we see it on first entering the screen. So
either change may be helping. Either way, this does make the test
more reliable.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-30 12:27:34 -07:00
Lukáš Růžička
57cd0cb3c6 Fix a typo in the needle file.
There was a typo in the apps_menu_button_french_20161215 which
prevented the `check_needles.py` from exiting gracefully.
The fix solves the situation.
2021-03-30 12:06:29 +02:00
Adam Williamson
ed9136225d Shorten the leftbar newlogo needle a bit for KDE live
KDE lives cut this off a bit because the taskbar is under it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-29 12:50:03 -07:00
Adam Williamson
075d479b58 Note the bug number for the Plasma Discover problem
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-28 09:51:43 -07:00
Adam Williamson
e25ffe2f05 Try to handle KDE 'apply updates' button not always working
Sometimes we click the button, it cycles briefly, and...just
comes back. To avoid unpredictable failures on update tests that
have nothing to do with the update, let's try and handle this by
just clicking it till it works.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-28 08:56:27 -07:00
Adam Williamson
1fc2edfda4 Fix desktop update test for KDE in F34+
We now have to run Plasma Discover, not use the systray thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-27 23:44:12 -07:00
Adam Williamson
10af8015ea Update anaconda newlogo identification icon for tweaked logo
Design team tweaked the new logo a bit in anaconda. We probably
won't need the old needle any more, but I'll take that out later.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-26 21:06:30 -07:00
Adam Williamson
0c0e25873d Another apps_menu_button French needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-26 20:43:30 -07:00
Adam Williamson
4c623f61f9 Update getting_started tour needle
Not sure if this difference is 40 stable vs. 40 beta or just
different in French for some reason.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-26 18:25:25 -07:00
Adam Williamson
106006cbc1 Update login input and GNOME app menu needles for non-English
We'll need a couple more needles too, but this is a start.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-26 18:24:42 -07:00
Adam Williamson
1819a9c2e1 Update locked screen user switch needle for GNOME 40 change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-25 23:47:51 -07:00
Lukáš Růžička
d82eae850d Add UEFI versions of cust_btrfs_pres_home and custom_std_part. 2021-03-25 11:28:36 +01:00
Adam Williamson
29f75788e9 Update a bunch of GNOME app needles for GNOME 40 final
Some apps moved around, others the needles stopped matching for
some reason, some kind of slight scale change or something.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 18:36:38 -07:00
Adam Williamson
a01d8b6148 GNOME: Document Scanner no longer in utilities either
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 17:31:03 -07:00
Adam Williamson
1a16a5a379 System Monitor not in utilities any more, either
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 17:19:20 -07:00
Adam Williamson
c4f60ab274 GNOME apps: Calculator and Help aren't in utilities any more
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 16:03:33 -07:00
Adam Williamson
cde370bf1b Update several needles for new Fedora logo
The package with the new logo is not submitted as an update yet,
but we ran the tests on the Koji build and these are the new
needles. We'll need more when we run the full set of compose
tests on the change.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-24 12:58:30 -07:00
Adam Williamson
b2e9ea6a48 allowlist select_bootefi in check-needles.py
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 18:25:07 -07:00
Adam Williamson
a8f7d3639f Remove kgpg_tips_close needles
I tweaked the test to no longer require these.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 18:23:25 -07:00
Adam Williamson
36ad08868c Remove Calligra needles
KDE has LibreOffice now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 18:22:56 -07:00
Adam Williamson
2c3241dc75 Don't do the plymouth workaround for ostree deployments
...because we don't have RPM there, Jim.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 16:45:05 -07:00
Adam Williamson
25210463c5 Add more needles for console passphrase entry
Now we have plymouth not installed by default, we have more
different cases of hitting this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 16:40:03 -07:00
Adam Williamson
805d303511 Add alternative cockpit "updated" needle
When we have to restart Cockpit during the update, we don't get
the usual "successful" screen after logging back in, we'll have
to match on something indicating an update did happen. I wanted
to use the little icon next to the package count but it seems to
have some kind of problem with anti-aliasing or something, I've
created two needles for it and neither matched on the next run
of the test. So let's match on this "reboot needed" text instead,
I hope it'll always be there when we hit this case.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 16:35:24 -07:00
Adam Williamson
a6ea09e4d5 Install plymouth in aarch64 encrypted test (workaround #1940163)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-17 17:36:34 -07:00
Adam Williamson
48cee79928 Always wait_still_screen after hitting Update Settings
It can take anaconda a bit of time to think about things, so we
should wait before plowing on.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-17 14:19:20 -07:00
Adam Williamson
dfafdc22dd Wait for screen to settle during disk_custom_with_swap
Seems we can get the UI into a buggy state if we click the + too
fast here on aarch64.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-17 12:15:44 -07:00
Adam Williamson
05dfbef1a8 Update Activities button handling for latest GNOME
Make the 'deactivate overview if it's active' thing a bit more
robust by asserting the inactive state after deactivating it,
and add new needles for the new RC (text got a bit brighter).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-16 17:24:08 -07:00
Adam Williamson
eec43a4e2b Add another version of KDE desktop update notification needle
Darn transparency. This is for F33 respin testing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-12 18:39:53 -08:00
Adam Williamson
3ee11c2ac5 Update user_logged_in-noprofile-sh needle for bash 5.1
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-12 18:39:03 -08:00
Adam Williamson
c0cced6a3f Update GNOME login needles for darker GDM
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-12 18:38:14 -08:00
Adam Williamson
1b6181b4af Update Cockpit log entry details needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-12 18:36:33 -08:00
Adam Williamson
c44e7fb869 Update F34 workarounds: drop stable ones, update systemd
Drop Firefox and NSS updates which have been stable for a while,
update the systemd one to the latest which should hopefully
finally workaround the DNS issues.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-12 18:34:08 -08:00
Adam Williamson
d414ae3994 desktop_login: don't assert wrong password message on F34+
In GDM 40 the message is displayed only briefly, like in SDDM,
so we can't assert it. Only do it for <F34.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-10 17:00:01 -08:00
Adam Williamson
37dba6adc4 Hit 'esc' rather than 'ret' to clear SDDM screensaver state
OK, extending the timeout didn't work. Try this instead. The
problem is when GNOME takes a long time to log out we wrongly
decide we're in the "DM is showing a 'screensaver' state" case
and hit 'ret' to clear it. In GDM that selects the highlighted
user. Maybe if we use 'esc', it'll still work in SDDM to clear
the screensaver state, but not select the first user in the list
in GDM...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-10 16:14:43 -08:00
Adam Williamson
ff585d8147 Wait longer for still screen when logging out in desktop_login
This is a bandaid for GNOME taking a long time to log out right
now. I would prefer to make login_user more robust, but that's a
bit more complicated as it's used for both unlock and login.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-10 15:48:25 -08:00
Adam Williamson
e705d0829a Use --isolation=simple for all mock commands in _live_build
I think this will help avoid the DNS resolution problems.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-09 16:02:06 -08:00
Adam Williamson
12de9331c5 Revert "Ditch the systemd workaround build for now"
This reverts commit e23df39ee1,
putting the systemd workaround back in place, now we know how to
avoid the bug it causes. It's going stable tomorrow anyway, but
I want to re-run failed tests with the fix right away. Used the
update ID this time, not the build number.
2021-03-08 14:24:24 -08:00
Adam Williamson
21385361ed F34+: disable systemd-oomd during update install (#1931034)
This will avoid us hitting a crash in systemd during update when
systemd is being updated. That's a real bug and it's good that
it's been caught, but we don't want unrelated updates to fail on
this just because systemd is in the update set.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-08 14:01:46 -08:00
Adam Williamson
ac9edb4cfb GNOME apps: drop Archiver test
The app was dropped from Workstation's default package set a few
days ago. See:
https://pagure.io/fedora-workstation/issue/167

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 18:25:29 -08:00
Adam Williamson
e23df39ee1 Ditch the systemd workaround build for now
It's causing crashes on update. I tried making us do an offline
update in repo_setup, not online, but that's actually quite hard
to implement so I'm not gonna do it on a Friday night. We'll
just live with unreliable _live_build for a bit longer.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 18:22:13 -08:00
Adam Williamson
72369df2fc Set several extra schema keys for update notification test
GNOME got even more clever-clever about only checking for and
notifying about updates after a certain amount of time, so we
need to fake it out even harder. See
https://bugzilla.redhat.com/show_bug.cgi?id=1930401 and
https://wiki.gnome.org/Design/Apps/Software/Updates#Tentative_Design
Note the test will still fail for now as there is an actual bug
that needs fixing, but once the fix is in, this should work.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:56:56 -08:00
Adam Williamson
b349e7cb1a Update GNOME update notification needle for GNOME 40
The icon looks a bit different now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:53:36 -08:00
Adam Williamson
a32a205e7a Update kgpg_runs needle for latest Plasma
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:50:22 -08:00
Adam Williamson
3b0dc6b021 kgpg: don't try and close tip of the day any more
Main UI appears over the tip of the day now, so we can ignore it
and just check the UI ran then close it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:49:28 -08:00
Adam Williamson
3c92696d98 Convert ksysguard test to Plasma system monitor test
These were switched out in comps recently.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 17:20:59 -08:00
Adam Williamson
f6fa89f2cf Remove falkon, k3b, krusader, ktorrent from KDE app startstop
They have all been dropped from the spin recently. Remove all
related needles too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 15:58:37 -08:00
Adam Williamson
52a862aae9 Add scratch build for #1933433 as a workaround
I'm hoping this should fix the intermittent _live_build failures.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 13:24:30 -08:00
Adam Williamson
540f667c1d Drop F34 workaround updates that have gone stable
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-05 13:23:59 -08:00
Adam Williamson
1e5d767fa3 Handle GNOME 40 now starting at overview, not desktop
For consistency, let's just return to the desktop right away. We
also need to handle closing the overview before running installer
on live image boot.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-04 16:03:21 -08:00