curl won't follow redirects without -L. Since redirects are used by some who
have a private repository this breaks curl in those instances. Adding -L fixes
the problem.
We use features that were introduced in bash 4.2, specifically negative array
indexing. Since EL8 comes stock with bash 4.4 this is not an issue but just in
case someone has done somethign stupid we update our version check to make sure
that at least 4.2 is being run.
OracleLinux renames a nubmer of module streams from rhel8 to ol8 and from rhel
to ol. This commit maps the names back to rhel8 and rhel so that migrate2rocky
doesn't blow up on them.
If there's going to be errors due to corrupted repos, etc we want to find out
right away so we can bail before we put the system in an unstable state. To
this end we dump the dnf cache right away to make sure that dnf is forced to hit
the repos insteada of relying on cached data.
In order to properly parse output from certain commands we must ensure that
output is in the correct locale and character set. Previously we had just set
LANG but that doesn't force the issue and some systems may still have issues.
While this change will override a person's foreign language preferences this is
preferable to it causing a failed migration.
dnf has a bug where it will display the error message, "No matches found for the
following enable plugin patterns: config-manager". This message is a red
herring and dnf does, in fact, find and enable the display-manager plugin for
the command. The message may be safely ignored.
Check to make sure that dnf-plugins-core is present, and force-enable the
config-manager plugin for those dnf commands that need it in case it has been
disabled.
* Attempt to run dnf update before the migration.
While a migration will generally work without first running dnf update, thera
are several advantages of attempting to run an update first:
* We catch corner cases that an update will solve.
* Since we're running a distro-sync at the end, it effectively updates anyways
and the same things that will break a distro-sync will often times break an
update. By attempting to run the update first we will discover those
breakages before we put the system into an unstable state and we can bail out
if the update fails, preventing a potentially disastrous outcome.
* efibootmgr needs separate disk and partition
efibootmgr needs a separate device (/dev/xxx) and partition number.
Co-authored-by: McNutnut <mcnutnut90@gmail.com>
Oracle 8.4 moved some files from their oraclelinux-release package to a new
package named redhat-release. This update makes sure to remove redhat-release
as well as the other packages during migration to avoid conflicts with
rocky-release.
After a RHEL conversion any attempt to run subscription-manager would result in
an error. this was due to the RedHat certs having been replaced on the system
during the migration. To fix this we now copy any subscription-manager certs to
a temporary directory and if they have been removed during the migration we copy
them back at the finish. This means that subscription-manager now won't stop
working after a migration from RHEL.
We previously removed color because (1) it was outputting the color codes to the
log file, which we do not want and (2) nobody could agree on what colors to use.
I've reintroduced color now fixing (1) by allowing for separate output to the
log file and the console and only sending the color codes to the console and (2)
well, I've changed the blue for info messages to cyan, hopefully everyone's
happy with that, but I'm open to suggestions on the info color.
There are now three more file descriptors for specialized output control, making a total of 5:
fd1 - This sends to stdout and to the log file.
fd2 - This sends to stderr and the log file.
fd3 - This just sends to stdout.
fd4 - This just sends to stderr.
fd5 - This just sends to the logfile.
There are also three additional functions:
msg_format - Intended to be used by infomsg and errmsg, this accepts a variable
name and one or more string args. If there is just one string after the
variable name then it is copied to the variable verbatim. If there is more than
one then it is taken to be a format specifier and additional args to be passed
to printf (output going to the variable).
infomsg - This will accept either a single arg which contains a verbatim string
or multiple format / args to be processed by printf. The output of this will be
sent to the log file and also color coded and sent to stdout.
errmsg - Like infomsg but it uses the error color and sends output to stderr
instead of stdout.
/etc/issue used to contain a nice ascii-art RockyLinux logo that we would output
when this script was finished, but it doesn't anymore so there is no longer any
value to outputting this file.
